From: "Lu, Wenzhuo" <wenzhuo.lu@intel.com>
To: "Yigit, Ferruh" <ferruh.yigit@intel.com>,
Stephen Hemminger <stephen@networkplumber.org>
Cc: "dev@dpdk.org" <dev@dpdk.org>
Subject: Re: [dpdk-dev] [PATCH v3 1/2] net/i40e: new API to add VF MAC address from PF
Date: Sat, 19 Aug 2017 12:52:29 +0000 [thread overview]
Message-ID: <6A0DE07E22DDAD4C9103DF62FEBC09093B693E7C@shsmsx102.ccr.corp.intel.com> (raw)
In-Reply-To: <a4b1872e-5aa4-7415-0b59-aaf4391e3b15@intel.com>
Hi,
> -----Original Message-----
> From: Yigit, Ferruh
> Sent: Friday, August 18, 2017 12:43 PM
> To: Stephen Hemminger <stephen@networkplumber.org>; Lu, Wenzhuo
> <wenzhuo.lu@intel.com>
> Cc: dev@dpdk.org
> Subject: Re: [dpdk-dev] [PATCH v3 1/2] net/i40e: new API to add VF MAC
> address from PF
>
> On 8/18/2017 1:32 AM, Stephen Hemminger wrote:
> > On Fri, 18 Aug 2017 02:33:42 +0800
> > Wenzhuo Lu <wenzhuo.lu@intel.com> wrote:
> >
> >> Currently, rte_eth_dev_mac_addr_add is used by a testpmd CLI to add a
> >> MAC address for VF. But the parameter 'pool' of this API means the
> >> VMDq pool, not VF.
> >> So, it's wrong to use it to add the VF MAC address.
> >> This patch provides a new API that can be used to add VF MAC address
> >> on i40e.
> >>
> >> Signed-off-by: Wenzhuo Lu <wenzhuo.lu@intel.com>
> >
> > What do other drivers do?
>
> This is adding VF MAC through PF, not all PMDs support this.
>
> > Sorry, a driver specific API is (almost) always the wrong solution.
>
> Currently there are set of device specific APIs [1].
>
> The motivation was to be able to expose NIC specific features, abstraction
> layer should not prevent using HW features; while keeping abstraction clean
> for common majority, not having APIs valid only for a single NIC.
>
> But with number of the device specific APIs increasing, it may be time to
> bring postponed discussion to life on how to manage them.
>
> Recent ioclt or staging dev_ops was a good tart:
> http://dpdk.org/ml/archives/dev/2017-August/thread.html#72423
>
>
> [1]
> Physical PMDs with device specific API: i40e, ixgbe, bnxt Virtual PMDs with
> device specific API: ring, vhost, bonding, xenvirt
This patch follows the existing bnxt example to implement the same function on i40e.
Totally agree the private API is not a good idea. To my opinion, as many same functions are implemented on ixgbe, i40e, bnxt, it's them time to make them public. Let me send some RFC later.
next prev parent reply other threads:[~2017-08-19 12:52 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-07-24 20:51 [dpdk-dev] [PATCH] " Wenzhuo Lu
2017-07-25 14:09 ` [dpdk-dev] [PATCH v2] " Wenzhuo Lu
2017-08-17 13:05 ` Ferruh Yigit
2017-08-17 13:36 ` Lu, Wenzhuo
2017-08-17 18:33 ` [dpdk-dev] [PATCH v3 0/2] fix adding VF MAC in testpmd Wenzhuo Lu
2017-08-17 18:33 ` [dpdk-dev] [PATCH v3 1/2] net/i40e: new API to add VF MAC address from PF Wenzhuo Lu
2017-08-18 0:32 ` Stephen Hemminger
2017-08-18 16:43 ` Ferruh Yigit
2017-08-19 12:52 ` Lu, Wenzhuo [this message]
2017-08-17 18:33 ` [dpdk-dev] [PATCH v3 2/2] app/testpmd: fix wrong API of adding VF MAC Wenzhuo Lu
2017-08-28 9:53 ` [dpdk-dev] [PATCH v3 0/2] fix adding VF MAC in testpmd Ferruh Yigit
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=6A0DE07E22DDAD4C9103DF62FEBC09093B693E7C@shsmsx102.ccr.corp.intel.com \
--to=wenzhuo.lu@intel.com \
--cc=dev@dpdk.org \
--cc=ferruh.yigit@intel.com \
--cc=stephen@networkplumber.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).