DPDK patches and discussions
 help / color / mirror / Atom feed
From: Maryam Tahhan <mtahhan@redhat.com>
To: "Koikkara Reeny, Shibin" <shibin.koikkara.reeny@intel.com>,
	"ferruh.yigit@amd.com" <ferruh.yigit@amd.com>,
	"stephen@networkplumber.org" <stephen@networkplumber.org>,
	"lihuisong@huawei.com" <lihuisong@huawei.com>,
	"fengchengwen@huawei.com" <fengchengwen@huawei.com>,
	"liuyonglong@huawei.com" <liuyonglong@huawei.com>
Cc: "dev@dpdk.org" <dev@dpdk.org>
Subject: Re: [v1] net/af_xdp: enable a sock path alongside use_cni
Date: Thu, 30 Nov 2023 14:17:25 +0000	[thread overview]
Message-ID: <6c78956f-b3f6-483c-8072-f0e6d8610986@redhat.com> (raw)
In-Reply-To: <DM6PR11MB3995A6E5195D52EB3559E4B9A282A@DM6PR11MB3995.namprd11.prod.outlook.com>

[-- Attachment #1: Type: text/plain, Size: 1647 bytes --]

Hi Shibin

No problem.

Answer below.

BR
Maryam
On 30/11/2023 13:56, Koikkara Reeny, Shibin wrote:
> Hi Maryam,
>
> I have one more question.
>
> Regards,
> Shibin
>
>> -----Original Message-----
>> From: Koikkara Reeny, Shibin<shibin.koikkara.reeny@intel.com>
>> Sent: Thursday, November 30, 2023 12:14 PM
>> To: Tahhan, Maryam<mtahhan@redhat.com>;ferruh.yigit@amd.com;
>> stephen@networkplumber.org;lihuisong@huawei.com;
>> fengchengwen@huawei.com;liuyonglong@huawei.com
>> Cc:dev@dpdk.org; Tahhan, Maryam<mtahhan@redhat.com>
>> Subject: RE: [v1] net/af_xdp: enable a sock path alongside use_cni
>>
>> Hi Maryam,
>>
>> I have added some suggestion below.
>>
>> Regrads,
>> Shibin

[snip]

>>>   Prerequisites
>>> @@ -224,7 +225,6 @@ Howto run dpdk-testpmd with CNI plugin:
>>>             capabilities:
>>>                add:
>>>                  - CAP_NET_RAW
>>> -               - CAP_BPF
> Why the CAP_BPF is removed?


Good question. It's removed because in our case CAP_BPF is only needed 
when we want to load or unload the XDP program on the interface inside 
the Pod. In our case the CNI is loading the xdp program on the interface 
and then we are doing a handshake to get the xskmap file descriptor and 
so we don't need the CAP_BPF.

You will find a detailed listing of the permissions used at different 
stages when utilizing an XDP prog in this article 
https://next.redhat.com/2023/07/18/using-ebpf-in-unprivileged-pods/

I'm currently also working on enabling pinned map sharing with the 
af_xdp vdev eal arguments so we can integrate with bpfman for 
centralized BPF program lifecycle management [currently under test].

[snip]

[-- Attachment #2: Type: text/html, Size: 3692 bytes --]

  reply	other threads:[~2023-11-30 14:17 UTC|newest]

Thread overview: 13+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-11-30  9:13 Maryam Tahhan
2023-11-30 12:14 ` Koikkara Reeny, Shibin
2023-11-30 12:32   ` Maryam Tahhan
2023-11-30 13:55     ` Koikkara Reeny, Shibin
2023-11-30 13:56   ` Koikkara Reeny, Shibin
2023-11-30 14:17     ` Maryam Tahhan [this message]
2023-12-01  9:55       ` Koikkara Reeny, Shibin
2023-12-01 10:20         ` Maryam Tahhan
2023-12-01 10:49           ` Koikkara Reeny, Shibin
2023-11-30 14:30     ` Maryam Tahhan
2023-12-01 10:26 ` David Marchand
2023-12-01 10:31   ` Maryam Tahhan
2023-12-01 10:33     ` Maryam Tahhan

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=6c78956f-b3f6-483c-8072-f0e6d8610986@redhat.com \
    --to=mtahhan@redhat.com \
    --cc=dev@dpdk.org \
    --cc=fengchengwen@huawei.com \
    --cc=ferruh.yigit@amd.com \
    --cc=lihuisong@huawei.com \
    --cc=liuyonglong@huawei.com \
    --cc=shibin.koikkara.reeny@intel.com \
    --cc=stephen@networkplumber.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).