From: "Iremonger, Bernard" <bernard.iremonger@intel.com>
To: "Yigit, Ferruh" <ferruh.yigit@intel.com>, "dev@dpdk.org" <dev@dpdk.org>
Subject: Re: [dpdk-dev] [PATCH] bonding: fix crash when no slave devices
Date: Fri, 4 Mar 2016 17:20:13 +0000 [thread overview]
Message-ID: <8CEF83825BEC744B83065625E567D7C219FBFB9B@IRSMSX108.ger.corp.intel.com> (raw)
In-Reply-To: <56D9C23B.8000508@intel.com>
Hi Ferruh,
> -----Original Message-----
> From: Yigit, Ferruh
> Sent: Friday, March 4, 2016 5:14 PM
> To: Iremonger, Bernard <bernard.iremonger@intel.com>; dev@dpdk.org
> Subject: Re: [dpdk-dev] [PATCH] bonding: fix crash when no slave devices
>
> On 2/23/2016 12:13 PM, Bernard Iremonger wrote:
> > If a bonded device is created when there are no slave devices there is
> > loop in bond_ethdev_promiscous_enable() which results in a
> > segmentation fault.
> > I have applied a similar fix to bond_ethdev_promiscous_disable() where
> > a similar loop could occur.
> >
> > Fixes: 2efb58cbab6e ("bond: new link bonding library")
> > Signed-off-by: Bernard Iremonger <bernard.iremonger@intel.com>
> > ---
> > drivers/net/bonding/rte_eth_bond_pmd.c | 6 ++++--
> > 1 file changed, 4 insertions(+), 2 deletions(-)
> >
> > diff --git a/drivers/net/bonding/rte_eth_bond_pmd.c
> > b/drivers/net/bonding/rte_eth_bond_pmd.c
> > index b63c886..78972fc 100644
> > --- a/drivers/net/bonding/rte_eth_bond_pmd.c
> > +++ b/drivers/net/bonding/rte_eth_bond_pmd.c
> > @@ -1870,7 +1870,8 @@ bond_ethdev_promiscuous_enable(struct
> rte_eth_dev *eth_dev)
> > case BONDING_MODE_TLB:
> > case BONDING_MODE_ALB:
> > default:
> > - rte_eth_promiscuous_enable(internals-
> >current_primary_port);
> > + if (internals->slave_count > 0)
> > + rte_eth_promiscuous_enable(internals-
> >current_primary_port);
> > }
> > }
> >
> > @@ -1898,7 +1899,8 @@ bond_ethdev_promiscuous_disable(struct
> rte_eth_dev *dev)
> > case BONDING_MODE_TLB:
> > case BONDING_MODE_ALB:
> > default:
> > - rte_eth_promiscuous_disable(internals-
> >current_primary_port);
> > + if (internals->slave_count > 0)
> > + rte_eth_promiscuous_disable(internals-
> >current_primary_port);
> > }
> > }
> >
> >
> Hi Bernard,
>
> The reason of this crash is when there is no slave, the value of
> current_primary_port is 0, which is valid port_id, is this correct?
Yes.
> Does it make sense, instead of slave_count check, to make default
> current_primary_port value a non valid port_id, like -1, so
> is_valid_port() check catches it to prevents crash? For this and any other
> cases.
>
> Thanks,
> Ferruh
I will try initializing current_primary_port to -1 and see if this helps.
Thanks for reviewing.
Regards,
Bernard.
next prev parent reply other threads:[~2016-03-04 17:20 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-02-23 12:13 Bernard Iremonger
2016-03-04 17:13 ` Ferruh Yigit
2016-03-04 17:20 ` Iremonger, Bernard [this message]
2016-03-07 11:40 ` [dpdk-dev] [PATCH v2] " Bernard Iremonger
2016-03-07 12:14 ` Ferruh Yigit
2016-03-11 16:40 ` Bruce Richardson
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=8CEF83825BEC744B83065625E567D7C219FBFB9B@IRSMSX108.ger.corp.intel.com \
--to=bernard.iremonger@intel.com \
--cc=dev@dpdk.org \
--cc=ferruh.yigit@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).