From: "Iremonger, Bernard" <bernard.iremonger@intel.com>
To: "Lu, Wenzhuo" <wenzhuo.lu@intel.com>,
"dev@dpdk.org" <dev@dpdk.org>,
"Shah, Rahul R" <rahul.r.shah@intel.com>
Subject: Re: [dpdk-dev] [PATCH v2] net/ixgbe: support multiqueue mode VMDq DCB with SRIOV
Date: Mon, 17 Oct 2016 16:27:07 +0000 [thread overview]
Message-ID: <8CEF83825BEC744B83065625E567D7C21A0934D0@IRSMSX108.ger.corp.intel.com> (raw)
In-Reply-To: <6A0DE07E22DDAD4C9103DF62FEBC09093933BE4F@shsmsx102.ccr.corp.intel.com>
Hi Wenzhuo,
<snip>
> > Subject: [PATCH v2] net/ixgbe: support multiqueue mode VMDq DCB with
> > SRIOV
> >
> > modify ixgbe_dcb_tx_hw_config function.
> > modify ixgbe_dev_mq_rx_configure function.
> > modify ixgbe_configure_dcb function.
> Would you like to add more details about why we need to modify these
> functions and what has been done? Thanks.
I have updated the commit message for this patch with more information.
I have also added a testpmd patch and sent a v3 patchset.
> > Changes in v2:
> > Rebased to DPDK v16.11-rc1
> >
> > Signed-off-by: Rahul R Shah <rahul.r.shah@intel.com>
> > Signed-off-by: Bernard Iremonger <bernard.iremonger@intel.com>
> > ---
> > drivers/net/ixgbe/ixgbe_ethdev.c | 9 ++++-----
> > drivers/net/ixgbe/ixgbe_rxtx.c | 37 +++++++++++++++++++++------------
> ----
> > 2 files changed, 25 insertions(+), 21 deletions(-)
> >
> > diff --git a/drivers/net/ixgbe/ixgbe_ethdev.c
> > b/drivers/net/ixgbe/ixgbe_ethdev.c
> > index 4ca5747..114698d 100644
> > --- a/drivers/net/ixgbe/ixgbe_ethdev.c
> > +++ b/drivers/net/ixgbe/ixgbe_ethdev.c
> > @@ -1977,6 +1977,8 @@ ixgbe_check_mq_mode(struct rte_eth_dev
> *dev)
> > /* check multi-queue mode */
> > switch (dev_conf->rxmode.mq_mode) {
> > case ETH_MQ_RX_VMDQ_DCB:
> Should we store the mq mode here?
Yes, it probably should be stored here.
> > + PMD_INIT_LOG(INFO, "ETH_MQ_RX_VMDQ_DCB
> > mode supported in SRIOV");
> > + break;
> > case ETH_MQ_RX_VMDQ_DCB_RSS:
> > /* DCB/RSS VMDQ in SRIOV mode, not implement
> yet */
> > PMD_INIT_LOG(ERR, "SRIOV active,"
> > @@ -2012,11 +2014,8 @@ ixgbe_check_mq_mode(struct rte_eth_dev
> *dev)
> >
> > switch (dev_conf->txmode.mq_mode) {
> > case ETH_MQ_TX_VMDQ_DCB:
> > - /* DCB VMDQ in SRIOV mode, not implement yet */
> > - PMD_INIT_LOG(ERR, "SRIOV is active,"
> > - " unsupported VMDQ mq_mode
> > tx %d.",
> > - dev_conf->txmode.mq_mode);
> > - return -EINVAL;
> > + PMD_INIT_LOG(INFO, "ETH_MQ_TX_VMDQ_DCB
> mode
> > supported in SRIOV");
> > + break;
> > default: /* ETH_MQ_TX_VMDQ_ONLY or
> ETH_MQ_TX_NONE */
> > dev->data->dev_conf.txmode.mq_mode =
> ETH_MQ_TX_VMDQ_ONLY;
> > break;
> > diff --git a/drivers/net/ixgbe/ixgbe_rxtx.c
> > b/drivers/net/ixgbe/ixgbe_rxtx.c index
> > 2ce8234..bb13889 100644
> > --- a/drivers/net/ixgbe/ixgbe_rxtx.c
> > +++ b/drivers/net/ixgbe/ixgbe_rxtx.c
> > @@ -1,7 +1,7 @@
> > /*-
> > * BSD LICENSE
> > *
> > - * Copyright(c) 2010-2015 Intel Corporation. All rights reserved.
> > + * Copyright(c) 2010-2016 Intel Corporation. All rights reserved.
> > * Copyright 2014 6WIND S.A.
> > * All rights reserved.
> > *
> > @@ -3313,15 +3313,16 @@ ixgbe_vmdq_dcb_configure(struct
> rte_eth_dev
> > *dev)
> >
> > /**
> > * ixgbe_dcb_config_tx_hw_config - Configure general DCB TX
> > parameters
> > - * @hw: pointer to hardware structure
> > + * @dev: pointer to eth_dev structure
> > * @dcb_config: pointer to ixgbe_dcb_config structure
> > */
> > static void
> > -ixgbe_dcb_tx_hw_config(struct ixgbe_hw *hw,
> > +ixgbe_dcb_tx_hw_config(struct rte_eth_dev *dev,
> > struct ixgbe_dcb_config *dcb_config) {
> > uint32_t reg;
> > uint32_t q;
> > + struct ixgbe_hw *hw = IXGBE_DEV_PRIVATE_TO_HW(dev->data-
> > >dev_private);
> >
> > PMD_INIT_FUNC_TRACE();
> > if (hw->mac.type != ixgbe_mac_82598EB) { @@ -3339,11 +3340,17
> @@
> > ixgbe_dcb_tx_hw_config(struct ixgbe_hw *hw,
> > if (dcb_config->vt_mode)
> > reg |= IXGBE_MTQC_VT_ENA;
> > IXGBE_WRITE_REG(hw, IXGBE_MTQC, reg);
> > -
> > - /* Disable drop for all queues */
> > - for (q = 0; q < 128; q++)
> > - IXGBE_WRITE_REG(hw, IXGBE_QDE,
> > - (IXGBE_QDE_WRITE | (q <<
> > IXGBE_QDE_IDX_SHIFT)));
> > + if (RTE_ETH_DEV_SRIOV(dev).active == 0) {
> > + /* Disable drop for all queues in VMDQ mode*/
> > + for (q = 0; q < 128; q++)
> > + IXGBE_WRITE_REG(hw, IXGBE_QDE,
> > + (IXGBE_QDE_WRITE | (q <<
> > IXGBE_QDE_IDX_SHIFT) | IXGBE_QDE_ENABLE));
> > + } else {
> > + /* Enable drop for all queues in SRIOV mode */
> > + for (q = 0; q < 128; q++)
> > + IXGBE_WRITE_REG(hw, IXGBE_QDE,
> > + (IXGBE_QDE_WRITE | (q <<
> > IXGBE_QDE_IDX_SHIFT)));
> > + }
> I think it has nothing to do with mq mode. Do I miss something?
Behavior is different when SRIOV is enabled.
>
> >
> > /* Enable the Tx desc arbiter */
> > reg = IXGBE_READ_REG(hw, IXGBE_RTTDCS); @@ -3378,7
> > +3385,7 @@ ixgbe_vmdq_dcb_hw_tx_config(struct rte_eth_dev *dev,
> > vmdq_tx_conf->nb_queue_pools == ETH_16_POOLS
> ?
> > 0xFFFF : 0xFFFFFFFF);
> >
> > /*Configure general DCB TX parameters*/
> > - ixgbe_dcb_tx_hw_config(hw, dcb_config);
> > + ixgbe_dcb_tx_hw_config(dev, dcb_config);
> > }
> >
> > static void
> > @@ -3661,7 +3668,7 @@ ixgbe_dcb_hw_configure(struct rte_eth_dev
> *dev,
> > /*get DCB TX configuration parameters from rte_eth_conf*/
> > ixgbe_dcb_tx_config(dev, dcb_config);
> > /*Configure general DCB TX parameters*/
> > - ixgbe_dcb_tx_hw_config(hw, dcb_config);
> > + ixgbe_dcb_tx_hw_config(dev, dcb_config);
> > break;
> > default:
> > PMD_INIT_LOG(ERR, "Incorrect DCB TX mode
> configuration"); @@
> > -3810,9 +3817,6 @@ void ixgbe_configure_dcb(struct rte_eth_dev *dev)
> > (dev_conf->rxmode.mq_mode != ETH_MQ_RX_DCB_RSS))
> > return;
> >
> > - if (dev->data->nb_rx_queues != ETH_DCB_NUM_QUEUES)
> > - return;
> I remember it's a limitation of implementation. The reason is the resource
> allocation. Why could we remove it now?
ETH_DCB_NUM_QUEUES is 128, nb_rx_queues may not be 128.
>
> > -
> > /** Configure DCB hardware **/
> > ixgbe_dcb_hw_configure(dev, dcb_cfg); } @@ -4082,12 +4086,13
> @@
> > ixgbe_dev_mq_rx_configure(struct rte_eth_dev
> > *dev)
> > case ETH_MQ_RX_VMDQ_RSS:
> > ixgbe_config_vf_rss(dev);
> > break;
> > -
> > - /* FIXME if support DCB/RSS together with VMDq & SRIOV */
> > case ETH_MQ_RX_VMDQ_DCB:
> > + ixgbe_vmdq_dcb_configure(dev);
> > + break;
> > + /* FIXME if support DCB/RSS together with VMDq & SRIOV */
> > case ETH_MQ_RX_VMDQ_DCB_RSS:
> > PMD_INIT_LOG(ERR,
> > - "Could not support DCB with VMDq &
> SRIOV");
> > + "Could not support DCB/RSS with VMDq &
> > SRIOV");
> > return -1;
> > default:
> > ixgbe_config_vf_default(dev);
> > --
> > 2.10.1
Regards,
Bernard.
next prev parent reply other threads:[~2016-10-17 16:27 UTC|newest]
Thread overview: 35+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-08-26 9:08 [dpdk-dev] [PATCH] " Bernard Iremonger
2016-09-21 11:07 ` Remy Horton
2016-10-14 13:29 ` [dpdk-dev] [PATCH v2] " Bernard Iremonger
2016-10-17 6:12 ` Lu, Wenzhuo
2016-10-17 16:27 ` Iremonger, Bernard [this message]
2016-10-18 1:07 ` Lu, Wenzhuo
2016-10-18 8:58 ` Iremonger, Bernard
2016-10-19 0:39 ` Lu, Wenzhuo
2016-10-19 10:16 ` Iremonger, Bernard
2016-10-17 16:07 ` [dpdk-dev] [PATCH v3 0/2] net/ixgbe: " Bernard Iremonger
2016-10-17 17:01 ` [dpdk-dev] [PATCH v4 " Bernard Iremonger
2016-10-19 10:21 ` [dpdk-dev] [PATCH v5 " Bernard Iremonger
2016-10-25 0:31 ` Lu, Wenzhuo
2016-10-25 16:51 ` [dpdk-dev] [PATCH v6 " Bernard Iremonger
2016-10-25 16:51 ` [dpdk-dev] [PATCH v6 1/2] net/ixgbe: support multiqueue mode " Bernard Iremonger
2016-10-26 14:38 ` Wu, Jingjing
2016-10-26 15:29 ` Iremonger, Bernard
2016-10-26 16:09 ` Iremonger, Bernard
2016-10-26 16:33 ` Wu, Jingjing
2016-10-25 16:51 ` [dpdk-dev] [PATCH v6 2/2] app/test_pmd: fix DCB configuration Bernard Iremonger
2016-10-26 14:30 ` Wu, Jingjing
2016-10-26 15:28 ` [dpdk-dev] [PATCH v7] net/ixgbe: support multiqueue mode VMDq DCB with SRIOV Bernard Iremonger
2016-10-26 15:41 ` Bruce Richardson
2016-10-28 14:40 ` [dpdk-dev] [PATCH v7] app/testpmd: fix DCB configuration Bernard Iremonger
2016-11-01 10:36 ` [dpdk-dev] [PATCH v8] " Bernard Iremonger
2016-11-03 17:35 ` [dpdk-dev] [PATCH v9] " Bernard Iremonger
2016-11-04 5:40 ` Wu, Jingjing
2016-11-07 15:56 ` Thomas Monjalon
2016-10-19 10:21 ` [dpdk-dev] [PATCH v5 1/2] net/ixgbe: support multiqueue mode VMDq DCB with SRIOV Bernard Iremonger
2016-10-20 1:24 ` Lu, Wenzhuo
2016-10-19 10:21 ` [dpdk-dev] [PATCH v5 2/2] app/test_pmd: fix DCB configuration Bernard Iremonger
2016-10-17 17:01 ` [dpdk-dev] [PATCH v4 1/2] net/ixgbe: support multiqueue mode VMDq DCB with SRIOV Bernard Iremonger
2016-10-17 17:01 ` [dpdk-dev] [PATCH v4 2/2] app/test_pmd: fix DCB configuration Bernard Iremonger
2016-10-17 16:07 ` [dpdk-dev] [PATCH v3 1/2] net/ixgbe: support multiqueue mode VMDq DCB with SRIOV Bernard Iremonger
2016-10-17 16:07 ` [dpdk-dev] [PATCH v3 2/2] app/test_pmd: fix DCB configuration Bernard Iremonger
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=8CEF83825BEC744B83065625E567D7C21A0934D0@IRSMSX108.ger.corp.intel.com \
--to=bernard.iremonger@intel.com \
--cc=dev@dpdk.org \
--cc=rahul.r.shah@intel.com \
--cc=wenzhuo.lu@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).