From: Andrew Rybchenko <arybchenko@solarflare.com>
To: Remy Horton <remy.horton@intel.com>, <dev@dpdk.org>
Cc: Ivan Malov <ivan.malov@oktetlabs.ru>
Subject: Re: [dpdk-dev] [PATCH] net/sfc: add support for xstats retrieval by ID
Date: Wed, 12 Jul 2017 17:36:09 +0300 [thread overview]
Message-ID: <917d8ca3-055f-6f5c-bb6c-aa48671c5cca@solarflare.com> (raw)
In-Reply-To: <b185298f-327d-dc76-14f1-f624814b0e88@intel.com>
On 07/12/2017 05:18 PM, Remy Horton wrote:
>
> On 08/07/2017 16:45, Andrew Rybchenko wrote:
>> From: Ivan Malov <ivan.malov@oktetlabs.ru>
>>
>> Signed-off-by: Ivan Malov <ivan.malov@oktetlabs.ru>
>> Signed-off-by: Andrew Rybchenko <arybchenko@solarflare.com>
> [..]
>
> Reviewed-by: Remy Horton <remy.horton@intel.com>
>
>
>> + rc = sfc_port_update_mac_stats(sa);
>> + if (rc != 0) {
>> + SFC_ASSERT(rc > 0);
>> + ret = -rc;
>
> sfc_port_update_mac_stats() really ought to be returning -EINVAL or
> -ENOMEM rather than EINVAL/ENOMEM then doing a negation here.
It is the decision made on driver implementation to convert to negative
errno
at rte_eth_dev_ops return.
Inside the driver we use positive errno since base driver uses positive
errno and
a number of places where base driver API is called (and conversion would
be required)
is significantly bigger than a number of rte_eth_dev_ops.
> Other than that, code seems OK..
Many thanks for the review.
next prev parent reply other threads:[~2017-07-12 14:36 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-07-08 15:45 Andrew Rybchenko
2017-07-12 14:18 ` Remy Horton
2017-07-12 14:36 ` Andrew Rybchenko [this message]
2017-07-18 8:33 ` Ferruh Yigit
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=917d8ca3-055f-6f5c-bb6c-aa48671c5cca@solarflare.com \
--to=arybchenko@solarflare.com \
--cc=dev@dpdk.org \
--cc=ivan.malov@oktetlabs.ru \
--cc=remy.horton@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).