From: "Eads, Gage" <gage.eads@intel.com>
To: Thomas Monjalon <thomas@monjalon.net>
Cc: "dev@dpdk.org" <dev@dpdk.org>,
"jerin.jacob@caviumnetworks.com" <jerin.jacob@caviumnetworks.com>,
"Van Haaren, Harry" <harry.van.haaren@intel.com>,
"Richardson, Bruce" <bruce.richardson@intel.com>,
"Rao, Nikhil" <nikhil.rao@intel.com>,
"Carrillo, Erik G" <erik.g.carrillo@intel.com>,
"Gujjar, Abhinandan S" <abhinandan.gujjar@intel.com>
Subject: Re: [dpdk-dev] [PATCH v2 1/2] service: add mechanism for quiescing a service
Date: Thu, 21 Jun 2018 14:09:05 +0000 [thread overview]
Message-ID: <9184057F7FC11744A2107296B6B8EB1E446CE626@FMSMSX108.amr.corp.intel.com> (raw)
In-Reply-To: <3685961.S7279KZuIK@xps>
> -----Original Message-----
> From: Thomas Monjalon [mailto:thomas@monjalon.net]
> Sent: Monday, June 18, 2018 5:14 PM
> To: Eads, Gage <gage.eads@intel.com>
> Cc: dev@dpdk.org; jerin.jacob@caviumnetworks.com; Van Haaren, Harry
> <harry.van.haaren@intel.com>; Richardson, Bruce
> <bruce.richardson@intel.com>; Rao, Nikhil <nikhil.rao@intel.com>; Carrillo, Erik
> G <erik.g.carrillo@intel.com>; Gujjar, Abhinandan S
> <abhinandan.gujjar@intel.com>
> Subject: Re: [dpdk-dev] [PATCH v2 1/2] service: add mechanism for quiescing a
> service
>
> 14/06/2018 15:51, Gage Eads:
> > --- a/lib/librte_eal/common/include/rte_service.h
> > +++ b/lib/librte_eal/common/include/rte_service.h
> > @@ -162,6 +162,22 @@ int32_t rte_service_runstate_set(uint32_t id,
> > uint32_t runstate); int32_t rte_service_runstate_get(uint32_t id);
> >
> > /**
> > + * This function returns whether the service may be currently
> > + executing on
> > + * at least one lcore, or definitely is not. This function can be
> > + used to
> > + * determine if, after setting the service runstate to stopped, the
> > + service
> > + * is still executing an a service lcore.
>
> Typo: "an a"
Will fix.
>
> > --- a/lib/librte_eal/rte_eal_version.map
> > +++ b/lib/librte_eal/rte_eal_version.map
> > +DPDK_18.08 {
> > + global:
> > +
> > + rte_service_may_be_active;
> > +
> > +} DPDK_18.05;
>
> Why it is not experimental?
>
It should be -- my mistake.
Thanks,
Gage
next prev parent reply other threads:[~2018-06-21 14:09 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-05-31 13:55 [dpdk-dev] [PATCH 0/2] Improve service stop support Gage Eads
2018-05-31 13:55 ` [dpdk-dev] [PATCH 1/2] service: add mechanism for quiescing a service Gage Eads
2018-06-14 10:12 ` Van Haaren, Harry
2018-05-31 13:55 ` [dpdk-dev] [PATCH 2/2] event/sw: support device stop flush callback Gage Eads
2018-06-14 10:20 ` Van Haaren, Harry
2018-06-17 12:33 ` Jerin Jacob
2018-06-14 13:51 ` [dpdk-dev] [PATCH v2 0/2] Improve service stop support Gage Eads
2018-06-14 13:51 ` [dpdk-dev] [PATCH v2 1/2] service: add mechanism for quiescing a service Gage Eads
2018-06-18 22:13 ` Thomas Monjalon
2018-06-21 14:09 ` Eads, Gage [this message]
2018-06-14 13:51 ` [dpdk-dev] [PATCH v2 2/2] event/sw: support device stop flush callback Gage Eads
2018-06-21 14:23 ` [dpdk-dev] [PATCH v3 0/2] Improve service stop support Gage Eads
2018-06-21 14:23 ` [dpdk-dev] [PATCH v3 1/2] service: add mechanism for quiescing a service Gage Eads
2018-06-21 14:23 ` [dpdk-dev] [PATCH v3 2/2] event/sw: support device stop flush callback Gage Eads
2018-06-24 11:31 ` [dpdk-dev] [PATCH v3 0/2] Improve service stop support Jerin Jacob
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=9184057F7FC11744A2107296B6B8EB1E446CE626@FMSMSX108.amr.corp.intel.com \
--to=gage.eads@intel.com \
--cc=abhinandan.gujjar@intel.com \
--cc=bruce.richardson@intel.com \
--cc=dev@dpdk.org \
--cc=erik.g.carrillo@intel.com \
--cc=harry.van.haaren@intel.com \
--cc=jerin.jacob@caviumnetworks.com \
--cc=nikhil.rao@intel.com \
--cc=thomas@monjalon.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).