From: "Xing, Beilei" <beilei.xing@intel.com>
To: "Awal, Mohammad Abdul" <mohammad.abdul.awal@intel.com>,
"Horton, Remy" <remy.horton@intel.com>,
"dev@dpdk.org" <dev@dpdk.org>
Cc: "Mcnamara, John" <john.mcnamara@intel.com>,
"Lu, Wenzhuo" <wenzhuo.lu@intel.com>,
"Wu, Jingjing" <jingjing.wu@intel.com>,
"Doherty, Declan" <declan.doherty@intel.com>
Subject: Re: [dpdk-dev] [PATCH v4 3/5] drivers/net/i40e: add Port Representor functionality
Date: Wed, 10 Jan 2018 12:37:51 +0000 [thread overview]
Message-ID: <94479800C636CB44BD422CB454846E013208A24F@SHSMSX101.ccr.corp.intel.com> (raw)
In-Reply-To: <aa90ebc0-3cf6-fec5-4755-1f89e56083c4@intel.com>
> -----Original Message-----
> From: Awal, Mohammad Abdul
> Sent: Wednesday, January 10, 2018 6:11 PM
> To: Xing, Beilei <beilei.xing@intel.com>; Horton, Remy
> <remy.horton@intel.com>; dev@dpdk.org
> Cc: Mcnamara, John <john.mcnamara@intel.com>; Lu, Wenzhuo
> <wenzhuo.lu@intel.com>; Wu, Jingjing <jingjing.wu@intel.com>; Doherty,
> Declan <declan.doherty@intel.com>
> Subject: Re: [dpdk-dev] [PATCH v4 3/5] drivers/net/i40e: add Port
> Representor functionality
>
>
>
> On 10/01/2018 07:56, Xing, Beilei wrote:
> >
> >> -----Original Message-----
> >> From: dev [mailto:dev-bounces@dpdk.org] On Behalf Of Remy Horton
> >> + dev_info->rx_offload_capa =
> >> + DEV_RX_OFFLOAD_VLAN_STRIP |
> >> + DEV_RX_OFFLOAD_QINQ_STRIP |
> >> + DEV_RX_OFFLOAD_IPV4_CKSUM |
> >> + DEV_RX_OFFLOAD_UDP_CKSUM |
> >> + DEV_RX_OFFLOAD_TCP_CKSUM;
> >> + dev_info->tx_offload_capa =
> >> + DEV_TX_OFFLOAD_VLAN_INSERT |
> >> + DEV_TX_OFFLOAD_QINQ_INSERT |
> >> + DEV_TX_OFFLOAD_IPV4_CKSUM |
> >> + DEV_TX_OFFLOAD_UDP_CKSUM |
> >> + DEV_TX_OFFLOAD_TCP_CKSUM |
> >> + DEV_TX_OFFLOAD_SCTP_CKSUM;
> > Tunnel TSO and outer IP checksum are also supported.
> Correct. Fixed.
> >
> > <...>
> >
> >> +static const struct ether_addr null_mac_addr;
> >> +
> >> +int
> >> +rte_pmd_i40e_remove_vf_mac_addr(uint8_t port, uint16_t vf_id,
> >> + struct ether_addr *mac_addr)
> >> +{
> >> + struct rte_eth_dev *dev;
> >> + struct i40e_pf_vf *vf;
> >> + struct i40e_vsi *vsi;
> >> + struct i40e_pf *pf;
> >> +
> >> + if (i40e_validate_mac_addr((u8 *)mac_addr) != I40E_SUCCESS)
> >> + return -EINVAL;
> >> +
> >> + RTE_ETH_VALID_PORTID_OR_ERR_RET(port, -ENODEV);
> >> +
> >> + dev = &rte_eth_devices[port];
> >> +
> >> + if (!is_i40e_supported(dev))
> >> + return -ENOTSUP;
> >> +
> >> + pf = I40E_DEV_PRIVATE_TO_PF(dev->data->dev_private);
> >> +
> >> + if (vf_id >= pf->vf_num || !pf->vfs)
> >> + return -EINVAL;
> >> +
> >> + vf = &pf->vfs[vf_id];
> >> + vsi = vf->vsi;
> >> + if (!vsi) {
> >> + PMD_DRV_LOG(ERR, "Invalid VSI.");
> >> + return -EINVAL;
> >> + }
> >> +
> >> + if (!is_same_ether_addr(mac_addr, &vf->mac_addr)) {
> >> + PMD_DRV_LOG(ERR, "Mac address does not match.");
> >> + return -EINVAL;
> >> + }
> > Not very understand why only vf->mac_addr can be moved?
> It it checks if the mac address we want to delete, similar to the function
> rte_pmd_i40e_set_vf_mac_addr where we set the mac address of a VF.
But in this way, seems we can't delete the mac address added by rte_pmd_i40e_add_vf_mac_addr.
set_vf_mac_addr should be used for setting default mac address, right?
> > I think any mac address in vsi->mac_list can be removed.
> Yes, it is removed from the vsi->mac_list in the next line if the mac address is
> matched in the previous checking.
>
> >> +
> >> + /* reset the mac with null mac */
> >> + ether_addr_copy(&null_mac_addr, &vf->mac_addr);
> Here we reset the mac address of a VF with null address, reverting the
> operation of function rte_pmd_i40e_set_vf_mac_addr where we set the
> mac address of a VF.
> >> +
> >> + /* Remove the mac */
> >> + i40e_vsi_delete_mac(vsi, mac_addr);
> >> +
> >> + return 0;
> >> +}
> >> +
next prev parent reply other threads:[~2018-01-10 12:37 UTC|newest]
Thread overview: 75+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-11-17 14:42 [dpdk-dev] [PATCH v2 1/6] ethdev: added switch_domain and representor port flag Mohammad Abdul Awal
2017-11-17 14:42 ` [dpdk-dev] [PATCH v2 2/6] lib/representor: port representor library to manage broker infrastructure and representor PMDs Mohammad Abdul Awal
2017-11-17 23:03 ` Ferruh Yigit
2017-12-08 14:57 ` Mohammad Abdul Awal
2017-11-17 14:42 ` [dpdk-dev] [PATCH v2 3/6] eal: added --enable-representor command line argument in EAL to load representor broker infrastructure Mohammad Abdul Awal
2017-11-17 14:42 ` [dpdk-dev] [PATCH v2 4/6] net/representor: Implement port representor PMD Mohammad Abdul Awal
2017-11-20 7:46 ` Ferruh Yigit
2017-12-08 15:02 ` Remy Horton
2017-12-08 16:56 ` Mohammad Abdul Awal
2017-12-11 10:08 ` Remy Horton
2017-12-11 15:11 ` Mohammad Abdul Awal
2017-12-11 15:29 ` Remy Horton
2017-11-17 14:42 ` [dpdk-dev] [PATCH v2 5/6] net/i40e: Enable port representor PMD and broker for fortville PMD driver Mohammad Abdul Awal
2017-11-20 7:48 ` Ferruh Yigit
2017-11-17 14:42 ` [dpdk-dev] [PATCH v2 6/6] net/ixgbe: Enable port representor PMD and broker for ixgbe " Mohammad Abdul Awal
2017-11-20 19:57 ` [dpdk-dev] [PATCH v2 1/6] ethdev: added switch_domain and representor port flag Ferruh Yigit
2017-12-08 15:33 ` Mohammad Abdul Awal
2017-12-11 13:45 ` Alex Rosenbaum
2017-12-11 18:00 ` Mohammad Abdul Awal
2017-12-22 14:41 ` [dpdk-dev] [DPDK 0/5] lib: add Port Representors Remy Horton
2017-12-22 14:41 ` [dpdk-dev] [DPDK 1/5] lib: add Port Representor library Remy Horton
2017-12-22 14:41 ` [dpdk-dev] [DPDK 2/5] eal: add Port Representor command-line option Remy Horton
2017-12-22 14:41 ` [dpdk-dev] [DPDK 3/5] drivers/net/i40e: add Port Representor functionality Remy Horton
2017-12-22 14:41 ` [dpdk-dev] [DPDK 4/5] drivers/net/ixgbe: " Remy Horton
2017-12-22 14:41 ` [dpdk-dev] [DPDK 5/5] app/test-pmd: add Port Representor commands Remy Horton
2017-12-22 15:09 ` [dpdk-dev] [DPDK 0/5] lib: add Port Representors Remy Horton
2017-12-22 16:37 ` Neil Horman
2018-01-03 12:14 ` Mohammad Abdul Awal
2017-12-22 14:52 ` [dpdk-dev] [PATCH v3 " Remy Horton
2017-12-22 14:52 ` [dpdk-dev] [PATCH v3 1/5] lib: add Port Representor library Remy Horton
2017-12-22 14:52 ` [dpdk-dev] [PATCH v3 2/5] eal: add Port Representor command-line option Remy Horton
2017-12-22 14:52 ` [dpdk-dev] [PATCH v3 3/5] drivers/net/i40e: add Port Representor functionality Remy Horton
2017-12-22 14:52 ` [dpdk-dev] [PATCH v3 4/5] drivers/net/ixgbe: " Remy Horton
2017-12-22 14:52 ` [dpdk-dev] [PATCH v3 5/5] app/test-pmd: add Port Representor commands Remy Horton
2017-12-26 13:54 ` [dpdk-dev] [PATCH v3 0/5] lib: add Port Representors Neil Horman
2018-01-03 12:12 ` Mohammad Abdul Awal
2018-01-08 14:37 ` [dpdk-dev] [PATCH v4 " Remy Horton
2018-01-08 14:37 ` [dpdk-dev] [PATCH v4 1/5] lib: add Port Representor library Remy Horton
2018-01-09 22:06 ` Ferruh Yigit
2018-01-10 11:40 ` Remy Horton
2018-01-08 14:37 ` [dpdk-dev] [PATCH v4 2/5] eal: add Port Representor command-line option Remy Horton
2018-01-09 22:07 ` Ferruh Yigit
2018-01-08 14:37 ` [dpdk-dev] [PATCH v4 3/5] drivers/net/i40e: add Port Representor functionality Remy Horton
2018-01-09 22:09 ` Ferruh Yigit
2018-01-10 7:56 ` Xing, Beilei
2018-01-10 10:11 ` Mohammad Abdul Awal
2018-01-10 12:37 ` Xing, Beilei [this message]
2018-01-10 14:04 ` Mohammad Abdul Awal
2018-01-08 14:37 ` [dpdk-dev] [PATCH v4 4/5] drivers/net/ixgbe: " Remy Horton
2018-01-08 14:37 ` [dpdk-dev] [PATCH v4 5/5] app/test-pmd: add Port Representor commands Remy Horton
2018-01-09 22:10 ` Ferruh Yigit
2018-01-10 7:22 ` Remy Horton
2018-01-09 22:01 ` [dpdk-dev] [PATCH v4 0/5] lib: add Port Representors Ferruh Yigit
2018-01-10 14:17 ` Mohammad Abdul Awal
2018-01-09 23:22 ` Thomas Monjalon
2018-01-10 13:46 ` Doherty, Declan
2018-01-10 19:26 ` Thomas Monjalon
2018-01-15 12:12 ` Doherty, Declan
2018-01-15 16:09 ` Thomas Monjalon
2018-01-10 15:54 ` [dpdk-dev] [PATCH v5 " Remy Horton
2018-01-10 15:54 ` [dpdk-dev] [PATCH v5 1/5] lib: add Port Representor library Remy Horton
2018-01-30 9:23 ` Andrew Rybchenko
2018-01-10 15:54 ` [dpdk-dev] [PATCH v5 2/5] eal: add Port Representor command-line option Remy Horton
2018-01-10 15:54 ` [dpdk-dev] [PATCH v5 3/5] drivers/net/i40e: add Port Representor functionality Remy Horton
2018-01-10 15:54 ` [dpdk-dev] [PATCH v5 4/5] drivers/net/ixgbe: " Remy Horton
2018-01-10 15:54 ` [dpdk-dev] [PATCH v5 5/5] app/test-pmd: add Port Representor commands Remy Horton
2018-01-10 17:49 ` [dpdk-dev] [PATCH v5 0/5] lib: add Port Representors Remy Horton
2018-01-10 17:49 ` [dpdk-dev] [PATCH v5 1/5] lib: add Port Representor library Remy Horton
2018-01-10 17:49 ` [dpdk-dev] [PATCH v5 2/5] eal: add Port Representor command-line option Remy Horton
2018-01-10 17:49 ` [dpdk-dev] [PATCH v5 3/5] drivers/net/i40e: add Port Representor functionality Remy Horton
2018-01-10 17:49 ` [dpdk-dev] [PATCH v5 4/5] drivers/net/ixgbe: " Remy Horton
2018-01-10 17:49 ` [dpdk-dev] [PATCH v5 5/5] app/test-pmd: add Port Representor commands Remy Horton
2018-01-11 3:18 ` [dpdk-dev] [PATCH v4 0/5] lib: add Port Representors Yuanhan Liu
2018-01-11 8:37 ` Alex Rosenbaum
2018-01-11 9:38 ` Remy Horton
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=94479800C636CB44BD422CB454846E013208A24F@SHSMSX101.ccr.corp.intel.com \
--to=beilei.xing@intel.com \
--cc=declan.doherty@intel.com \
--cc=dev@dpdk.org \
--cc=jingjing.wu@intel.com \
--cc=john.mcnamara@intel.com \
--cc=mohammad.abdul.awal@intel.com \
--cc=remy.horton@intel.com \
--cc=wenzhuo.lu@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).