From: "Xing, Beilei" <beilei.xing@intel.com>
To: Tonghao Zhang <xiangxia.m.yue@gmail.com>, "dev@dpdk.org" <dev@dpdk.org>
Subject: Re: [dpdk-dev] [PATCH 2/5] net/ixgbevf: set the inter-interrupt interval for EITR.
Date: Thu, 11 Jan 2018 07:26:55 +0000 [thread overview]
Message-ID: <94479800C636CB44BD422CB454846E013208ACB9@SHSMSX101.ccr.corp.intel.com> (raw)
In-Reply-To: <1515161439-4792-2-git-send-email-xiangxia.m.yue@gmail.com>
> -----Original Message-----
> From: dev [mailto:dev-bounces@dpdk.org] On Behalf Of Tonghao Zhang
> Sent: Friday, January 5, 2018 10:11 PM
> To: dev@dpdk.org
> Cc: Tonghao Zhang <xiangxia.m.yue@gmail.com>
> Subject: [dpdk-dev] [PATCH 2/5] net/ixgbevf: set the inter-interrupt interval
> for EITR.
>
> Set EITR interval as default. This patch can improve the performance when
> we enable the rx-intrrupt to process the packets because we hope rx-
> intrrupt reduce CPU.
>
> The 200us value of EITR makes the performance better with the low CPU.
>
> Signed-off-by: Tonghao Zhang <xiangxia.m.yue@gmail.com>
> ---
> drivers/net/ixgbe/ixgbe_ethdev.c | 3 +++
> 1 file changed, 3 insertions(+)
>
> diff --git a/drivers/net/ixgbe/ixgbe_ethdev.c
> b/drivers/net/ixgbe/ixgbe_ethdev.c
> index e67389f..b20cab9 100644
> --- a/drivers/net/ixgbe/ixgbe_ethdev.c
> +++ b/drivers/net/ixgbe/ixgbe_ethdev.c
> @@ -5780,6 +5780,9 @@ static void ixgbevf_set_vfta_all(struct rte_eth_dev
> *dev, bool on)
> if (vector_idx < base + intr_handle->nb_efd - 1)
> vector_idx++;
> }
> +
> + IXGBE_WRITE_REG(hw, IXGBE_VTEITR(IXGBE_MISC_VEC_ID),
> + IXGBE_EITR_INTERVAL_US(200) |
Is it possible to configure interval via DPDK configuration? Just like CONFIG_RTE_LIBRTE_I40E_ITR_INTERVAL for i40e.
Maybe the value is good for you but not suitable for other users.
Besides, seems the patches in the patchset have no dependency, needn't put them into one patchset, and then the Acked patch can be applied quickly.
> IXGBE_EITR_CNT_WDIS);
> }
>
> /**
> --
> 1.8.3.1
next prev parent reply other threads:[~2018-01-11 7:27 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-01-05 14:10 [dpdk-dev] [PATCH 1/5] net/ixgbevf: unregister irq handler when other interrupts not allowed Tonghao Zhang
2018-01-05 14:10 ` [dpdk-dev] [PATCH 2/5] net/ixgbevf: set the inter-interrupt interval for EITR Tonghao Zhang
2018-01-11 7:26 ` Xing, Beilei [this message]
2018-01-11 14:46 ` Tonghao Zhang
2018-01-05 14:10 ` [dpdk-dev] [PATCH 3/5] net/ixgbevf: save IXGBE_VTEIMS to intr->mask for performance Tonghao Zhang
2018-01-11 7:09 ` Xing, Beilei
2018-01-05 14:10 ` [dpdk-dev] [PATCH 4/5] net/ixgbevf: add check for rte_intr_enable Tonghao Zhang
2018-01-11 7:06 ` Xing, Beilei
2018-01-11 15:35 ` Tonghao Zhang
2018-01-12 12:10 ` Dai, Wei
2018-01-14 6:51 ` Tonghao Zhang
2018-01-05 14:10 ` [dpdk-dev] [PATCH 5/5] vhost: add reconnect thread name for client mode Tonghao Zhang
2018-01-09 13:12 ` Yuanhan Liu
2018-01-09 13:40 ` Yuanhan Liu
2018-01-09 15:28 ` Tonghao Zhang
2018-01-11 6:55 ` [dpdk-dev] [PATCH 1/5] net/ixgbevf: unregister irq handler when other interrupts not allowed Xing, Beilei
2018-01-11 14:24 ` Tonghao Zhang
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=94479800C636CB44BD422CB454846E013208ACB9@SHSMSX101.ccr.corp.intel.com \
--to=beilei.xing@intel.com \
--cc=dev@dpdk.org \
--cc=xiangxia.m.yue@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).