From: Tonghao Zhang <xiangxia.m.yue@gmail.com>
To: Yuanhan Liu <yliu@fridaylinux.org>
Cc: dev@dpdk.org
Subject: Re: [dpdk-dev] [PATCH 5/5] vhost: add reconnect thread name for client mode.
Date: Tue, 9 Jan 2018 23:28:01 +0800 [thread overview]
Message-ID: <CAMDZJNXWqXMRHPZF9dQyHXeDho-2dpV8MGxwsW8y8S6q+6kgEQ@mail.gmail.com> (raw)
In-Reply-To: <20180109134037.GO29540@yliu-mob>
Thanks for your review.
On Tue, Jan 9, 2018 at 9:40 PM, Yuanhan Liu <yliu@fridaylinux.org> wrote:
> On Tue, Jan 09, 2018 at 09:12:43PM +0800, Yuanhan Liu wrote:
>> On Fri, Jan 05, 2018 at 06:10:39AM -0800, Tonghao Zhang wrote:
>> > This patch adds the name for vhost-user reconnect thread.
>> > It can help us to know whether the thread is running.
>> >
>> > Signed-off-by: Tonghao Zhang <xiangxia.m.yue@gmail.com>
>> > ---
>> > lib/librte_vhost/socket.c | 8 ++++++++
>> > 1 file changed, 8 insertions(+)
>> >
>> > diff --git a/lib/librte_vhost/socket.c b/lib/librte_vhost/socket.c
>> > index d44a0f1..c2e34e0 100644
>> > --- a/lib/librte_vhost/socket.c
>> > +++ b/lib/librte_vhost/socket.c
>> > @@ -433,6 +433,7 @@ struct vhost_user_reconnect_list {
>> > vhost_user_reconnect_init(void)
>> > {
>> > int ret;
>> > + char thread_name[RTE_MAX_THREAD_NAME_LEN];
>> >
>> > ret = pthread_mutex_init(&reconn_list.mutex, NULL);
>> > if (ret < 0) {
>> > @@ -449,6 +450,13 @@ struct vhost_user_reconnect_list {
>> > RTE_LOG(ERR, VHOST_CONFIG,
>> > "failed to destroy reconnect mutex");
>> > }
>> > + } else {
>> > + snprintf(thread_name, RTE_MAX_THREAD_NAME_LEN,
>> > + "vhost-reconn");
>> > +
>> > + if (rte_thread_setname(reconn_tid, thread_name))
>> > + RTE_LOG(DEBUG, VHOST_CONFIG,
>> > + "Failed to set thread name for vhost-user reconnect");
>>
>> Applied to dpdk-next-virtio, with the intendation fixed.
>
> Note that I have just applied this patch only. The rest of this patchset
> belongs to the ixgbe PMD driver, which need another maintainer for review.
>
> That also means, it's better if you could send them sperately next time
> when they are not related. More specifically, in this case, one patch
> for vhost-user, another patchset for all the rest ixgbe changes.
>
> --yliu
next prev parent reply other threads:[~2018-01-09 15:28 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-01-05 14:10 [dpdk-dev] [PATCH 1/5] net/ixgbevf: unregister irq handler when other interrupts not allowed Tonghao Zhang
2018-01-05 14:10 ` [dpdk-dev] [PATCH 2/5] net/ixgbevf: set the inter-interrupt interval for EITR Tonghao Zhang
2018-01-11 7:26 ` Xing, Beilei
2018-01-11 14:46 ` Tonghao Zhang
2018-01-05 14:10 ` [dpdk-dev] [PATCH 3/5] net/ixgbevf: save IXGBE_VTEIMS to intr->mask for performance Tonghao Zhang
2018-01-11 7:09 ` Xing, Beilei
2018-01-05 14:10 ` [dpdk-dev] [PATCH 4/5] net/ixgbevf: add check for rte_intr_enable Tonghao Zhang
2018-01-11 7:06 ` Xing, Beilei
2018-01-11 15:35 ` Tonghao Zhang
2018-01-12 12:10 ` Dai, Wei
2018-01-14 6:51 ` Tonghao Zhang
2018-01-05 14:10 ` [dpdk-dev] [PATCH 5/5] vhost: add reconnect thread name for client mode Tonghao Zhang
2018-01-09 13:12 ` Yuanhan Liu
2018-01-09 13:40 ` Yuanhan Liu
2018-01-09 15:28 ` Tonghao Zhang [this message]
2018-01-11 6:55 ` [dpdk-dev] [PATCH 1/5] net/ixgbevf: unregister irq handler when other interrupts not allowed Xing, Beilei
2018-01-11 14:24 ` Tonghao Zhang
-- strict thread matches above, loose matches on Subject: below --
2018-01-05 13:57 Tonghao Zhang
2018-01-05 13:57 ` [dpdk-dev] [PATCH 5/5] vhost: add reconnect thread name for client mode Tonghao Zhang
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CAMDZJNXWqXMRHPZF9dQyHXeDho-2dpV8MGxwsW8y8S6q+6kgEQ@mail.gmail.com \
--to=xiangxia.m.yue@gmail.com \
--cc=dev@dpdk.org \
--cc=yliu@fridaylinux.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).