From: "Wu, Jingjing" <jingjing.wu@intel.com>
To: "Ananyev, Konstantin" <konstantin.ananyev@intel.com>,
"Dai, Wei" <wei.dai@intel.com>,
"Xing, Beilei" <beilei.xing@intel.com>
Cc: "dev@dpdk.org" <dev@dpdk.org>, "stable@dpdk.org" <stable@dpdk.org>
Subject: Re: [dpdk-stable] [dpdk-dev] [PATCH v5] net/i40e: fix mirror rule reset when port is stopped
Date: Sat, 23 Sep 2017 02:26:37 +0000 [thread overview]
Message-ID: <9BB6961774997848B5B42BEC655768F810E7B199@SHSMSX103.ccr.corp.intel.com> (raw)
In-Reply-To: <2601191342CEEE43887BDE71AB9772584F24D80D@irsmsx105.ger.corp.intel.com>
> -----Original Message-----
> From: Ananyev, Konstantin
> Sent: Thursday, September 21, 2017 6:46 AM
> To: Dai, Wei <wei.dai@intel.com>; Wu, Jingjing <jingjing.wu@intel.com>; Xing, Beilei
> <beilei.xing@intel.com>
> Cc: dev@dpdk.org; stable@dpdk.org
> Subject: RE: [dpdk-dev] [PATCH v5] net/i40e: fix mirror rule reset when port is stopped
>
> Hi Wei,
>
> >
> > Hi, Konstantin
> >
> > Without this patch, when a port is stopped, all mirror SW resource are cleared but HW
> settings are still there.
> > And once the port is started again, creating mirror rule may fail due to remain HW
> settings.
> >
> > There is a testpmd use case which can show why this patch is needed.
> > 1. bind PF to igb_uio
> > #/root/dpdk-devbind.py -b igb_uio 0000:08:00.0
> > 2. create 2 VFs
> > #echo 2 > /sys/bus/pci/devices/0000\:08\:00.0/max_vfs
> > 3. launch testpmd with PF, and set port mirror configuration
> > #./x86_64-native-linuxapp-gcc/app/testpmd -c 3 -n 4 -- -i
> > Testpmd > set port 0 mirror-rule 0 pool-mirror-up 0x1 dst-pool 1 on
> > Testpmd > quit
> > 4. relaunch testpmd with PF, and set port mirror as the same configuration
> > #./x86_64-native-linuxapp-gcc/app/testpmd -c 3 -n 4 -- -i
> > Testpmd > set port 0 mirror-rule 0 pool-mirror-up 0x1 dst-pool 1 on
> > I40e_mirror_rule_set( ): failed to add mirror rule: ret = -53, aq_err = 13.
> > Mirror rule add error: (Function not implemented)
> >
> > When testpmd is quitted, rte_eth_dev_stop( ) and then rte_eth_dev_close( ) are called.
> > In these function, i40e_dev_stop( ) and i40e_dev_close( ) is called.
> > And i40e_dev_stop is also called by i40e_dev_close( ).
> >
> > Without this patch, the error in second running of testpmd always happen.
> > This patch can address this error.
>
> Thanks for explanation.
> Though it seems that the patch while fixing the issue might introduce some
> inconsistences:
> 1. right now for i40e: dev_stop(port); dev_start(port) would keep existing HW mirror rule
> working.
> With your patch is not any more.
> 2. What about ixgbe? Do we also need to change its behavior?
> As I can see right now ixgbe doesn't reset any mirror rules at dev_stop().
> Would it be reset automatically, or do we need to update ixgbe PMD too?
>
> About #1 - if we'll decide that this is a desired behavior that dev_stop() voids
> all mirror rules, then at least we probably need to update the documentation.
> As alternative - at dev_stop() we can reset only actual HW rule, but keep SW
> configuration intact,
> and restore them at dev_start().
> I personally think second option is a bit better - as it preserves existing behavior,
> and probably more convenient for the user.
Yes, you reminded me the mirror is to VF. The mirror rule should be kept or at least
be restored when device start again..
Because the dev_stop should only stop the pf interface, but not affect VF. It looks
like we don't delete the VEB we dev_stop.
The reset behavior may need to be done in dev_close, but not in dev_stop.
>
> About the patch itself, why just not:
> while ((p_mirror = TAILQ_FIRST(&pf->mirror_list)))
> i40e_mirror_rule_reset(dev, p_mirror->index);
>
Wei's v1 patch is doing like that. But I commented it to change it. Because
i40e_mirror_rule_reset is doing a search in the list which is not necessary.
Thanks
Jingjing
next prev parent reply other threads:[~2017-09-23 2:26 UTC|newest]
Thread overview: 25+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-09-06 14:52 [dpdk-stable] [PATCH] " Wei Dai
2017-09-07 7:34 ` Dai, Wei
2017-09-07 7:35 ` Dai, Wei
2017-09-07 7:37 ` Tu, LijuanX A
2017-09-07 7:50 ` Wu, Jingjing
2017-09-07 9:22 ` Dai, Wei
2017-09-11 2:10 ` [dpdk-stable] [PATCH v2] " Wei Dai
2017-09-11 2:11 ` Wei Dai
2017-09-11 2:45 ` [dpdk-stable] [dpdk-dev] " Xing, Beilei
2017-09-13 7:32 ` Wu, Jingjing
2017-09-19 2:21 ` Wu, Jingjing
2017-09-20 1:44 ` Dai, Wei
2017-09-11 2:30 ` [dpdk-stable] " Wei Dai
2017-09-20 1:59 ` [dpdk-stable] [PATCH v3] " Wei Dai
2017-09-20 2:12 ` [dpdk-stable] [PATCH v4] " Wei Dai
2017-09-20 4:16 ` [dpdk-stable] [PATCH v5] " Wei Dai
2017-09-20 9:23 ` [dpdk-stable] [dpdk-dev] " Ananyev, Konstantin
2017-09-20 14:26 ` Dai, Wei
2017-09-20 22:46 ` Ananyev, Konstantin
2017-09-23 2:26 ` Wu, Jingjing [this message]
2017-09-23 10:37 ` Ananyev, Konstantin
2017-09-23 16:34 ` Dai, Wei
2017-09-25 6:36 ` [dpdk-stable] [PATCH v6] net/i40e: fix mirror rule reset when port is closed Wei Dai
2017-09-26 13:49 ` Wu, Jingjing
2017-09-28 15:49 ` Ferruh Yigit
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=9BB6961774997848B5B42BEC655768F810E7B199@SHSMSX103.ccr.corp.intel.com \
--to=jingjing.wu@intel.com \
--cc=beilei.xing@intel.com \
--cc=dev@dpdk.org \
--cc=konstantin.ananyev@intel.com \
--cc=stable@dpdk.org \
--cc=wei.dai@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).