From: "Wu, Jingjing" <jingjing.wu@intel.com>
To: "Zhang, Helin" <helin.zhang@intel.com>,
"Richardson, Bruce" <bruce.richardson@intel.com>
Cc: "dev@dpdk.org" <dev@dpdk.org>
Subject: Re: [dpdk-dev] [PATCH v2 1/3] i40e: enable DCB in VMDQ VSIs
Date: Thu, 25 Feb 2016 07:04:57 +0000 [thread overview]
Message-ID: <9BB6961774997848B5B42BEC655768F8DC950D@SHSMSX104.ccr.corp.intel.com> (raw)
In-Reply-To: <F35DEAC7BCE34641BA9FAC6BCA4A12E70A9BD5DE@SHSMSX104.ccr.corp.intel.com>
> > + /* 4 bits per TC, 4th bit is reserved */
> > + veb->bw_info.bw_ets_max[i] =
> > + (uint8_t)((bw_max >> (i * I40E_4_BIT_WIDTH)) &
> > + I40E_3_BIT_MASK);
> Use RTE_LEN2MASK() to replace I40E_3_BIT_MASK.
OK.
>
> > + PMD_DRV_LOG(DEBUG, "\tVEB TC%u:share credits %u", i,
> > + veb->bw_info.bw_ets_share_credits[i]);
> > + PMD_DRV_LOG(DEBUG, "\tVEB TC%u:credits %u", i,
> > + veb->bw_info.bw_ets_credits[i]);
> > + PMD_DRV_LOG(DEBUG, "\tVEB TC%u: max credits: %u", i,
> > + veb->bw_info.bw_ets_max[i]);
> > + }
> > +
> > + veb->enabled_tc = tc_map;
> > +
> > + return ret;
> > +}
> > +
> > +
> > +/*
> > * i40e_vsi_config_tc - Configure VSI tc setting for given TC map
> > * @vsi: VSI to be configured
> > * @tc_map: enabled TC bitmap
> > @@ -8152,7 +8252,7 @@ i40e_vsi_update_queue_mapping(struct i40e_vsi
> > *vsi,
> > * Returns 0 on success, negative value on failure
> > */
> > static enum i40e_status_code
> > -i40e_vsi_config_tc(struct i40e_vsi *vsi, u8 tc_map)
> > +i40e_vsi_config_tc(struct i40e_vsi *vsi, uint8_t tc_map)
> > {
> > struct i40e_aqc_configure_vsi_tc_bw_data bw_data;
> > struct i40e_vsi_context ctxt;
> > @@ -8294,15 +8394,27 @@ i40e_dcb_hw_configure(struct i40e_pf *pf,
> > i40e_aq_get_dcb_config(hw, I40E_AQ_LLDP_MIB_LOCAL, 0,
> > &hw->local_dcbx_config);
> >
> > + /* if Veb is created, need to update TC of it at first */
> > + if (main_vsi->veb) {
> > + ret = i40e_config_switch_comp_tc(main_vsi->veb, tc_map);
> > + if (ret)
> > + PMD_INIT_LOG(WARNING,
> > + "Failed configuring TC for VEB seid=%d\n",
> > + main_vsi->veb->seid);
> > + }
> How about if VEB hasn't been created?
If VEB is not created, no need to update tc on switch comp.
Thanks
Jingjing
>
> > 2.4.0
next prev parent reply other threads:[~2016-02-25 7:05 UTC|newest]
Thread overview: 23+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-01-11 2:50 [dpdk-dev] [RFC PATCH 0/3] extend vmdq_dcb sample for X710 supporting Jingjing Wu
2016-01-11 2:50 ` [dpdk-dev] [RFC PATCH 1/3] i40e: enable DCB in VMDQ vsis Jingjing Wu
2016-01-11 2:50 ` [dpdk-dev] [RFC PATCH 2/3] ixgbe: add more multi queue mode checking Jingjing Wu
2016-01-11 2:50 ` [dpdk-dev] [RFC PATCH 3/3] examples/vmdq_dcb: extend sample for X710 supporting Jingjing Wu
2016-01-20 8:57 ` [dpdk-dev] [PATCH 0/3] extend vmdq_dcb " Jingjing Wu
2016-01-20 8:57 ` [dpdk-dev] [PATCH 1/3] i40e: enable DCB in VMDQ vsis Jingjing Wu
2016-02-12 12:16 ` Bruce Richardson
2016-01-20 8:57 ` [dpdk-dev] [PATCH 2/3] ixgbe: add more multi queue mode checking Jingjing Wu
2016-01-20 8:57 ` [dpdk-dev] [PATCH 3/3] examples/vmdq_dcb: extend sample for X710 supporting Jingjing Wu
2016-02-17 6:58 ` [dpdk-dev] [PATCH v2 0/3] extend vmdq_dcb " Jingjing Wu
2016-02-17 6:58 ` [dpdk-dev] [PATCH v2 1/3] i40e: enable DCB in VMDQ VSIs Jingjing Wu
2016-02-24 6:58 ` Zhang, Helin
2016-02-25 7:04 ` Wu, Jingjing [this message]
2016-02-17 6:58 ` [dpdk-dev] [PATCH v2 2/3] ixgbe: disallow unsupported RX mode Jingjing Wu
2016-02-17 6:58 ` [dpdk-dev] [PATCH v2 3/3] examples/vmdq_dcb: extend sample for X710 supporting Jingjing Wu
2016-02-25 7:33 ` [dpdk-dev] [PATCH v3 0/3] extend vmdq_dcb " Jingjing Wu
2016-02-25 7:33 ` [dpdk-dev] [PATCH v3 1/3] i40e: enable DCB in VMDQ VSIs Jingjing Wu
2016-02-26 8:06 ` Zhang, Helin
2016-02-25 7:33 ` [dpdk-dev] [PATCH v3 2/3] ixgbe: disallow unsupported RX mode Jingjing Wu
2016-02-26 8:06 ` Zhang, Helin
2016-02-25 7:33 ` [dpdk-dev] [PATCH v3 3/3] examples/vmdq_dcb: extend sample for X710 supporting Jingjing Wu
2016-02-26 8:06 ` Zhang, Helin
2016-03-08 17:25 ` [dpdk-dev] [PATCH v3 0/3] extend vmdq_dcb " Bruce Richardson
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=9BB6961774997848B5B42BEC655768F8DC950D@SHSMSX104.ccr.corp.intel.com \
--to=jingjing.wu@intel.com \
--cc=bruce.richardson@intel.com \
--cc=dev@dpdk.org \
--cc=helin.zhang@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).