From: "Chen, Zhaoyan" <zhaoyan.chen@intel.com>
To: "dev@dpdk.org" <dev@dpdk.org>
Subject: Re: [dpdk-dev] [PATCH v8 1/2] examples/ipsec-secgw: add configuration file support
Date: Thu, 29 Sep 2016 01:19:43 +0000 [thread overview]
Message-ID: <9DEEADBC57E43F4DA73B571777FECECA3A5A5951@shsmsx102.ccr.corp.intel.com> (raw)
In-Reply-To: <1474459519-134894-2-git-send-email-roy.fan.zhang@intel.com>
Tested-by: Zhaoyan Chen <zhaoyan.chen@intel.com>
- Apply patch: Pass
- Compile: Pass
- OS: 3.17.4-301.fc21.x86_64
- GCC: 4.9.2
Test Case - Pass
- Launch ipsec-gateway with "-f" parameter and ep0.cfg, check the default configuration file work.
- Modified Algorithm in config file and launch ipsec-gateway and check the new algorithm effected
- Modified the key and check the key effected.
- Modified the iv and check the iv effected
- Modified the router rule and check the the rule effected
But for negative test,
If input incorrect key and iv, the application will PANIC in parse_cfg_file()
For instance, change the line 70 in ep0.cfg, add 1 more <space> at the end of line, like "a0:a0:a0: \"
The application will Abort (core dump). Expected it should report error and exit safe.
> -----Original Message-----
> From: dev [mailto:dev-bounces@dpdk.org] On Behalf Of Fan Zhang
> Sent: Wednesday, September 21, 2016 8:05 PM
> To: dev@dpdk.org
> Cc: Gonzalez Monroy, Sergio <sergio.gonzalez.monroy@intel.com>
> Subject: [dpdk-dev] [PATCH v8 1/2] examples/ipsec-secgw: add
> configuration file support
>
> This patch adds the configuration file support to ipsec_secgw
> sample application. Instead of hard-coded rules, the users can
> specify their own SP, SA, and routing rules in the configuration
> file. An command line option "-f" is added to pass the
> configuration file location to the application.
>
> Configuration item formats:
>
> SP rule format:
> sp <ip_ver> <dir> esp <action> <priority> <src_ip> <dst_ip> \
> <proto> <sport> <dport>
>
> SA rule format:
> sa <dir> <spi> <cipher_algo> <cipher_key> <auth_algo> <auth_key> \
> <mode> <src_ip> <dst_ip>
>
> Routing rule format:
> rt <ip_ver> <src_ip> <dst_ip> <port>
>
> Signed-off-by: Fan Zhang <roy.fan.zhang@intel.com>
> ---
> doc/guides/rel_notes/release_16_11.rst | 4 +
> doc/guides/sample_app_ug/ipsec_secgw.rst | 845 +++++++++++++----------
> --------
> examples/ipsec-secgw/Makefile | 1 +
> examples/ipsec-secgw/ipsec-secgw.c | 58 ++-
> examples/ipsec-secgw/ipsec.h | 14 +-
> examples/ipsec-secgw/parser.c | 599 ++++++++++++++++++++++
> examples/ipsec-secgw/parser.h | 116 +++++
> examples/ipsec-secgw/rt.c | 255 ++++------
> examples/ipsec-secgw/sa.c | 747 +++++++++++++++++----------
> examples/ipsec-secgw/sp4.c | 538 ++++++++++++--------
> examples/ipsec-secgw/sp6.c | 539 +++++++++++++-------
> 11 files changed, 2397 insertions(+), 1319 deletions(-)
> create mode 100644 examples/ipsec-secgw/parser.c
> create mode 100644 examples/ipsec-secgw/parser.h
>
> diff --git a/doc/guides/rel_notes/release_16_11.rst
> b/doc/guides/rel_notes/release_16_11.rst
> index 451872e..da61798 100644
> --- a/doc/guides/rel_notes/release_16_11.rst
> +++ b/doc/guides/rel_notes/release_16_11.rst
> @@ -82,6 +82,10 @@ Libraries
> Examples
> ~~~~~~~~
>
> +* **ipsec-secgw: add configuration file support**
> +
> + ipsec-secgw sample application now supports configuration file to specify
> + SP, SA, and routing rules.
>
> Other
[...]
> --
> 2.5.5
next prev parent reply other threads:[~2016-09-29 1:19 UTC|newest]
Thread overview: 32+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-07-07 11:31 [dpdk-dev] [PATCH 0/2] examples/ipsec_secgw: " Fan Zhang
2016-07-07 11:31 ` [dpdk-dev] [PATCH 1/2] " Fan Zhang
2016-07-07 11:31 ` [dpdk-dev] [PATCH 2/2] examples/ipsec-secgw: add sample configuration files Fan Zhang
2016-07-11 14:43 ` [dpdk-dev] [PATCH v2 0/2] examples/ipsec_secgw: add configuration file support Fan Zhang
2016-07-11 14:43 ` [dpdk-dev] [PATCH v2 1/2] examples/ipsec-secgw: " Fan Zhang
2016-07-11 15:19 ` Thomas Monjalon
2016-07-11 14:43 ` [dpdk-dev] [PATCH v2 2/2] examples/ipsec-secgw: add sample configuration files Fan Zhang
2016-07-12 9:44 ` [dpdk-dev] [PATCH v3 0/2] examples/ipsec_secgw: add configuration file support Fan Zhang
2016-07-12 9:44 ` [dpdk-dev] [PATCH v3 1/2] examples/ipsec-secgw: " Fan Zhang
2016-07-19 8:19 ` Sergio Gonzalez Monroy
2016-07-12 9:44 ` [dpdk-dev] [PATCH v3 2/2] examples/ipsec-secgw: add sample configuration files Fan Zhang
2016-07-21 10:51 ` [dpdk-dev] [PATCH v4 0/2] examples/ipsec_secgw: add configuration file support Fan Zhang
2016-07-21 10:51 ` [dpdk-dev] [PATCH v4 1/2] examples/ipsec-secgw: " Fan Zhang
2016-07-21 10:51 ` [dpdk-dev] [PATCH v4 2/2] examples/ipsec-secgw: add sample configuration files Fan Zhang
2016-08-22 10:49 ` [dpdk-dev] [PATCH 0/2] examples/ipsec_secgw: add configuration file support Fan Zhang
2016-08-22 10:49 ` [dpdk-dev] [PATCH 1/2] examples/ipsec-secgw: " Fan Zhang
2016-08-22 10:49 ` [dpdk-dev] [PATCH 2/2] examples/ipsec-secgw: add sample configuration files Fan Zhang
2016-08-23 14:46 ` [dpdk-dev] [PATCH v6 0/2] [PATCH 0/2] examples/ipsec_secgw: add configuration file support Fan Zhang
2016-08-23 14:46 ` [dpdk-dev] [PATCH v6 1/2] examples/ipsec-secgw: " Fan Zhang
2016-09-07 18:13 ` De Lara Guarch, Pablo
2016-08-23 14:46 ` [dpdk-dev] [PATCH v6 2/2] examples/ipsec-secgw: add sample configuration files Fan Zhang
2016-09-20 11:13 ` [dpdk-dev] [PATCH v7 0/2] examples/ipsec_secgw: add configuration file support Fan Zhang
2016-09-20 11:13 ` [dpdk-dev] [PATCH v7 1/2] examples/ipsec-secgw: " Fan Zhang
2016-09-20 11:13 ` [dpdk-dev] [PATCH v7 2/2] examples/ipsec-secgw: add sample configuration files Fan Zhang
2016-09-21 12:05 ` [dpdk-dev] [PATCH v8 0/2] examples/ipsec_secgw: add configuration file support Fan Zhang
2016-09-21 12:05 ` [dpdk-dev] [PATCH v8 1/2] examples/ipsec-secgw: " Fan Zhang
2016-09-23 7:52 ` Sergio Gonzalez Monroy
2016-09-23 22:51 ` De Lara Guarch, Pablo
2016-09-29 1:19 ` Chen, Zhaoyan [this message]
2016-09-21 12:05 ` [dpdk-dev] [PATCH v8 2/2] examples/ipsec-secgw: add sample configuration files Fan Zhang
2016-09-23 7:53 ` Sergio Gonzalez Monroy
2016-09-23 22:51 ` De Lara Guarch, Pablo
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=9DEEADBC57E43F4DA73B571777FECECA3A5A5951@shsmsx102.ccr.corp.intel.com \
--to=zhaoyan.chen@intel.com \
--cc=dev@dpdk.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).