From: "Chilikin, Andrey" <andrey.chilikin@intel.com>
To: "Xing, Beilei" <beilei.xing@intel.com>, "dev@dpdk.org" <dev@dpdk.org>
Cc: "Wu, Jingjing" <jingjing.wu@intel.com>
Subject: Re: [dpdk-dev] [PATCH v3 1/2] net/i40e: extended list of operations for ddp processing
Date: Wed, 28 Jun 2017 07:40:18 +0000 [thread overview]
Message-ID: <AAC06825A3B29643AF5372F5E0DDF0538DBA24D7@IRSMSX106.ger.corp.intel.com> (raw)
In-Reply-To: <94479800C636CB44BD422CB454846E0131FD8F09@SHSMSX101.ccr.corp.intel.com>
Hi Beilei,
> -----Original Message-----
> From: Xing, Beilei
> Sent: Wednesday, June 28, 2017 7:58 AM
> To: Chilikin, Andrey <andrey.chilikin@intel.com>; dev@dpdk.org
> Cc: Wu, Jingjing <jingjing.wu@intel.com>
> Subject: RE: [PATCH v3 1/2] net/i40e: extended list of operations for ddp
> processing
>
> Hi Andrey,
>
<snip>
> > + }
> > + else {
>
> Should be } else { here according to the coding style.
Will fix in v4
> > --- a/drivers/net/i40e/rte_pmd_i40e.h
> > +++ b/drivers/net/i40e/rte_pmd_i40e.h
> > @@ -71,6 +71,8 @@ struct rte_pmd_i40e_mb_event_param { enum
> > rte_pmd_i40e_package_op {
> > RTE_PMD_I40E_PKG_OP_UNDEFINED = 0,
> > RTE_PMD_I40E_PKG_OP_WR_ADD, /**< load package and add to
> > info list */
> > + RTE_PMD_I40E_PKG_OP_WR_DEL, /**< load package and delete
> > from info list */
> > + RTE_PMD_I40E_PKG_OP_WR_ONLY, /**< load package without
> > modifying info
> > +list */
>
> The only difference between RTE_PMD_I40E_PKG_OP_WR_ADD and
> RTE_PMD_I40E_PKG_OP_WR_ONLY is if need to change info list, right? Is there
> any difference between the profiles added? Do we need another CLI in testpmd
> to indicate how/when we need to use RTE_PMD_I40E_PKG_OP_WR_ONLY?
>
I believe that existing testpmd CLI is enough for i40e as this 'if' statement
if (track_id && (op != RTE_PMD_I40E_PKG_OP_WR_ONLY)) {
will not register profiles with track_id == 0
> Beilei
Regards,
Andrey
next prev parent reply other threads:[~2017-06-28 7:40 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-05-27 16:04 [dpdk-dev] [PATCH] " Andrey Chilikin
2017-06-27 8:18 ` [dpdk-dev] [PATCH v2 0/2] " Andrey Chilikin
2017-06-27 8:18 ` [dpdk-dev] [PATCH v2 1/2] " Andrey Chilikin
2017-06-27 8:18 ` [dpdk-dev] [PATCH v2 2/2] app/testpmd: enable ddp remove profile feature Andrey Chilikin
2017-06-27 9:55 ` Ferruh Yigit
2017-06-27 13:35 ` [dpdk-dev] [PATCH v3 0/2] net/i40e: extended list of operations for ddp processing Andrey Chilikin
2017-06-27 13:35 ` [dpdk-dev] [PATCH v3 1/2] " Andrey Chilikin
2017-06-28 6:57 ` Xing, Beilei
2017-06-28 7:40 ` Chilikin, Andrey [this message]
2017-06-28 8:03 ` Xing, Beilei
2017-06-27 13:35 ` [dpdk-dev] [PATCH v3 2/2] app/testpmd: enable ddp remove profile feature Andrey Chilikin
2017-06-28 6:40 ` Xing, Beilei
2017-06-28 8:15 ` [dpdk-dev] [PATCH v4 0/2] net/i40e: extended list of operations for ddp processing Andrey Chilikin
2017-06-28 9:47 ` Ferruh Yigit
2017-06-28 8:15 ` [dpdk-dev] [PATCH v4 1/2] " Andrey Chilikin
2017-06-28 8:25 ` Xing, Beilei
2017-06-28 8:15 ` [dpdk-dev] [PATCH v4 2/2] app/testpmd: enable ddp remove profile feature Andrey Chilikin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=AAC06825A3B29643AF5372F5E0DDF0538DBA24D7@IRSMSX106.ger.corp.intel.com \
--to=andrey.chilikin@intel.com \
--cc=beilei.xing@intel.com \
--cc=dev@dpdk.org \
--cc=jingjing.wu@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).