From: Shachar Beiser <shacharbe@mellanox.com>
To: Yongseok Koh <yskoh@mellanox.com>
Cc: "dev@dpdk.org" <dev@dpdk.org>,
"Adrien Mazarguil" <adrien.mazarguil@6wind.com>,
"Nélio Laranjeiro" <nelio.laranjeiro@6wind.com>
Subject: Re: [dpdk-dev] [PATCH v3 1/2] net/mlx5: replace network to host macros
Date: Mon, 18 Sep 2017 09:47:03 +0000 [thread overview]
Message-ID: <AM2PR05MB0689D1CF51822FE2BAC142EEC0630@AM2PR05MB0689.eurprd05.prod.outlook.com> (raw)
In-Reply-To: <2E023DB0-6B86-4C66-8600-8374A0D95D48@mellanox.com>
> -----Original Message-----
> From: Yongseok Koh
> Sent: Friday, September 15, 2017 11:50 PM
> To: Shachar Beiser <shacharbe@mellanox.com>
> Cc: dev@dpdk.org; Adrien Mazarguil <adrien.mazarguil@6wind.com>; Nélio
> Laranjeiro <nelio.laranjeiro@6wind.com>
> Subject: Re: [dpdk-dev] [PATCH v3 1/2] net/mlx5: replace network to host
> macros
>
>
> > On Sep 14, 2017, at 6:43 AM, Shachar Beiser <shacharbe@mellanox.com>
> wrote:
> >
> > Signed-off-by: Shachar Beiser <shacharbe@mellanox.com>
> > ---
> [...]
> > @@ -550,7 +553,8 @@
> > max_wqe -= n;
> > if (tso) {
> > uint32_t inl =
> > - htonl(copy_b |
> MLX5_INLINE_SEG);
> > + rte_cpu_to_be_32(copy_b |
> > + MLX5_INLINE_SEG);
> Wrong indentation.
>
Since there is a constrain of 80 characters a line , this indentation was accepted by
Nélio .
> [...]
> > @@ -605,8 +605,8 @@ int mlx5_tx_queue_setup(struct rte_eth_dev *,
> uint16_t, uint16_t, unsigned int,
> > uint64_t *dst = (uint64_t *)((uintptr_t)txq->bf_reg);
> > volatile uint64_t *src = ((volatile uint64_t *)wqe);
> >
> > - rte_io_wmb();
> > - *txq->qp_db = htonl(txq->wqe_ci);
> > + rte_wmb();
> Look like a mistake when rebasing. This should not be touched by this patch.
>
> > + *txq->qp_db = rte_cpu_to_be_32(txq->wqe_ci);
> > /* Ensure ordering between DB record and BF copy. */
> > rte_wmb();
> > *dst = *src;
>
Yes , this is true. There is a fix for this issue in the coming patch:
[dpdk-dev,v4,1/2] net/mlx5: replace network to host macros
http://dpdk.org/dev/patchwork/patch/28804/
> --
> Thanks,
> Yongseok
>
next prev parent reply other threads:[~2017-09-18 9:47 UTC|newest]
Thread overview: 25+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-09-04 11:48 [dpdk-dev] [PATCH 1/3] " Shachar Beiser
2017-09-04 11:48 ` [dpdk-dev] [PATCH 2/3] net/mlx5: fix TSO MLNX OFED 3.3 verification Shachar Beiser
2017-09-04 15:15 ` Nélio Laranjeiro
2017-09-04 11:48 ` [dpdk-dev] [PATCH 3/3] net/mlx5: fix interrupt enable return value Shachar Beiser
2017-09-04 15:24 ` Nélio Laranjeiro
2017-09-05 9:04 ` Shachar Beiser
2017-09-04 15:14 ` [dpdk-dev] [PATCH 1/3] net/mlx5: replace network to host macros Nélio Laranjeiro
2017-09-05 9:05 ` Shachar Beiser
2017-09-05 13:04 ` [dpdk-dev] [PATCH v2 " Shachar Beiser
2017-09-05 13:41 ` Nélio Laranjeiro
2017-09-05 13:04 ` [dpdk-dev] [PATCH v2 2/3] net/mlx5: fix TSO MLNX OFED 3.3 verification Shachar Beiser
2017-09-05 13:41 ` Nélio Laranjeiro
2017-09-14 13:43 ` [dpdk-dev] [PATCH v3 1/2] net/mlx5: replace network to host macros Shachar Beiser
2017-09-15 20:50 ` Yongseok Koh
2017-09-18 9:47 ` Shachar Beiser [this message]
2017-09-14 13:43 ` [dpdk-dev] [PATCH v3 2/2] net/mlx5: fix TSO MLNX OFED 3.3 verification Shachar Beiser
2017-09-17 10:42 ` [dpdk-dev] [PATCH v4 1/2] net/mlx5: replace network to host macros Shachar Beiser
2017-09-18 17:59 ` Yongseok Koh
2017-09-19 6:30 ` Nélio Laranjeiro
2017-09-17 10:42 ` [dpdk-dev] [PATCH v4 2/2] net/mlx5: fix TSO MLNX OFED 3.3 verification Shachar Beiser
2017-09-18 17:52 ` Yongseok Koh
2017-09-22 18:02 ` [dpdk-dev] [dpdk-stable] " Ferruh Yigit
2017-09-05 13:04 ` [dpdk-dev] [PATCH v2 3/3] net/mlx5: fix interrupt enable return value Shachar Beiser
2017-09-05 13:27 ` Adrien Mazarguil
2017-09-06 10:54 ` Shachar Beiser
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=AM2PR05MB0689D1CF51822FE2BAC142EEC0630@AM2PR05MB0689.eurprd05.prod.outlook.com \
--to=shacharbe@mellanox.com \
--cc=adrien.mazarguil@6wind.com \
--cc=dev@dpdk.org \
--cc=nelio.laranjeiro@6wind.com \
--cc=yskoh@mellanox.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).