From: Shahaf Shuler <shahafs@mellanox.com>
To: "Van Haaren, Harry" <harry.van.haaren@intel.com>,
"thomas.monjalon@6wind.com" <thomas.monjalon@6wind.com>,
"thomas@monjalon.net" <thomas@monjalon.net>
Cc: "Adrien Mazarguil" <adrien.mazarguil@6wind.com>,
"Nélio Laranjeiro" <nelio.laranjeiro@6wind.com>,
"dev@dpdk.org" <dev@dpdk.org>,
"Gaetan Rivet" <gaetan.rivet@6wind.com>
Subject: Re: [dpdk-dev] [PATCH] ethdev: fix compilation issue with strict flags
Date: Wed, 19 Apr 2017 05:22:26 +0000 [thread overview]
Message-ID: <AM4PR05MB15055855A30FAB922080993FC3180@AM4PR05MB1505.eurprd05.prod.outlook.com> (raw)
In-Reply-To: <E923DB57A917B54B9182A2E928D00FA612A2CC62@IRSMSX102.ger.corp.intel.com>
Hi,
Any more comments on this commit? Could it be merged? Compilation is still failing..
Thursday, April 13, 2017 12:36 PM, Van Haaren, Harry:
> > From: dev [mailto:dev-bounces@dpdk.org] On Behalf Of Shahaf Shuler
> > Sent: Thursday, April 13, 2017 6:29 AM
> > To: thomas.monjalon@6wind.com
> > Cc: adrien.mazarguil@6wind.com; nelio.laranjeiro@6wind.com;
> > dev@dpdk.org
> > Subject: [dpdk-dev] [PATCH] ethdev: fix compilation issue with strict
> > flags
> >
> > Compilation error seen while compiling mlx5 in debug mode under RHEL
> > 7.3:
> >
> > rte_ethdev.h:1670:7: error: type of bit-field 'state' is a GCC extension
> > [-Werror=pedantic]
> >
> > Address it by removing the unnecessary bit-field width limitation.
> >
> > Fixes: d52268a8b24b ("ethdev: expose device states")
> >
> > Signed-off-by: Shahaf Shuler <shahafs@mellanox.com>
Acked-by: Harry van Haaren <harry.van.haaren@intel.com>
Acked-by: Gaetan Rivet <gaetan.rivet@6wind.com>
> > ---
> > lib/librte_ether/rte_ethdev.h | 2 +-
> > 1 file changed, 1 insertion(+), 1 deletion(-)
> >
> > diff --git a/lib/librte_ether/rte_ethdev.h
> > b/lib/librte_ether/rte_ethdev.h index d07253874..2d1bc12aa 100644
> > --- a/lib/librte_ether/rte_ethdev.h
> > +++ b/lib/librte_ether/rte_ethdev.h
> > @@ -1667,7 +1667,7 @@ struct rte_eth_dev {
> > * received packets before passing them to the driver for
> transmission.
> > */
> > struct rte_eth_rxtx_callback
> *pre_tx_burst_cbs[RTE_MAX_QUEUES_PER_PORT];
> > - enum rte_eth_dev_state state:8; /**< Flag indicating the port state
> */
> > + enum rte_eth_dev_state state; /**< Flag indicating the port state */
> > } __rte_cache_aligned;
> >
> > struct rte_eth_dev_sriov {
next prev parent reply other threads:[~2017-04-19 5:22 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-04-13 5:29 Shahaf Shuler
2017-04-13 8:29 ` Gaëtan Rivet
2017-04-13 9:36 ` Van Haaren, Harry
2017-04-19 5:22 ` Shahaf Shuler [this message]
2017-04-19 13:35 ` Thomas Monjalon
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=AM4PR05MB15055855A30FAB922080993FC3180@AM4PR05MB1505.eurprd05.prod.outlook.com \
--to=shahafs@mellanox.com \
--cc=adrien.mazarguil@6wind.com \
--cc=dev@dpdk.org \
--cc=gaetan.rivet@6wind.com \
--cc=harry.van.haaren@intel.com \
--cc=nelio.laranjeiro@6wind.com \
--cc=thomas.monjalon@6wind.com \
--cc=thomas@monjalon.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).