From: Ori Kam <orika@mellanox.com>
To: "Nélio Laranjeiro" <nelio.laranjeiro@6wind.com>
Cc: Adrien Mazarguil <adrien.mazarguil@6wind.com>,
Yongseok Koh <yskoh@mellanox.com>, "dev@dpdk.org" <dev@dpdk.org>
Subject: Re: [dpdk-dev] [PATCH v2] doc: update mlx5 flow count limitations
Date: Mon, 16 Oct 2017 13:25:47 +0000 [thread overview]
Message-ID: <AM4PR05MB320257C58470B670D29E5456DB4F0@AM4PR05MB3202.eurprd05.prod.outlook.com> (raw)
In-Reply-To: <20171016123625.pjm7kvrfdfqxobiz@laranjeiro-vm>
> -----Original Message-----
> From: Nélio Laranjeiro [mailto:nelio.laranjeiro@6wind.com]
> Sent: Monday, October 16, 2017 3:36 PM
> To: Ori Kam <orika@mellanox.com>
> Cc: Adrien Mazarguil <adrien.mazarguil@6wind.com>; Yongseok Koh
> <yskoh@mellanox.com>; dev@dpdk.org
> Subject: Re: [PATCH v2] doc: update mlx5 flow count limitations
>
> On Mon, Oct 16, 2017 at 11:31:32AM +0000, Ori Kam wrote:
> > Please see my comments,
> >
> > > -----Original Message-----
> > > From: Nélio Laranjeiro [mailto:nelio.laranjeiro@6wind.com]
> > > Sent: Monday, October 16, 2017 2:18 PM
> > > To: Ori Kam <orika@mellanox.com>
> > > Cc: Adrien Mazarguil <adrien.mazarguil@6wind.com>; Yongseok Koh
> > > <yskoh@mellanox.com>; dev@dpdk.org
> > > Subject: Re: [PATCH v2] doc: update mlx5 flow count limitations
> > >
> > > On Mon, Oct 16, 2017 at 11:32:39AM +0300, Ori Kam wrote:
> > > > Signed-off-by: Ori Kam <orika@mellanox.com>
> > > > Acked-by: Shahaf Shuler <shahafs@mellanox.com>
> > > > ---
> > > > doc/guides/nics/mlx5.rst | 5 ++++-
> > > > 1 files changed, 4 insertions(+), 1 deletions(-)
> > > >
> > > > diff --git a/doc/guides/nics/mlx5.rst b/doc/guides/nics/mlx5.rst
> > > > index
> > > > d24941a..7da5c87 100644
> > > > --- a/doc/guides/nics/mlx5.rst
> > > > +++ b/doc/guides/nics/mlx5.rst
> > > > @@ -104,7 +104,8 @@ Limitations
> > > > -----------
> > > >
> > > > - Inner RSS for VXLAN frames is not supported yet.
> > > > -- Port statistics through software counters only.
> > > > +- Port statistics through software counters only. Flow statistics
> > > > +are
> > > > + supported by hardware counters.
> > > > - Hardware checksum RX offloads for VXLAN inner header are not
> > > supported yet.
> > > > - Forked secondary process not supported.
> > > > - Flow pattern without any specific vlan will match for vlan packets as
> well:
> > > > @@ -127,6 +128,8 @@ Limitations
> > > > - A multi segment packet must have less than 6 segments in case
> > > > the Tx
> > > burst function
> > > > is set to multi-packet send or Enhanced multi-packet send.
> > > > Otherwise it
> > > must have
> > > > less than 50 segments.
> > > > +- Count action for RTE flow is only supported in OFED 4.2.
> > > > +- Two identical rules with count action are not supported.
> > >
> > > This last line does not bring anything, having two identical rules
> > > already create a collision which is not defined by the flow API.
> > > In PMD situation is is even worse, as it will match both rules and
> > > thus it will duplicate a packet.
> > >
> > > There is no need to add a limit on an undefined behavior by the API itself.
> > >
> >
> > The thing is that when you try adding duplicate rules without the
> > count it works without any error while if you add the count action then for
> the second rule you get an error.
> > This line address this inconsistency.
>
> According to Flow API documentation [1]
>
> "If a packet is matched by several rules of a given group for a given priority
> level, the outcome is undefined. It can take any path, may be duplicated or
> even cause unrecoverable errors."
>
> This is already documented and application makers should avoid it.
> There is no need to duplicate this information.
>
Will fix in version 3.
> > > Thanks,
> > >
> > > PS: when you send a new revision, please use the --thread and
> > > --in-reply-to to link it with the previous one.
> > >
> >
> >
> > My bad,
> >
> > > --
> > > Nélio Laranjeiro
> > > 6WIND
> >
> > Regards,
> > Ori Kam
>
> Thanks,
>
> [1]
> https://emea01.safelinks.protection.outlook.com/?url=http%3A%2F%2Fdpd
> k.org%2Fdoc%2Fguides%2Fprog_guide%2Frte_flow.html&data=02%7C01%7
> Corika%40mellanox.com%7Ccc884d2a17c641d6388b08d51492886c%7Ca65297
> 1c7d2e4d9ba6a4d149256f461b%7C0%7C0%7C636437541948539609&sdata=fh
> 67Sys0ZaabU6hmpv5uo%2BgfXlRe2eDjTn65MUVO7IU%3D&reserved=0
>
> --
> Nélio Laranjeiro
> 6WIND
Regards,
Ori Kam
next prev parent reply other threads:[~2017-10-16 13:25 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-10-16 8:32 Ori Kam
2017-10-16 11:17 ` Nélio Laranjeiro
2017-10-16 11:31 ` Ori Kam
2017-10-16 12:36 ` Nélio Laranjeiro
2017-10-16 13:25 ` Ori Kam [this message]
2017-10-16 14:11 ` [dpdk-dev] [PATCH v3] " Ori Kam
2017-10-16 15:19 ` Nélio Laranjeiro
2017-10-19 6:09 ` [dpdk-dev] [PATCH v4] " Ori Kam
2017-10-19 6:19 ` Ferruh Yigit
2017-10-19 6:56 ` Olga Shern
2017-10-19 7:05 ` Nélio Laranjeiro
2017-10-23 18:45 ` Ferruh Yigit
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=AM4PR05MB320257C58470B670D29E5456DB4F0@AM4PR05MB3202.eurprd05.prod.outlook.com \
--to=orika@mellanox.com \
--cc=adrien.mazarguil@6wind.com \
--cc=dev@dpdk.org \
--cc=nelio.laranjeiro@6wind.com \
--cc=yskoh@mellanox.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).