From: Slava Ovsiienko <viacheslavo@mellanox.com>
To: Kevin Traynor <ktraynor@redhat.com>,
Shahaf Shuler <shahafs@mellanox.com>
Cc: "dev@dpdk.org" <dev@dpdk.org>,
"stable@dpdk.org" <stable@dpdk.org>,
Thomas Monjalon <thomas@monjalon.net>,
Yongseok Koh <yskoh@mellanox.com>,
Luca Boccassi <bluca@debian.org>
Subject: Re: [dpdk-stable] [dpdk-dev] [PATCH 0/5] net/mlx5: add inner tunnel items support on E-Switch
Date: Thu, 31 Jan 2019 16:13:19 +0000 [thread overview]
Message-ID: <AM4PR05MB3265DB1ADD303E4340266C9AD2910@AM4PR05MB3265.eurprd05.prod.outlook.com> (raw)
In-Reply-To: <590129bf-3012-25bf-bac5-fedf1c705a25@redhat.com>
Hi, Kevin
It is rather refactoring, not new feature, tunnel inner items support is partially present in 18.11.
Yes, this patchset is too big to be simple fix, and updates not so much to be new feature.
It is very early patch (after 18.11 release), just mailed later, rebase on the top was done
automatically and quite simple, because it touches merely E-Switch subsystem (merge should
not be difficult - mostly mlx5_flow_tcf.c is changed) and highly desirable to be backported.
It fixes serious bugs with ether_type field, which limit VLAN and VXLAN functionality on E-Switch.
With best regards,
Slava (aka Viacheslav)
> -----Original Message-----
> From: Kevin Traynor <ktraynor@redhat.com>
> Sent: Thursday, January 31, 2019 16:52
> To: Slava Ovsiienko <viacheslavo@mellanox.com>; Shahaf Shuler
> <shahafs@mellanox.com>
> Cc: dev@dpdk.org; stable@dpdk.org; Thomas Monjalon
> <thomas@monjalon.net>; Yongseok Koh <yskoh@mellanox.com>; Luca
> Boccassi <bluca@debian.org>
> Subject: Re: [dpdk-dev] [PATCH 0/5] net/mlx5: add inner tunnel items support
> on E-Switch
>
> On 12/27/2018 03:34 PM, Viacheslav Ovsiienko wrote:
> > The generic Flow rule for tunnels looks like:
> >
> > flow create <attributes> <port> \
> > <tunnel outer items pattern> \
> > <tunnel vni item> \
> > <tunnel inner items pattern>
> >
> > Current design supports only L2 addresses as inner pattern items. This
> > patchset adds support for L3 (IPv4/IPv6) addresses and L4 (TCP/UDP)
> > ports items as inner tunnel parameters.
> >
> > Also this patchset adds support for inner and outer ethernet types for
> > the E-Switch Flows with tunnels. Inner and outer ethernet type match
> > can be specified with ethernet items, vlan items, or implicitly
> > deduced from IP address items. The tcm_info field in Netlink message
> > tcm structure is filled always with outer protocol.
> >
> > Cc: stable@dpdk.org
> >
>
> Hi Viacheslav - these are new features, not a bugfixes. Are the
> stable@dpdk.org tags intentional?
>
> From
> https://emea01.safelinks.protection.outlook.com/?url=http%3A%2F%2Fdoc.dp
> dk.org%2Fguides%2Fcontributing%2Fstable.html%23what-changes-should-be-
> backported&data=02%7C01%7Cviacheslavo%40mellanox.com%7C1d6e08
> fe6f7f47d83f7e08d6878bb56d%7Ca652971c7d2e4d9ba6a4d149256f461b%7C0
> %7C0%7C636845431441557730&sdata=%2Fmgoj2Il%2Fu4CCrkAcETdoMp
> d7Ri5ash%2FUhzGv1dLXLY%3D&reserved=0
>
> --
> Features should not be backported to stable releases. It may be acceptable, in
> limited cases, to back port features for the LTS release
> where:
>
> There is a justifiable use case (for example a new PMD).
> The change is non-invasive.
> The work of preparing the backport is done by the proposer.
> There is support within the community.
> --
>
> Kevin.
>
>
> > Signed-off-by: Viacheslav Ovsiienko <viacheslavo@mellanox.com>
> >
> > Viacheslav Ovsiienko (5):
> > net/mlx5: remove checks for outer tunnel items on E-Switch
> > net/mlx5: add tunnel inner items validation on E-Switch
> > net/mlx5: add tunnel inner items support on E-Switch
> > net/mlx5: add ethernet type validation on E-Switch
> > net/mlx5: add ethernet type support for tunnels on E-Switch
> >
> > drivers/net/mlx5/mlx5_flow_tcf.c | 690
> > ++++++++++++++++++++++-----------------
> > 1 file changed, 399 insertions(+), 291 deletions(-)
> >
next prev parent reply other threads:[~2019-01-31 16:13 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-12-27 15:34 [dpdk-stable] " Viacheslav Ovsiienko
2018-12-27 15:34 ` [dpdk-stable] [PATCH 1/5] net/mlx5: remove checks for outer tunnel items " Viacheslav Ovsiienko
2018-12-27 15:34 ` [dpdk-stable] [PATCH 2/5] net/mlx5: add tunnel inner items validation " Viacheslav Ovsiienko
2018-12-27 15:34 ` [dpdk-stable] [PATCH 3/5] net/mlx5: add tunnel inner items support " Viacheslav Ovsiienko
2018-12-27 15:34 ` [dpdk-stable] [PATCH 4/5] net/mlx5: add ethernet type validation " Viacheslav Ovsiienko
2018-12-27 15:34 ` [dpdk-stable] [PATCH 5/5] net/mlx5: add ethernet type support for tunnels " Viacheslav Ovsiienko
2019-01-13 12:11 ` [dpdk-stable] [dpdk-dev] [PATCH 0/5] net/mlx5: add inner tunnel items support " Shahaf Shuler
2019-01-31 14:52 ` Kevin Traynor
2019-01-31 16:13 ` Slava Ovsiienko [this message]
2019-02-06 11:00 ` Kevin Traynor
2019-02-06 11:56 ` Slava Ovsiienko
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=AM4PR05MB3265DB1ADD303E4340266C9AD2910@AM4PR05MB3265.eurprd05.prod.outlook.com \
--to=viacheslavo@mellanox.com \
--cc=bluca@debian.org \
--cc=dev@dpdk.org \
--cc=ktraynor@redhat.com \
--cc=shahafs@mellanox.com \
--cc=stable@dpdk.org \
--cc=thomas@monjalon.net \
--cc=yskoh@mellanox.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).