From: Phil Yang <Phil.Yang@arm.com>
To: Thomas Monjalon <thomas@monjalon.net>
Cc: "dev@dpdk.org" <dev@dpdk.org>, nd <nd@arm.com>,
"anatoly.burakov@intel.com" <anatoly.burakov@intel.com>,
Herbert Guan <Herbert.Guan@arm.com>
Subject: Re: [dpdk-dev] [PATCH] test/eal_flags: Optimize memory flags test
Date: Thu, 26 Apr 2018 02:19:50 +0000 [thread overview]
Message-ID: <AM4PR08MB091381DA6DF767A35CD9E3CEE98E0@AM4PR08MB0913.eurprd08.prod.outlook.com> (raw)
In-Reply-To: <2533962.DYNjplGVFj@xps>
Hi Thomas,
That change just want to make sure below two buffers have enough space when configure RTE_MAX_NUMA_NODES=1.
/* construct an invalid socket mask with 2 megs on each socket plus
* extra 2 megs on socket that doesn't exist on current system */
char invalid_socket_mem[SOCKET_MEM_STRLEN];
char buf[SOCKET_MEM_STRLEN];> /* to avoid copying string onto itself */
Thanks,
Phil Yang
> -----Original Message-----
> From: Thomas Monjalon <thomas@monjalon.net>
> Sent: Thursday, April 26, 2018 1:07 AM
> To: Phil Yang <Phil.Yang@arm.com>
> Cc: dev@dpdk.org; nd <nd@arm.com>; anatoly.burakov@intel.com; Herbert
> Guan <Herbert.Guan@arm.com>
> Subject: Re: [dpdk-dev] [PATCH] test/eal_flags: Optimize memory flags test
>
> Hi,
>
> Your patch has been forgotten for months.
> Do not hesitate to ping if no reply.
>
> I have a question below.
>
> 06/02/2018 03:21, Phil Yang:
> > --- a/test/test/test_eal_flags.c
> > +++ b/test/test/test_eal_flags.c
> > -#define SOCKET_MEM_STRLEN (RTE_MAX_NUMA_NODES * 10)
> > +#define SOCKET_MEM_STRLEN (RTE_MAX_NUMA_NODES * 20)
>
> Why the above change?
>
> > @@ -1138,10 +1138,11 @@ test_memory_flags(void)
> > - int i, num_sockets = get_number_of_sockets();
> > + int i, num_sockets = RTE_MIN(get_number_of_sockets(),
> > + RTE_MAX_NUMA_NODES);
> > #endif
> >
> > - if (num_sockets <= 0 || num_sockets > RTE_MAX_NUMA_NODES) {
> > + if (num_sockets <= 0) {
> > printf("Error - cannot get number of sockets!\n");
> > return -1;
> > }
> >
>
>
>
>
next prev parent reply other threads:[~2018-04-26 2:19 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-02-06 2:21 Phil Yang
2018-04-25 17:07 ` Thomas Monjalon
2018-04-26 2:19 ` Phil Yang [this message]
2018-04-26 16:06 ` Thomas Monjalon
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=AM4PR08MB091381DA6DF767A35CD9E3CEE98E0@AM4PR08MB0913.eurprd08.prod.outlook.com \
--to=phil.yang@arm.com \
--cc=Herbert.Guan@arm.com \
--cc=anatoly.burakov@intel.com \
--cc=dev@dpdk.org \
--cc=nd@arm.com \
--cc=thomas@monjalon.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).