From: "Ruifeng Wang (Arm Technology China)" <Ruifeng.Wang@arm.com>
To: Hemant Agrawal <hemant.agrawal@nxp.com>,
Honnappa Nagarahalli <Honnappa.Nagarahalli@arm.com>,
"dev@dpdk.org" <dev@dpdk.org>
Cc: "thomas@monjalon.net" <thomas@monjalon.net>,
"jerinj@marvell.com" <jerinj@marvell.com>,
"bruce.richardson@intel.com" <bruce.richardson@intel.com>,
"chaozhu@linux.vnet.ibm.com" <chaozhu@linux.vnet.ibm.com>,
nd <nd@arm.com>,
"tomaszx.kulasek@intel.com" <tomaszx.kulasek@intel.com>,
nd <nd@arm.com>
Subject: Re: [dpdk-dev] [PATCH v1] examples/l3fwd: enable hash multi lookup for ARM
Date: Thu, 3 Jan 2019 10:12:23 +0000 [thread overview]
Message-ID: <AM6PR08MB3782673ADCDE69A18960518F9E8D0@AM6PR08MB3782.eurprd08.prod.outlook.com> (raw)
In-Reply-To: <7bd95a11-e7b6-abe0-1506-7d56a5cc7ffc@nxp.com>
Hi Hemant,
> -----Original Message-----
> From: Hemant Agrawal <hemant.agrawal@nxp.com>
> Sent: Thursday, January 3, 2019 16:05
> To: Honnappa Nagarahalli <Honnappa.Nagarahalli@arm.com>; Ruifeng Wang
> (Arm Technology China) <Ruifeng.Wang@arm.com>; dev@dpdk.org
> Cc: thomas@monjalon.net; jerinj@marvell.com; bruce.richardson@intel.com;
> chaozhu@linux.vnet.ibm.com; nd <nd@arm.com>;
> tomaszx.kulasek@intel.com
> Subject: Re: [dpdk-dev] [PATCH v1] examples/l3fwd: enable hash multi
> lookup for ARM
>
>
> On 02-Jan-19 11:53 PM, Honnappa Nagarahalli wrote:
> > Thanks Ruifeng for the patch. I have one question inline.
> >
> > Jerin/Hemant,
> > It would be good if you could test this on your platforms, since this is
> being made default.
> >
> > Thanks,
> > Honnappa
> >
> >> -----Original Message-----
> >> From: Ruifeng Wang <ruifeng.wang@arm.com>
> >> Sent: Tuesday, January 1, 2019 11:28 PM
> >> To: dev@dpdk.org
> >> Cc: thomas@monjalon.net; jerinj@marvell.com;
> hemant.agrawal@nxp.com;
> >> bruce.richardson@intel.com; chaozhu@linux.vnet.ibm.com; Honnappa
> >> Nagarahalli <Honnappa.Nagarahalli@arm.com>; nd <nd@arm.com>;
> Ruifeng
> >> Wang (Arm Technology China) <Ruifeng.Wang@arm.com>;
> >> tomaszx.kulasek@intel.com
> >> Subject: [PATCH v1] examples/l3fwd: enable hash multi lookup for ARM
> >>
> >> Compile option for hash_multi_lookup was broken, and caused feature
> >> cannot be enabled on Arm.
> >> This patch sets hash_multi_lookup method as default, and sequential
> >> lookup becomes optional.
> >>
> >> In test of 8192 flows with 128-byte packets, throughput increased by
> >> 25.6% after enabling hash_multi_lookup.
>
> Hi,
>
> I tested this patch on LS2088 (A72) platform. I have tried both dpaa2 and
> armv8a config for builds.
>
> In both cases, I am seeing a drop of 3-8% in different scenario using 1 core
> case with small packets.
>
> - 1 flow case - 7-8 % drop in performance
>
> - 8 K flow case - 2-5 % drop in performance
>
>
> Regards,
>
> Hemant
>
Thanks for your tests.
Were the 8K flow in your case all for hit?
Not know why, but in my tests, 1 core case with 64B packet had notable performance gain with 8K flow.
Although performance had drop with few hash entry configured.
Command used:
./l3fwd -n 4 -c 0x80 -- -E -P --parse-ptype -p 0x3 --config="(0,0,7),(1,0,7)" --hash-entry-num=0x8000
> > I assume these are lookup-hit numbers. Do you have look-up miss
> numbers?
> >
> >> Fixes: 52c97adc1f0f ("examples/l3fwd: fix exact match performance")
> >> Cc: tomaszx.kulasek@intel.com
> >>
> >> Signed-off-by: Ruifeng Wang <ruifeng.wang@arm.com>
> >> Reviewed-by: Gavin Hu <gavin.hu@arm.com>
> >> Reviewed-by: Phil Yang <phil.yang@arm.com>
> >> Tested-by: Ruifeng Wang <ruifeng.wang@arm.com>
> >> ---
> >> examples/l3fwd/l3fwd.h | 4 ----
> >> 1 file changed, 4 deletions(-)
> >>
> >> diff --git a/examples/l3fwd/l3fwd.h b/examples/l3fwd/l3fwd.h index
> >> c962deac3..063b80018 100644
> >> --- a/examples/l3fwd/l3fwd.h
> >> +++ b/examples/l3fwd/l3fwd.h
> >> @@ -11,10 +11,6 @@
> >>
> >> #define RTE_LOGTYPE_L3FWD RTE_LOGTYPE_USER1
> >>
> >> -#if !defined(NO_HASH_MULTI_LOOKUP) &&
> >> defined(RTE_MACHINE_CPUFLAG_NEON) -#define
> NO_HASH_MULTI_LOOKUP 1
> >> -#endif
> >> -
> >> #define MAX_PKT_BURST 32
> >> #define BURST_TX_DRAIN_US 100 /* TX drain every ~100us */
> >>
> >> --
> >> 2.17.1
next prev parent reply other threads:[~2019-01-03 10:12 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-01-02 5:28 Ruifeng Wang
2019-01-02 18:23 ` Honnappa Nagarahalli
2019-01-03 1:14 ` Ruifeng Wang (Arm Technology China)
2019-01-03 8:04 ` Hemant Agrawal
2019-01-03 10:12 ` Ruifeng Wang (Arm Technology China) [this message]
2019-01-03 3:34 ` [dpdk-dev] [EXT] " Jerin Jacob Kollanukkaran
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=AM6PR08MB3782673ADCDE69A18960518F9E8D0@AM6PR08MB3782.eurprd08.prod.outlook.com \
--to=ruifeng.wang@arm.com \
--cc=Honnappa.Nagarahalli@arm.com \
--cc=bruce.richardson@intel.com \
--cc=chaozhu@linux.vnet.ibm.com \
--cc=dev@dpdk.org \
--cc=hemant.agrawal@nxp.com \
--cc=jerinj@marvell.com \
--cc=nd@arm.com \
--cc=thomas@monjalon.net \
--cc=tomaszx.kulasek@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).