From: Jerin Jacob Kollanukkaran <jerinj@marvell.com>
To: "ruifeng.wang@arm.com" <ruifeng.wang@arm.com>,
"dev@dpdk.org" <dev@dpdk.org>
Cc: "Honnappa.Nagarahalli@arm.com" <Honnappa.Nagarahalli@arm.com>,
"tomaszx.kulasek@intel.com" <tomaszx.kulasek@intel.com>,
"thomas@monjalon.net" <thomas@monjalon.net>,
"chaozhu@linux.vnet.ibm.com" <chaozhu@linux.vnet.ibm.com>,
"nd@arm.com" <nd@arm.com>,
"hemant.agrawal@nxp.com" <hemant.agrawal@nxp.com>,
"bruce.richardson@intel.com" <bruce.richardson@intel.com>
Subject: Re: [dpdk-dev] [EXT] [PATCH v1] examples/l3fwd: enable hash multi lookup for ARM
Date: Thu, 3 Jan 2019 03:34:39 +0000 [thread overview]
Message-ID: <eb954f3a527032713e37a8bf83c8765df1567650.camel@marvell.com> (raw)
In-Reply-To: <20190102052826.156605-1-ruifeng.wang@arm.com>
On Wed, 2019-01-02 at 13:28 +0800, Ruifeng Wang wrote:
> -------------------------------------------------------------------
> ---
> Compile option for hash_multi_lookup was broken, and caused feature
> cannot be enabled on Arm.
> This patch sets hash_multi_lookup method as default, and sequential
> lookup becomes optional.
>
> In test of 8192 flows with 128-byte packets, throughput increased by
> 25.6% after enabling hash_multi_lookup.
# Are you changing l3fwd source code to test with 8K flows? meaning it
has only a few flows for hit case.
# Are you testing with ThunderX2?
# Can you check with single flow with 64B and one core? In my case,
I am getting >20% regression with octeontx.
Command used:
#./l3fwd -c 0x800000 -n 4 -- -P -E -p 0x3 --config="(0, 0,
23),(1,0,23)"
In addition to that,
The file examples/l3fwd/l3fwd_em_hlm.h has following change, Not sure
why we need ARM64 specific change there?
#ifdef RTE_ARCH_ARM64
#define EM_HASH_LOOKUP_COUNT 16
#else
#define EM_HASH_LOOKUP_COUNT 8
#endif
> Fixes: 52c97adc1f0f ("examples/l3fwd: fix exact match performance")
> Cc: tomaszx.kulasek@intel.com
>
> Signed-off-by: Ruifeng Wang <ruifeng.wang@arm.com>
> Reviewed-by: Gavin Hu <gavin.hu@arm.com>
> Reviewed-by: Phil Yang <phil.yang@arm.com>
> Tested-by: Ruifeng Wang <ruifeng.wang@arm.com>
> ---
> examples/l3fwd/l3fwd.h | 4 ----
> 1 file changed, 4 deletions(-)
>
> diff --git a/examples/l3fwd/l3fwd.h b/examples/l3fwd/l3fwd.h
> index c962deac3..063b80018 100644
> --- a/examples/l3fwd/l3fwd.h
> +++ b/examples/l3fwd/l3fwd.h
> @@ -11,10 +11,6 @@
>
> #define RTE_LOGTYPE_L3FWD RTE_LOGTYPE_USER1
>
> -#if !defined(NO_HASH_MULTI_LOOKUP) &&
> defined(RTE_MACHINE_CPUFLAG_NEON)
> -#define NO_HASH_MULTI_LOOKUP 1
> -#endif
> -
> #define MAX_PKT_BURST 32
> #define BURST_TX_DRAIN_US 100 /* TX drain every ~100us */
>
prev parent reply other threads:[~2019-01-03 3:34 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-01-02 5:28 [dpdk-dev] " Ruifeng Wang
2019-01-02 18:23 ` Honnappa Nagarahalli
2019-01-03 1:14 ` Ruifeng Wang (Arm Technology China)
2019-01-03 8:04 ` Hemant Agrawal
2019-01-03 10:12 ` Ruifeng Wang (Arm Technology China)
2019-01-03 3:34 ` Jerin Jacob Kollanukkaran [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=eb954f3a527032713e37a8bf83c8765df1567650.camel@marvell.com \
--to=jerinj@marvell.com \
--cc=Honnappa.Nagarahalli@arm.com \
--cc=bruce.richardson@intel.com \
--cc=chaozhu@linux.vnet.ibm.com \
--cc=dev@dpdk.org \
--cc=hemant.agrawal@nxp.com \
--cc=nd@arm.com \
--cc=ruifeng.wang@arm.com \
--cc=thomas@monjalon.net \
--cc=tomaszx.kulasek@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).