From: Joyce Kong <Joyce.Kong@arm.com>
To: Stephen Hemminger <stephen@networkplumber.org>
Cc: "thomas@monjalon.net" <thomas@monjalon.net>,
Ruifeng Wang <Ruifeng.Wang@arm.com>,
"bruce.richardson@intel.com" <bruce.richardson@intel.com>,
"dev@dpdk.org" <dev@dpdk.org>, nd <nd@arm.com>,
"stable@dpdk.org" <stable@dpdk.org>
Subject: RE: [PATCH v4 1/2] config: correct cpu instruction set for cross build
Date: Fri, 8 Dec 2023 02:51:17 +0000 [thread overview]
Message-ID: <AS4PR08MB77123A5D8B525509E18EFDFB928AA@AS4PR08MB7712.eurprd08.prod.outlook.com> (raw)
In-Reply-To: <20231207144111.7b9405fd@hermes.local>
> -----Original Message-----
> From: Stephen Hemminger <stephen@networkplumber.org>
> Sent: Friday, December 8, 2023 6:41 AM
> To: Joyce Kong <Joyce.Kong@arm.com>
> Cc: thomas@monjalon.net; Ruifeng Wang <Ruifeng.Wang@arm.com>;
> bruce.richardson@intel.com; dev@dpdk.org; nd <nd@arm.com>;
> stable@dpdk.org
> Subject: Re: [PATCH v4 1/2] config: correct cpu instruction set for cross build
>
> On Tue, 5 Dec 2023 03:52:58 +0000
> Joyce Kong <joyce.kong@arm.com> wrote:
>
> > The platform value would be 'native' only when not cross build.
> > Move the operation about modifying cpu_instruction_set while platform
> > equals 'native' to the not cross build branch.
> >
> > Fixes: bf66003b51ec ("build: use platform for generic and native
> > builds")
> > Cc: stable@dpdk.org
> >
> > Signed-off-by: Joyce Kong <joyce.kong@arm.com>
> > Reviewed-by: Ruifeng Wang <ruifeng.wang@arm.com>
>
> Looks right, what is the impact on existing users doing current cross builds?
The original operation changes cpu_instruction_set to 'native' when both 'platform == native' and 'cpu_instruction_set == auto'.
There was no impact on the existing users for current cross build, as the cross files set cpu field to a specific arch, such as 'armv8-a', and this didn't trigger the modification for cpu_instruction_set.
However, if we want to use a common arch in cross files like 'auto', the modification operation would override 'native' value to cpu_instruction_set and b7676fcccab4 ("config: verify machine arch flag") would break the build as it tries to test -march=native.
>
> Acked-by: Stephen Hemminger <stephen@networkplumber.org>
next prev parent reply other threads:[~2023-12-08 2:51 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <20230822074743.3243015-1-joyce.kong@arm.com>
[not found] ` <20231205035259.3516625-1-joyce.kong@arm.com>
2023-12-05 3:52 ` Joyce Kong
2023-12-07 22:41 ` Stephen Hemminger
2023-12-08 2:51 ` Joyce Kong [this message]
2024-01-19 19:39 ` Pavan Nikhilesh Bhagavatula
2024-03-06 14:43 ` Thomas Monjalon
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=AS4PR08MB77123A5D8B525509E18EFDFB928AA@AS4PR08MB7712.eurprd08.prod.outlook.com \
--to=joyce.kong@arm.com \
--cc=Ruifeng.Wang@arm.com \
--cc=bruce.richardson@intel.com \
--cc=dev@dpdk.org \
--cc=nd@arm.com \
--cc=stable@dpdk.org \
--cc=stephen@networkplumber.org \
--cc=thomas@monjalon.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).