From: "Mcnamara, John" <john.mcnamara@intel.com>
To: Rahul Lakkireddy <rahul.lakkireddy@chelsio.com>,
"dev@dpdk.org" <dev@dpdk.org>
Cc: Kumar Sanghvi <kumaras@chelsio.com>,
Felix Marti <felix@chelsio.com>,
Nirranjan Kirubaharan <nirranjan@chelsio.com>
Subject: Re: [dpdk-dev] [PATCH] cxgbe: fix unnecessary check for freelist existence while freeing rxq
Date: Fri, 11 Dec 2015 14:44:06 +0000 [thread overview]
Message-ID: <B27915DBBA3421428155699D51E4CFE202403460@IRSMSX103.ger.corp.intel.com> (raw)
In-Reply-To: <66655e2d7666da09b80174d265eef304b8d93470.1449821728.git.rahul.lakkireddy@chelsio.com>
> -----Original Message-----
> From: dev [mailto:dev-bounces@dpdk.org] On Behalf Of Rahul Lakkireddy
> Sent: Friday, December 11, 2015 8:26 AM
> To: dev@dpdk.org
> Cc: Felix Marti; Kumar Sanghvi; Nirranjan Kirubaharan
> Subject: [dpdk-dev] [PATCH] cxgbe: fix unnecessary check for freelist
> existence while freeing rxq
>
> When refilling freelists for the first time and if it fails, the rxq is
> freed and returns ENOMEM. There is a check while freeing hardware rxq to
> pass freelist context id if the freelist exists or 0xffff otherwise.
> The error path is only reached if freelist exists. So, fix is to remove
> the useless check for freelist existence.
>
> Thanks to John McNamara <john.mcnamara@intel.com> for reporting it.
>
> Coverity issue: 107108
> Fixes: 92c8a63223e5 ("cxgbe: add device configuration and Rx support")
>
> Signed-off-by: Rahul Lakkireddy <rahul.lakkireddy@chelsio.com>
> Signed-off-by: Kumar Sanghvi <kumaras@chelsio.com>
Thanks for updating the Coverity Triage for the issue.
Acked-by: John McNamara <john.mcnamara@intel.com>
next prev parent reply other threads:[~2015-12-11 14:44 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-12-11 8:25 Rahul Lakkireddy
2015-12-11 14:44 ` Mcnamara, John [this message]
2015-12-12 23:55 ` Thomas Monjalon
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=B27915DBBA3421428155699D51E4CFE202403460@IRSMSX103.ger.corp.intel.com \
--to=john.mcnamara@intel.com \
--cc=dev@dpdk.org \
--cc=felix@chelsio.com \
--cc=kumaras@chelsio.com \
--cc=nirranjan@chelsio.com \
--cc=rahul.lakkireddy@chelsio.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).