From: "Mcnamara, John" <john.mcnamara@intel.com>
To: Maxime Coquelin <maxime.coquelin@redhat.com>,
"yuanhan.liu@linux.intel.com" <yuanhan.liu@linux.intel.com>,
"thomas.monjalon@6wind.com" <thomas.monjalon@6wind.com>,
"Yang, Zhiyong" <zhiyong.yang@intel.com>,
"dev@dpdk.org" <dev@dpdk.org>
Cc: "fbaudin@redhat.com" <fbaudin@redhat.com>
Subject: Re: [dpdk-dev] [PATCH] doc: introduce PVP reference benchmark
Date: Thu, 24 Nov 2016 17:38:32 +0000 [thread overview]
Message-ID: <B27915DBBA3421428155699D51E4CFE20266939E@IRSMSX103.ger.corp.intel.com> (raw)
In-Reply-To: <20161123210006.7113-1-maxime.coquelin@redhat.com>
> -----Original Message-----
> From: Maxime Coquelin [mailto:maxime.coquelin@redhat.com]
> Sent: Wednesday, November 23, 2016 9:00 PM
> To: yuanhan.liu@linux.intel.com; thomas.monjalon@6wind.com; Mcnamara, John
> <john.mcnamara@intel.com>; Yang, Zhiyong <zhiyong.yang@intel.com>;
> dev@dpdk.org
> Cc: fbaudin@redhat.com; Maxime Coquelin <maxime.coquelin@redhat.com>
> Subject: [PATCH] doc: introduce PVP reference benchmark
>
> Having reference benchmarks is important in order to obtain reproducible
> performance figures.
>
> This patch describes required steps to configure a PVP setup using testpmd
> in both host and guest.
>
> Not relying on external vSwitch ease integration in a CI loop by not being
> impacted by DPDK API changes.
Hi Maxime,
Thanks for the detailed doc and this initiative. Some minor documentation
comments below.
> +
> +Setup overview
> +..............
This level header should be ---------, even if it looks like dots in the
contribution guide:
http://dpdk.org/doc/guides/contributing/documentation.html#section-headers
> +
> +.. figure:: img/pvp_2nics.svg
> +
> + PVP setup using 2 NICs
> +
The figure needs a target so it can be used with :numref:, like this:
.. _figure_pvp_2nics:
.. figure:: img/pvp_2nics.*
PVP setup using 2 NICs
> +DPDK build
> +~~~~~~~~~~
> +
Put a one line description at the start of each section, even if it is just: Build DPDK:
> +Testpmd launch
> +~~~~~~~~~~~~~~
> +
> +#. Assign NICs to DPDK:
> +
> + .. code-block:: console
> +
> + modprobe vfio-pci
> + $RTE_SDK/install/sbin/dpdk-devbind -b vfio-pci 0000:11:00.0
> + 0000:11:00.1
> +
> +*Note: Sandy Bridge family seems to have some limitations wrt its
> +IOMMU, giving poor performance results. To achieve good performance on
> +these machines, consider using UIO instead.*
This would be better as an RST note:
#. Assign NICs to DPDK:
.. code-block:: console
modprobe vfio-pci
$RTE_SDK/install/sbin/dpdk-devbind -b vfio-pci 0000:11:00.0 0000:11:00.1
.. Note::
The Sandy Bridge family seems to have some IOMMU limitations giving poor
performance results. To achieve good performance on these machines
consider using UIO instead.
> +First, SELinux policy needs to be set to permissiven, as testpmd is run
> +as root (reboot required):
s/permissiven/permissive/
There are a couple of trailing whitespace errors as well at build as well.
John
next prev parent reply other threads:[~2016-11-24 17:38 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-11-23 21:00 Maxime Coquelin
2016-11-24 5:07 ` Yuanhan Liu
2016-11-24 7:35 ` Maxime Coquelin
2016-11-29 10:16 ` Yuanhan Liu
2016-11-29 10:29 ` Maxime Coquelin
2016-11-24 11:58 ` Kevin Traynor
2016-11-24 12:39 ` Maxime Coquelin
2016-11-24 17:38 ` Mcnamara, John [this message]
2016-11-25 9:29 ` Maxime Coquelin
2016-11-28 11:22 ` Thomas Monjalon
2016-11-28 14:02 ` Maxime Coquelin
2016-11-28 14:15 ` Thomas Monjalon
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=B27915DBBA3421428155699D51E4CFE20266939E@IRSMSX103.ger.corp.intel.com \
--to=john.mcnamara@intel.com \
--cc=dev@dpdk.org \
--cc=fbaudin@redhat.com \
--cc=maxime.coquelin@redhat.com \
--cc=thomas.monjalon@6wind.com \
--cc=yuanhan.liu@linux.intel.com \
--cc=zhiyong.yang@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).