From: "Mcnamara, John" <john.mcnamara@intel.com>
To: Maxime Coquelin <maxime.coquelin@redhat.com>,
"yuanhan.liu@linux.intel.com" <yuanhan.liu@linux.intel.com>,
"thomas.monjalon@6wind.com" <thomas.monjalon@6wind.com>,
"Yang, Zhiyong" <zhiyong.yang@intel.com>,
"ktraynor@redhat.com" <ktraynor@redhat.com>,
"dev@dpdk.org" <dev@dpdk.org>
Subject: Re: [dpdk-dev] [PATCH v2] doc: introduce PVP reference benchmark
Date: Fri, 9 Dec 2016 10:26:02 +0000 [thread overview]
Message-ID: <B27915DBBA3421428155699D51E4CFE202671A59@IRSMSX103.ger.corp.intel.com> (raw)
In-Reply-To: <ba28794d-8f2f-21a9-f568-9d9b123a1be8@redhat.com>
> -----Original Message-----
> From: Maxime Coquelin [mailto:maxime.coquelin@redhat.com]
> Sent: Friday, December 9, 2016 6:30 AM
> To: Mcnamara, John <john.mcnamara@intel.com>; yuanhan.liu@linux.intel.com;
> thomas.monjalon@6wind.com; Yang, Zhiyong <zhiyong.yang@intel.com>;
> ktraynor@redhat.com; dev@dpdk.org
> Subject: Re: [PATCH v2] doc: introduce PVP reference benchmark
>
>
>
> On 12/07/2016 10:07 PM, Mcnamara, John wrote:
> >> -----Original Message-----
> >> From: Maxime Coquelin [mailto:maxime.coquelin@redhat.com]
> >> Sent: Tuesday, December 6, 2016 12:25 PM
> >> To: yuanhan.liu@linux.intel.com; thomas.monjalon@6wind.com; Mcnamara,
> >> John <john.mcnamara@intel.com>; Yang, Zhiyong
> >> <zhiyong.yang@intel.com>; ktraynor@redhat.com; dev@dpdk.org
> >> Cc: Maxime Coquelin <maxime.coquelin@redhat.com>
> >> Subject: [PATCH v2] doc: introduce PVP reference benchmark
> >>
> >> Having reference benchmarks is important in order to obtain
> >> reproducible performance figures.
> >>
> >> This patch describes required steps to configure a PVP setup using
> >> testpmd in both host and guest.
> >>
> >> Not relying on external vSwitch ease integration in a CI loop by not
> >> being impacted by DPDK API changes.
> >>
> >> Signed-off-by: Maxime Coquelin <maxime.coquelin@redhat.com>
> >
> > There is one trailing whitespace warning but apart from that:
> >
> > Acked-by: John McNamara <john.mcnamara@intel.com>
>
> Thanks John,
>
> Do you want me to send a v3, fixing the trailing whitespace & collecting
> the acks?
>
> -- Maxime
No need (unless the tree maintainer says otherwise). It was one trailing whitespace. Just something to look out for in future.
P.S., We both should have truncated the text in this mail before replying. :-/
http://dpdk.org/dev/patchwork/patch/17704/
next prev parent reply other threads:[~2016-12-09 10:26 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-12-06 12:24 Maxime Coquelin
2016-12-07 9:39 ` Yuanhan Liu
2016-12-07 12:51 ` Kevin Traynor
2016-12-07 21:07 ` Mcnamara, John
2016-12-09 6:29 ` Maxime Coquelin
2016-12-09 10:26 ` Mcnamara, John [this message]
2016-12-20 10:03 ` Thomas Monjalon
2016-12-20 14:54 ` Maxime Coquelin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=B27915DBBA3421428155699D51E4CFE202671A59@IRSMSX103.ger.corp.intel.com \
--to=john.mcnamara@intel.com \
--cc=dev@dpdk.org \
--cc=ktraynor@redhat.com \
--cc=maxime.coquelin@redhat.com \
--cc=thomas.monjalon@6wind.com \
--cc=yuanhan.liu@linux.intel.com \
--cc=zhiyong.yang@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).