From: "Wang, Xiao W" <xiao.w.wang@intel.com>
To: Olivier Matz <olivier.matz@6wind.com>,
"Chen, Jing D" <jing.d.chen@intel.com>
Cc: "dev@dpdk.org" <dev@dpdk.org>
Subject: Re: [dpdk-dev] [PATCH 4/5] net/ixgbe: implement new Rx checksum flag
Date: Wed, 31 Aug 2016 09:07:43 +0000 [thread overview]
Message-ID: <B7F2E978279D1D49A3034B7786DACF406C181947@SHSMSX101.ccr.corp.intel.com> (raw)
In-Reply-To: <f32ebe09-79b3-9d6b-0dc6-416c35c9019f@6wind.com>
Hi Olivier,
> -----Original Message-----
> From: Olivier Matz [mailto:olivier.matz@6wind.com]
> Sent: Friday, August 26, 2016 3:30 PM
> To: Wang, Xiao W <xiao.w.wang@intel.com>; Chen, Jing D
> <jing.d.chen@intel.com>
> Cc: dev@dpdk.org
> Subject: Re: [PATCH 4/5] net/ixgbe: implement new Rx checksum flag
>
> Hi Xiao,
>
> On 08/25/2016 07:48 PM, Xiao Wang wrote:
> > Add CKSUM_GOOD flag to distinguish a good checksum from an unknown
> one.
> >
> > Signed-off-by: Xiao Wang <xiao.w.wang@intel.com>
> > ---
> > drivers/net/ixgbe/ixgbe_rxtx.c | 4 +++-
> > 1 file changed, 3 insertions(+), 1 deletion(-)
> >
> > diff --git a/drivers/net/ixgbe/ixgbe_rxtx.c b/drivers/net/ixgbe/ixgbe_rxtx.c
> > index 8a306b0..d2dc82a 100644
> > --- a/drivers/net/ixgbe/ixgbe_rxtx.c
> > +++ b/drivers/net/ixgbe/ixgbe_rxtx.c
> > @@ -1345,7 +1345,9 @@ rx_desc_error_to_pkt_flags(uint32_t rx_status)
> > * Bit 30: L4I, L4I integrity error
> > */
> > static uint64_t error_to_pkt_flags_map[4] = {
> > - 0, PKT_RX_L4_CKSUM_BAD, PKT_RX_IP_CKSUM_BAD,
> > + PKT_RX_IP_CKSUM_GOOD | PKT_RX_L4_CKSUM_GOOD,
> > + PKT_RX_IP_CKSUM_GOOD | PKT_RX_L4_CKSUM_BAD,
> > + PKT_RX_IP_CKSUM_BAD | PKT_RX_L4_CKSUM_GOOD,
> > PKT_RX_IP_CKSUM_BAD | PKT_RX_L4_CKSUM_BAD
> > };
> > pkt_flags = error_to_pkt_flags_map[(rx_status >>
> >
>
> I think this would somehow conflict with the patch adding the support of
> Rx checksum offload in vector receive function:
>
> http://dpdk.org/dev/patchwork/patch/14630/
>
> Depending on which one is pushed first, the second one would need to be
> reworked.
>
> Olivier
Yes, since your patch supports cksum in vector Rx, I'll add the new cksum flags for it
based on your patch.
Best Regards,
Xiao
next prev parent reply other threads:[~2016-08-31 9:08 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-08-25 17:48 [dpdk-dev] [PATCH 0/5] " Xiao Wang
2016-08-25 17:48 ` [dpdk-dev] [PATCH 1/5] net/fm10k: add back Rx checksum offload Xiao Wang
2016-08-26 7:27 ` Olivier Matz
2016-08-31 9:02 ` Wang, Xiao W
2016-08-25 17:48 ` [dpdk-dev] [PATCH 2/5] net/fm10k: implement new Rx checksum flag Xiao Wang
2016-08-29 9:32 ` Chen, Jing D
2016-08-31 8:59 ` Wang, Xiao W
2016-08-25 17:48 ` [dpdk-dev] [PATCH 3/5] net/e1000: " Xiao Wang
2016-08-25 17:48 ` [dpdk-dev] [PATCH 4/5] net/ixgbe: " Xiao Wang
2016-08-26 7:30 ` Olivier Matz
2016-08-31 9:07 ` Wang, Xiao W [this message]
2016-08-25 17:48 ` [dpdk-dev] [PATCH 5/5] net/i40e: " Xiao Wang
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=B7F2E978279D1D49A3034B7786DACF406C181947@SHSMSX101.ccr.corp.intel.com \
--to=xiao.w.wang@intel.com \
--cc=dev@dpdk.org \
--cc=jing.d.chen@intel.com \
--cc=olivier.matz@6wind.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).