DPDK patches and discussions
 help / color / mirror / Atom feed
From: "Wang, Xiao W" <xiao.w.wang@intel.com>
To: "Richardson, Bruce" <bruce.richardson@intel.com>
Cc: "dev@dpdk.org" <dev@dpdk.org>
Subject: Re: [dpdk-dev] [PATCH-18.08 08/15] net/ifc: rename to ifcvf
Date: Fri, 18 May 2018 16:37:55 +0000	[thread overview]
Message-ID: <B7F2E978279D1D49A3034B7786DACF406F8BEB6C@SHSMSX101.ccr.corp.intel.com> (raw)
In-Reply-To: <20180518081241.GA28620@bricha3-MOBL.ger.corp.intel.com>

Hi,

> -----Original Message-----
> From: Richardson, Bruce
> Sent: Friday, May 18, 2018 4:13 PM
> To: Wang, Xiao W <xiao.w.wang@intel.com>
> Cc: dev@dpdk.org
> Subject: Re: [PATCH-18.08 08/15] net/ifc: rename to ifcvf
> 
> On Fri, May 18, 2018 at 02:52:36AM +0100, Wang, Xiao W wrote:
> > Hi Bruce,
> >
> > > -----Original Message-----
> > > From: Richardson, Bruce
> > > Sent: Friday, May 18, 2018 4:15 AM
> > > To: dev@dpdk.org
> > > Cc: Richardson, Bruce <bruce.richardson@intel.com>; Wang, Xiao W
> > > <xiao.w.wang@intel.com>
> > > Subject: [PATCH-18.08 08/15] net/ifc: rename to ifcvf
> > >
> > > All files in the directory and the resulting driver have prefix of ifcvf,
> > > not just ifc, so rename directory for accuracy. Also rename the map file
> > > to standard name for meson build in the process.
> >
> > Naming the directory as "ifc" allows us to add ifcpf driver into it in the future.
> >
> > BRs,
> > Xiao
> >
> 
> At which point you will have to rename the version file, the rst
> documentation file, the resulting shared library file etc. Right now, most
> of the references are to ifcvf, with the only exception being the folder
> name. This patch makes things consistent by having everything refer to
> ifcvf.

OK.

> 
> If you prefer, I can do a v2 of this set renaming everything to ifc, but
> that would be a lot bigger a job, and would also result in the driver file
> itself getting a new name too. Unless there are immediate plans to add an
> ifcpf driver, I think this change makes more sense.

No need for that.

BRs,
Xiao
> 
> /Bruce

  reply	other threads:[~2018-05-18 16:38 UTC|newest]

Thread overview: 43+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-05-17 20:15 [dpdk-dev] [PATCH-18.08 00/15] add meson support for more net drivers Bruce Richardson
2018-05-17 20:15 ` [dpdk-dev] [PATCH-18.08 01/15] net/ark: add to meson build Bruce Richardson
2018-05-17 20:15 ` [dpdk-dev] [PATCH-18.08 02/15] net/avp: " Bruce Richardson
2018-05-18 11:13   ` Legacy, Allain
2018-05-17 20:15 ` [dpdk-dev] [PATCH-18.08 03/15] net/bnx2x: " Bruce Richardson
2018-05-17 20:15 ` [dpdk-dev] [PATCH-18.08 04/15] net/bnxt: " Bruce Richardson
2018-05-17 20:15 ` [dpdk-dev] [PATCH-18.08 05/15] net/cxgbe: " Bruce Richardson
2018-05-17 20:15 ` [dpdk-dev] [PATCH-18.08 06/15] net/ena: " Bruce Richardson
2018-05-17 20:15 ` [dpdk-dev] [PATCH-18.08 07/15] net/failsafe: " Bruce Richardson
2018-05-17 20:15 ` [dpdk-dev] [PATCH-18.08 08/15] net/ifc: rename to ifcvf Bruce Richardson
2018-05-18  1:52   ` Wang, Xiao W
2018-05-18  8:12     ` Bruce Richardson
2018-05-18 16:37       ` Wang, Xiao W [this message]
2018-05-17 20:15 ` [dpdk-dev] [PATCH-18.08 09/15] net/ifcvf: add to meson build Bruce Richardson
2018-05-17 20:15 ` [dpdk-dev] [PATCH-18.08 10/15] net/kni: " Bruce Richardson
2018-05-17 20:15 ` [dpdk-dev] [PATCH-18.08 11/15] net/liquidio: " Bruce Richardson
2018-05-21  8:47   ` Shijith Thotton
2018-05-17 20:15 ` [dpdk-dev] [PATCH-18.08 12/15] net/nfp: " Bruce Richardson
2018-05-17 20:15 ` [dpdk-dev] [PATCH-18.08 13/15] net/softnic: " Bruce Richardson
2018-05-17 20:15 ` [dpdk-dev] [PATCH-18.08 14/15] net/szedata2: " Bruce Richardson
2018-05-17 20:15 ` [dpdk-dev] [PATCH-18.08 15/15] net/vhost: " Bruce Richardson
2018-06-08 21:20 ` [dpdk-dev] [PATCH v2 00/15] add meson support for more net drivers Bruce Richardson
2018-06-08 21:20   ` [dpdk-dev] [PATCH v2 01/15] net/ark: add to meson build Bruce Richardson
2018-06-08 21:20   ` [dpdk-dev] [PATCH v2 02/15] net/avp: " Bruce Richardson
2018-06-08 21:20   ` [dpdk-dev] [PATCH v2 03/15] net/bnx2x: " Bruce Richardson
2018-06-08 21:20   ` [dpdk-dev] [PATCH v2 04/15] net/bnxt: " Bruce Richardson
2018-06-08 21:20   ` [dpdk-dev] [PATCH v2 05/15] net/cxgbe: " Bruce Richardson
2018-06-14 14:55     ` Ferruh Yigit
2018-06-08 21:20   ` [dpdk-dev] [PATCH v2 06/15] net/ena: " Bruce Richardson
2018-06-14 14:55     ` Ferruh Yigit
2018-06-08 21:20   ` [dpdk-dev] [PATCH v2 07/15] net/failsafe: " Bruce Richardson
2018-06-08 21:20   ` [dpdk-dev] [PATCH v2 08/15] net/ifc: rename to ifcvf Bruce Richardson
2018-06-13  2:46     ` Wang, Xiao W
2018-06-13 10:19       ` Bruce Richardson
2018-06-08 21:20   ` [dpdk-dev] [PATCH v2 09/15] net/ifcvf: add to meson build Bruce Richardson
2018-06-08 21:20   ` [dpdk-dev] [PATCH v2 10/15] net/kni: " Bruce Richardson
2018-06-08 21:20   ` [dpdk-dev] [PATCH v2 11/15] net/liquidio: " Bruce Richardson
2018-06-08 21:20   ` [dpdk-dev] [PATCH v2 12/15] net/nfp: " Bruce Richardson
2018-06-08 21:20   ` [dpdk-dev] [PATCH v2 13/15] net/softnic: " Bruce Richardson
2018-06-08 21:20   ` [dpdk-dev] [PATCH v2 14/15] net/szedata2: " Bruce Richardson
2018-06-08 21:20   ` [dpdk-dev] [PATCH v2 15/15] net/vhost: " Bruce Richardson
2018-06-14 14:55   ` [dpdk-dev] [PATCH v2 00/15] add meson support for more net drivers Ferruh Yigit
2018-06-14 16:25   ` Ferruh Yigit

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=B7F2E978279D1D49A3034B7786DACF406F8BEB6C@SHSMSX101.ccr.corp.intel.com \
    --to=xiao.w.wang@intel.com \
    --cc=bruce.richardson@intel.com \
    --cc=dev@dpdk.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).