From: "Li, Xiaoyun" <xiaoyun.li@intel.com>
To: "Xing, Beilei" <beilei.xing@intel.com>,
"Yigit, Ferruh" <ferruh.yigit@intel.com>,
"Zhang, Qi Z" <qi.z.zhang@intel.com>,
"dev@dpdk.org" <dev@dpdk.org>
Subject: Re: [dpdk-dev] [PATCH] net/i40e: select fdir config automatically
Date: Fri, 28 Sep 2018 10:38:21 +0000 [thread overview]
Message-ID: <B9E724F4CB7543449049E7AE7669D82F656F3A@SHSMSX101.ccr.corp.intel.com> (raw)
In-Reply-To: <94479800C636CB44BD422CB454846E013224BDA2@SHSMSX101.ccr.corp.intel.com>
Will correct it in v2. Thanks.
> -----Original Message-----
> From: Xing, Beilei
> Sent: Friday, September 28, 2018 16:40
> To: Li, Xiaoyun <xiaoyun.li@intel.com>; Yigit, Ferruh
> <ferruh.yigit@intel.com>; Zhang, Qi Z <qi.z.zhang@intel.com>;
> dev@dpdk.org
> Subject: RE: [PATCH] net/i40e: select fdir config automatically
>
>
>
> > -----Original Message-----
> > From: Li, Xiaoyun
> > Sent: Friday, September 28, 2018 3:25 PM
> > To: Yigit, Ferruh <ferruh.yigit@intel.com>; Zhang, Qi Z
> > <qi.z.zhang@intel.com>; Xing, Beilei <beilei.xing@intel.com>;
> > dev@dpdk.org
> > Cc: Li, Xiaoyun <xiaoyun.li@intel.com>
> > Subject: [PATCH] net/i40e: select fdir config automatically
> >
> > I40e driver needed users to config exact fdir mode to create rte_flow
> > rules but it shouldn't. This patch allows users to create rte_flow
> > rules without configuring fdir mode and let the driver select the config
> automatically.
> >
> > Signed-off-by: Xiaoyun Li <xiaoyun.li@intel.com>
> > ---
> > drivers/net/i40e/i40e_flow.c | 33 ++++++++++++++++++++++++++++-----
> > 1 file changed, 28 insertions(+), 5 deletions(-)
> >
> > diff --git a/drivers/net/i40e/i40e_flow.c
> > b/drivers/net/i40e/i40e_flow.c index
> > c67b264de..70ff33ac0 100644
> > --- a/drivers/net/i40e/i40e_flow.c
> > +++ b/drivers/net/i40e/i40e_flow.c
> > @@ -3127,6 +3127,7 @@ i40e_flow_parse_fdir_filter(struct rte_eth_dev
> > *dev,
> > struct rte_flow_error *error,
> > union i40e_filter_t *filter)
> > {
> > + struct i40e_pf *pf = I40E_DEV_PRIVATE_TO_PF(dev->data-
> > >dev_private);
> > struct i40e_fdir_filter_conf *fdir_filter =
> > &filter->fdir_filter;
> > int ret;
> > @@ -3148,14 +3149,29 @@ i40e_flow_parse_fdir_filter(struct
> rte_eth_dev
> > *dev,
> >
> > if (dev->data->dev_conf.fdir_conf.mode !=
> > RTE_FDIR_MODE_PERFECT) {
> > - rte_flow_error_set(error, ENOTSUP,
> > - RTE_FLOW_ERROR_TYPE_UNSPECIFIED,
> > - NULL,
> > - "Check the mode in fdir_conf.");
> > - return -rte_errno;
> > + /* Enable fdir when fdir flow is added at first time. */
> > + ret = i40e_fdir_setup(pf);
> > + if (ret != I40E_SUCCESS) {
> > + rte_flow_error_set(error, ENOTSUP,
> > + RTE_FLOW_ERROR_TYPE_HANDLE,
> > + NULL, "Failed to setup fdir.");
> > + return -rte_errno;
> > + }
> > + ret = i40e_fdir_configure(dev);
> > + if (ret < 0) {
> > + rte_flow_error_set(error, ENOTSUP,
> > + RTE_FLOW_ERROR_TYPE_HANDLE,
> > + NULL, "Failed to configure fdir.");
> > + goto err;
> > + }
> > +
> > + dev->data->dev_conf.fdir_conf.mode =
> > RTE_FDIR_MODE_PERFECT;
> > }
> >
> > return 0;
> > +err:
> > + i40e_fdir_teardown(pf);
> > + return -rte_errno;
> > }
> >
> > /* Parse to get the action info of a tunnel filter @@ -4708,6
> > +4724,13 @@ i40e_flow_destroy(struct rte_eth_dev *dev,
> > case RTE_ETH_FILTER_FDIR:
> > ret = i40e_flow_add_del_fdir_filter(dev,
> > &((struct i40e_fdir_filter *)flow->rule)->fdir, 0);
> > +
> > + /* If the last flow is destroyed, disable fdir. */
> > + if (!ret && !TAILQ_FIRST(&pf->fdir.fdir_list)) {
>
> How about TAILQ_EMPTY which is more intuitive?
>
> > + i40e_fdir_teardown(pf);
> > + dev->data->dev_conf.fdir_conf.mode =
> > + RTE_FDIR_MODE_NONE;
> > + }
>
> Do you consider FDIR teardown after FDIR flush?
>
> > break;
> > case RTE_ETH_FILTER_HASH:
> > ret = i40e_config_rss_filter_del(dev,
> > --
> > 2.17.1
next prev parent reply other threads:[~2018-09-28 10:38 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-09-28 7:24 Xiaoyun Li
2018-09-28 8:40 ` Xing, Beilei
2018-09-28 10:38 ` Li, Xiaoyun [this message]
2018-09-28 11:03 ` [dpdk-dev] [PATCH v2] " Xiaoyun Li
2018-09-29 8:36 ` Xing, Beilei
2018-09-29 8:40 ` Li, Xiaoyun
2018-09-29 8:44 ` [dpdk-dev] [PATCH v3] " Xiaoyun Li
2018-09-30 2:08 ` [dpdk-dev] [PATCH v4] net/i40e: config fdir automatically Xiaoyun Li
2018-09-30 2:29 ` [dpdk-dev] [PATCH v5] " Xiaoyun Li
2018-09-30 2:41 ` Xing, Beilei
2018-09-30 3:31 ` Zhang, Qi Z
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=B9E724F4CB7543449049E7AE7669D82F656F3A@SHSMSX101.ccr.corp.intel.com \
--to=xiaoyun.li@intel.com \
--cc=beilei.xing@intel.com \
--cc=dev@dpdk.org \
--cc=ferruh.yigit@intel.com \
--cc=qi.z.zhang@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).