From: Levend Sayar <levendsayar@gmail.com>
To: Ferruh Yigit <ferruh.yigit@amd.com>
Cc: "Guo, Junfeng" <junfeng.guo@intel.com>, dev@dpdk.org
Subject: Re: [PATCH v2 1/4] net/gve: change offloading capability
Date: Sat, 18 Feb 2023 09:28:48 +0300 [thread overview]
Message-ID: <BE5A4AD8-C5F4-4154-95B8-9D6A4AA97C84@gmail.com> (raw)
In-Reply-To: <dfd7c61d-db86-4b01-cca8-a9c3c0d62a5e@amd.com>
[-- Attachment #1: Type: text/plain, Size: 1953 bytes --]
Hi Ferruh,
Thanks for your comments.
Yes, you’re right.
After I sent v2 of my patches, I got an error mail saying unable to merge.
New patches from Junfeng pushed to the repo for net/gve.
Anyway I have done requested on patchwork and superseded these v2 patch set.
Sorry for the inconvenience.
Best,
Levend
> On 17 Feb 2023, at 15:43, Ferruh Yigit <ferruh.yigit@amd.com> wrote:
>
> On 2/16/2023 6:10 PM, Levend Sayar wrote:
>> Google Virtual NIC is not doing IPv4 checksummimg.
>> Removed that capability from PMD.
>>
>> Signed-off-by: Levend Sayar <levendsayar@gmail.com>
>> ---
>> drivers/net/gve/gve_ethdev.c | 1 -
>> 1 file changed, 1 deletion(-)
>>
>> diff --git a/drivers/net/gve/gve_ethdev.c b/drivers/net/gve/gve_ethdev.c
>> index 97781f0ed3..e357f16e16 100644
>> --- a/drivers/net/gve/gve_ethdev.c
>> +++ b/drivers/net/gve/gve_ethdev.c
>> @@ -282,7 +282,6 @@ gve_dev_info_get(struct rte_eth_dev *dev, struct rte_eth_dev_info *dev_info)
>> dev_info->rx_offload_capa = 0;
>> dev_info->tx_offload_capa =
>> RTE_ETH_TX_OFFLOAD_MULTI_SEGS |
>> - RTE_ETH_TX_OFFLOAD_IPV4_CKSUM |
>> RTE_ETH_TX_OFFLOAD_UDP_CKSUM |
>> RTE_ETH_TX_OFFLOAD_TCP_CKSUM |
>> RTE_ETH_TX_OFFLOAD_SCTP_CKSUM |
>
> Hi Levend,
>
>
> there are multiple version of same patch, it is confusing for reviewers
> and maintainers.
>
> Can you please:
>
> - User versions tag, and keep increasing it. Like this one has v2, which
> is good, but next one sent after this doesn't have any version tag.
>
> - Use git send-email '--in-reply-to' parameter to keep all versions in
> same email thread. More details on documentation:
> https://doc.dpdk.org/guides/contributing/patches.html#sending-patches
>
> - Clean patchwork after a new version sent by marking old version
> appropriately (most of times as 'superseded')
> https://patches.dpdk.org/project/dpdk/list/?submitter=1813
>
>
> Thanks,
> ferruh
[-- Attachment #2: Type: text/html, Size: 16910 bytes --]
prev parent reply other threads:[~2023-02-18 6:29 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-02-16 18:10 Levend Sayar
2023-02-16 18:10 ` [PATCH v2 2/4] net/gve: add standard and extended statistics Levend Sayar
2023-02-17 12:49 ` Ferruh Yigit
2023-02-16 18:10 ` [PATCH v2 3/4] " Levend Sayar
2023-02-16 18:10 ` [PATCH v2 4/4] " Levend Sayar
2023-02-17 12:43 ` [PATCH v2 1/4] net/gve: change offloading capability Ferruh Yigit
2023-02-18 6:28 ` Levend Sayar [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=BE5A4AD8-C5F4-4154-95B8-9D6A4AA97C84@gmail.com \
--to=levendsayar@gmail.com \
--cc=dev@dpdk.org \
--cc=ferruh.yigit@amd.com \
--cc=junfeng.guo@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).