From: "Steve Shin (jonshin)" <jonshin@cisco.com>
To: Igor Ryzhov <iryzhov@nfware.com>
Cc: "dev@dpdk.org" <dev@dpdk.org>,
"ferruh.yigit@intel.com" <ferruh.yigit@intel.com>
Subject: Re: [dpdk-dev] [PATCH] lib/librte_ether: error handling on MAC address replay
Date: Fri, 20 Jan 2017 02:30:21 +0000 [thread overview]
Message-ID: <BE8C2298-214F-4D75-A7A0-08063D4B1092@cisco.com> (raw)
In-Reply-To: <CAF+s_Fz+X9MUxjysrLSgmpibapVvGOab4C-oDSJdPt8Lv+Z4Hw@mail.gmail.com>
Thanks Igor for your comments!
A good point on the first item.
For the second question, I walked through device initialization routines to see any other potential issue.
I found one case where index 0 is still required to replay MAC address; ex) MAC address change on the PHY port – index 0
No code path was found to restore a changed MAC value with index 0. Therefore, we may have to use the existing rte_eth_dev_config_restore() function to replay 0 indexed MAC.
Currently rte_eth_dev_default_mac_addr_set() is called to program PHY MAC without setting mac_pool_sel for 0 index.
So the following code is also required inside rte_eth_dev_default_mac_addr_set() routine as a complete solution:
@@ -2237,6 +2234,9 @@ struct rte_eth_dev *
(*dev->dev_ops->mac_addr_set)(dev, addr);
+ /* Update pool bitmap in NIC data structure */
+ dev->data->mac_pool_sel[0] = 1;
+
return 0;
Any thoughts would be appreciated.
Regards,
Steve
From: Igor Ryzhov <iryzhov@nfware.com>
Date: Thursday, January 19, 2017 at 2:39 PM
To: Steve Shin <jonshin@cisco.com>
Cc: "dev@dpdk.org" <dev@dpdk.org>, "ferruh.yigit@intel.com" <ferruh.yigit@intel.com>
Subject: Re: [dpdk-dev] [PATCH] lib/librte_ether: error handling on MAC address replay
Hello Steve,
Thank you for the patch.
I think a couple of improvements can be done:
1. Function existence check – if (*dev->dev_ops->mac_addr_add) – can be taken out of the loop. We don't need to check it on each iteration.
2. I'm not completely sure, but I think loop can be started from 1, not from 0, because mac_pool_sel[0] is always zero. Am I right?
Best regards,
Igor
On Thu, Jan 19, 2017 at 10:35 PM, Steve Shin (jonshin) <jonshin@cisco.com<mailto:jonshin@cisco.com>> wrote:
Dear maintainer,
Sorry that I forgot to add “Fixes:” line as follows:
Fixes: 4bdefaade6d1 ("ethdev: VMDQ enhancements")
Can you please add the above line as part of comment?
Thanks,
Steve
On 1/19/17, 10:47 AM, "Steve Shin (jonshin)" <jonshin@cisco.com<mailto:jonshin@cisco.com>> wrote:
This patch fixes a bug in replaying MAC address to the hardware
in rte_eth_dev_config_restore() routine.
Signed-off-by: Steve Shin <jonshin@cisco.com<mailto:jonshin@cisco.com>>
---
lib/librte_ether/rte_ethdev.c | 10 ++++++----
1 file changed, 6 insertions(+), 4 deletions(-)
diff --git a/lib/librte_ether/rte_ethdev.c b/lib/librte_ether/rte_ethdev.c
index 4790faf..7e01f10 100644
--- a/lib/librte_ether/rte_ethdev.c
+++ b/lib/librte_ether/rte_ethdev.c
@@ -951,10 +951,12 @@ rte_eth_dev_config_restore(uint8_t port_id)
continue;
/* add address to the hardware */
- if (*dev->dev_ops->mac_addr_add &&
- (dev->data->mac_pool_sel[i] & (1ULL << pool)))
- (*dev->dev_ops->mac_addr_add)(dev, &addr, i, pool);
- else {
+ if (*dev->dev_ops->mac_addr_add) {
+ if (dev->data->mac_pool_sel[i] & (1ULL << pool))
+ (*dev->dev_ops->mac_addr_add)(dev, &addr, i, pool);
+ else
+ continue;
+ } else {
RTE_PMD_DEBUG_TRACE("port %d: MAC address array not supported\n",
port_id);
/* exit the loop but not return an error */
--
2.9.3
next prev parent reply other threads:[~2017-01-20 2:32 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-01-19 18:47 Steve Shin
2017-01-19 19:35 ` Steve Shin (jonshin)
2017-01-19 22:39 ` Igor Ryzhov
2017-01-20 2:30 ` Steve Shin (jonshin) [this message]
2017-01-20 12:17 ` Igor Ryzhov
2017-01-20 19:12 ` Steve Shin (jonshin)
2017-01-20 22:23 ` [dpdk-dev] [PATCH v2] ethdev: fix " Steve Shin
2017-01-23 8:50 ` Igor Ryzhov
2017-01-23 23:19 ` Steve Shin (jonshin)
2017-01-23 23:50 ` [dpdk-dev] [PATCH v3] " Steve Shin
2017-01-24 2:21 ` [dpdk-dev] [PATCH v4] " Steve Shin
2017-01-24 10:09 ` Igor Ryzhov
2017-01-24 13:21 ` Ferruh Yigit
2017-01-24 14:00 ` Igor Ryzhov
2017-01-25 10:25 ` Thomas Monjalon
2017-01-27 17:57 ` [dpdk-dev] [PATCH v5] " Steve Shin
2017-01-30 9:21 ` Thomas Monjalon
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=BE8C2298-214F-4D75-A7A0-08063D4B1092@cisco.com \
--to=jonshin@cisco.com \
--cc=dev@dpdk.org \
--cc=ferruh.yigit@intel.com \
--cc=iryzhov@nfware.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).