From: Igor Ryzhov <iryzhov@nfware.com>
To: Ferruh Yigit <ferruh.yigit@intel.com>
Cc: Steve Shin <jonshin@cisco.com>, "dev@dpdk.org" <dev@dpdk.org>,
Thomas Monjalon <thomas.monjalon@6wind.com>
Subject: Re: [dpdk-dev] [PATCH v4] ethdev: fix MAC address replay
Date: Tue, 24 Jan 2017 17:00:24 +0300 [thread overview]
Message-ID: <CAF+s_FyG8wJZQQEVnFgOE49GZMGGvks_vGrQ1bEO9LKU4Mw2mA@mail.gmail.com> (raw)
In-Reply-To: <5cd19f6a-311c-b0fe-5d6c-ee757ac2e86e@intel.com>
Hello Ferruh,
Thanks for the explanation.
I tried to find something like that in "Contribution Guidelines" and found
that both "Acked-by" and "Reviewed-by" are just mentioned but not explained.
Meaning of these sentences can be different in different projects so it can
be good to explain it in DPDK development guidelines.
Best regards,
Igor
On Tue, Jan 24, 2017 at 4:21 PM, Ferruh Yigit <ferruh.yigit@intel.com>
wrote:
> On 1/24/2017 10:09 AM, Igor Ryzhov wrote:
> > Thank you Steve.
> >
>
> > I never did it before and I don't know if I have rights for that, but:
> >
> > Acked-by: Igor Ryzhov <iryzhov@nfware.com <mailto:iryzhov@nfware.com>>
>
> Unrelated to the patch itself, but since it has been mentioned, let me
> share what I know, I believe Thomas or others will correct me if I am
> wrong:
>
> - Everyone can Ack.
> And this is useful information for maintainers, so it is something
> good when more people review and ack. Please do.
>
> - Multiple ack or review is better.
>
> - But each Ack does not have same weight, maintainer decides on this
> weight, based on contribution of the person who ack'ed.
>
> - There is slight difference between Acked-by and Reviewed-by:
>
> -- Acked-by: Kind of asking for patch to be applied, saying this patch
> is good and please get it.
>
> -- Reviewed-by: Saying I have done the review at my best and patch looks
> good to me.
>
> Acked-by has slightly more responsibility than Reviewed-by.
>
> If you are not maintainer of that field, and not have strong opinion
> about that patch to be merged, it is possible to prefer Reviewed-by
> against Acked-by.
>
> But overall both are good, and definitely better than not saying
> anything at all.
>
> Thanks,
> ferruh
>
> >
> > On Tue, Jan 24, 2017 at 5:21 AM, Steve Shin <jonshin@cisco.com
> > <mailto:jonshin@cisco.com>> wrote:
> >
> > This patch fixes a bug in replaying MAC address to the hardware
> > in rte_eth_dev_config_restore() routine. Added default MAC replay as
> > well.
> >
> > Fixes: 4bdefaade6d1 ("ethdev: VMDQ enhancements")
> >
> > ---
> > v2: Added default MAC replay & Code optimization
> > v3: Covered a case (ex, SR-IOV) where multiple pools
> > exist in the mac_pool_sel array.
> > v4: removed a coding style warning
> >
> > Signed-off-by: Steve Shin <jonshin@cisco.com <mailto:
> jonshin@cisco.com>>
> >
>
>
next prev parent reply other threads:[~2017-01-24 14:00 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-01-19 18:47 [dpdk-dev] [PATCH] lib/librte_ether: error handling on " Steve Shin
2017-01-19 19:35 ` Steve Shin (jonshin)
2017-01-19 22:39 ` Igor Ryzhov
2017-01-20 2:30 ` Steve Shin (jonshin)
2017-01-20 12:17 ` Igor Ryzhov
2017-01-20 19:12 ` Steve Shin (jonshin)
2017-01-20 22:23 ` [dpdk-dev] [PATCH v2] ethdev: fix " Steve Shin
2017-01-23 8:50 ` Igor Ryzhov
2017-01-23 23:19 ` Steve Shin (jonshin)
2017-01-23 23:50 ` [dpdk-dev] [PATCH v3] " Steve Shin
2017-01-24 2:21 ` [dpdk-dev] [PATCH v4] " Steve Shin
2017-01-24 10:09 ` Igor Ryzhov
2017-01-24 13:21 ` Ferruh Yigit
2017-01-24 14:00 ` Igor Ryzhov [this message]
2017-01-25 10:25 ` Thomas Monjalon
2017-01-27 17:57 ` [dpdk-dev] [PATCH v5] " Steve Shin
2017-01-30 9:21 ` Thomas Monjalon
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CAF+s_FyG8wJZQQEVnFgOE49GZMGGvks_vGrQ1bEO9LKU4Mw2mA@mail.gmail.com \
--to=iryzhov@nfware.com \
--cc=dev@dpdk.org \
--cc=ferruh.yigit@intel.com \
--cc=jonshin@cisco.com \
--cc=thomas.monjalon@6wind.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).