From: "Mody, Rasesh" <Rasesh.Mody@cavium.com>
To: Ferruh Yigit <ferruh.yigit@intel.com>,
Harish Patil <harish.patil@qlogic.com>,
"dev@dpdk.org" <dev@dpdk.org>
Cc: "Dept-EngDPDKDev@qlogic.com" <Dept-EngDPDKDev@qlogic.com>
Subject: Re: [dpdk-dev] [PATCH 1/7] net/qede: reduce noise in debug logs
Date: Tue, 20 Dec 2016 23:29:35 +0000 [thread overview]
Message-ID: <BLUPR0701MB15721A3B263CD2677ECCF6239F900@BLUPR0701MB1572.namprd07.prod.outlook.com> (raw)
In-Reply-To: <eedda5d5-a276-70c2-41a5-431c6fa1e128@intel.com>
> From: Ferruh Yigit [mailto:ferruh.yigit@intel.com]
> Sent: Thursday, December 08, 2016 8:49 AM
>
> On 12/3/2016 2:43 AM, Harish Patil wrote:
> > From: Rasesh Mody <Rasesh.Mody@cavium.com>
> >
> > Replace CONFIG_RTE_LIBRTE_QEDE_DEBUG_DRIVER with
> > CONFIG_RTE_LIBRTE_QEDE_DEBUG_VAL which is a 32-bit bitmapped value
> > where each bit represent a particular submodule to debug. Also move
> > notice messages under CONFIG_RTE_LIBRTE_QEDE_DEBUG_INFO.
> >
> > Signed-off-by: Harish Patil <harish.patil@qlogic.com>
> > Signed-off-by: Rasesh Mody <Rasesh.Mody@cavium.com>
> > ---
>
> Is 32bit supported by driver?
We compile test our drivers for 32bit.
> If so it is throwing a compilation error for it [1], if not can you please
> document it?
>
> [1]
> In file included from .../drivers/net/qede/base/ecore.h:35:0,
> from .../drivers/net/qede/qede_ethdev.h:22,
> from .../drivers/net/qede/qede_ethdev.c:9:
> .../drivers/net/qede/qede_ethdev.c: In function 'qede_rss_hash_update':
> .../drivers/net/qede/base/../qede_logs.h:33:3: error: format '%lx'
> expects argument of type 'long unsigned int', but argument 7 has type
> 'uint64_t {aka long long unsigned int}' [-Werror=format=]
> "[%s:%d(%s)]" fmt, \
> ^
> .../drivers/net/qede/qede_ethdev.c:1472:2: note: in expansion of macro
> 'DP_INFO'
> DP_INFO(edev, "RSS hf = 0x%lx len = %u key = %p\n", hf, len, key);
> ^~~~~~~
> cc1: all warnings being treated as errors
We'll fix the compilation error.
>
>
> <...>
prev parent reply other threads:[~2016-12-20 23:29 UTC|newest]
Thread overview: 35+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-12-03 2:43 Harish Patil
2016-12-03 2:43 ` [dpdk-dev] [PATCH 2/7] net/qede: refactor filtering code Harish Patil
2016-12-08 16:45 ` Ferruh Yigit
2016-12-12 17:36 ` Harish Patil
2016-12-12 17:53 ` Ferruh Yigit
2016-12-20 23:12 ` Harish Patil
2016-12-03 2:43 ` [dpdk-dev] [PATCH 3/7] net/qede: add slowpath support for VXLAN tunneling Harish Patil
2016-12-03 2:43 ` [dpdk-dev] [PATCH 4/7] net/qede: add fastpath " Harish Patil
2016-12-03 2:43 ` [dpdk-dev] [PATCH 5/7] net/qede: fix RSS related issue Harish Patil
2016-12-03 2:43 ` [dpdk-dev] [PATCH 6/7] net/qede: fix maximum VF count to 0 Harish Patil
2016-12-08 16:45 ` Ferruh Yigit
2016-12-12 17:47 ` Harish Patil
2016-12-12 18:13 ` Ferruh Yigit
2016-12-19 13:38 ` Thomas Monjalon
2016-12-20 23:15 ` Harish Patil
2016-12-03 2:43 ` [dpdk-dev] [PATCH 7/7] net/qede: restrict maximum queues for PF/VF Harish Patil
2016-12-08 16:45 ` Ferruh Yigit
2016-12-12 19:29 ` Harish Patil
2016-12-12 20:10 ` Ferruh Yigit
2016-12-20 23:16 ` Harish Patil
2016-12-08 16:44 ` [dpdk-dev] [PATCH 1/7] net/qede: reduce noise in debug logs Ferruh Yigit
2016-12-12 17:15 ` Harish Patil
2016-12-12 17:50 ` Ferruh Yigit
2016-12-20 22:02 ` Harish Patil
2016-12-23 0:48 ` [dpdk-dev] [PATCH v2 " Harish Patil
2016-12-23 15:14 ` Ferruh Yigit
2016-12-23 15:25 ` Ferruh Yigit
2016-12-23 0:48 ` [dpdk-dev] [PATCH v2 2/7] net/qede: fix filtering code Harish Patil
2016-12-23 0:48 ` [dpdk-dev] [PATCH v2 3/7] net/qede: add slowpath support for VXLAN tunneling Harish Patil
2016-12-23 0:48 ` [dpdk-dev] [PATCH v2 4/7] net/qede: add fastpath " Harish Patil
2016-12-23 0:48 ` [dpdk-dev] [PATCH v2 5/7] net/qede: fix RSS related issue Harish Patil
2016-12-23 0:48 ` [dpdk-dev] [PATCH v2 6/7] net/qede: fix reporting of SR-IOV PF driver as disabled Harish Patil
2016-12-23 0:48 ` [dpdk-dev] [PATCH v2 7/7] net/qede: restrict maximum queues for PF/VF Harish Patil
2016-12-08 16:48 ` [dpdk-dev] [PATCH 1/7] net/qede: reduce noise in debug logs Ferruh Yigit
2016-12-20 23:29 ` Mody, Rasesh [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=BLUPR0701MB15721A3B263CD2677ECCF6239F900@BLUPR0701MB1572.namprd07.prod.outlook.com \
--to=rasesh.mody@cavium.com \
--cc=Dept-EngDPDKDev@qlogic.com \
--cc=dev@dpdk.org \
--cc=ferruh.yigit@intel.com \
--cc=harish.patil@qlogic.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).