From: Vidya Sagar Velumuri <vvelumuri@marvell.com>
To: "De Lara Guarch, Pablo" <pablo.de.lara.guarch@intel.com>,
Ankur Dwivedi <adwivedi@marvell.com>,
Anoob Joseph <anoobj@marvell.com>,
Tejasree Kondoj <ktejasree@marvell.com>,
Nithin Kumar Dabilpuram <ndabilpuram@marvell.com>,
Akhil Goyal <gakhil@marvell.com>,
"Doherty, Declan" <declan.doherty@intel.com>
Cc: "dev@dpdk.org" <dev@dpdk.org>
Subject: Re: [dpdk-dev] [PATCH v1] test/crypto: fix: test vectors for zuc 256 bit key
Date: Tue, 2 Nov 2021 04:40:34 +0000 [thread overview]
Message-ID: <BY3PR18MB462888035FC79E5F31ACEA45A78B9@BY3PR18MB4628.namprd18.prod.outlook.com> (raw)
In-Reply-To: <BY3PR18MB4628359C67B48921CF3A3055A78A9@BY3PR18MB4628.namprd18.prod.outlook.com>
Hi Pablo,
We verified vectors mentioned in below link in our platform and all the vectors passed (i.e: the digest matches with the doc).
http://www.is.cas.cn/ztzl2016/zouchongzhi/201801/W020180126529970733243.pdf
The ZUC-256 Stream Cipher<http://www.is.cas.cn/ztzl2016/zouchongzhi/201801/W020180126529970733243.pdf>
The ZUC-256 Stream Cipher 5 3. X 2 = s 7L ks 5H 4. X 3 = s 2L ks 0H, where s iH is the high 16 bits of the cell s i and s jL is the low 16 bits of the cell s j. F(X 0;X 1;X 2) 1. W = (X 0 R 1) R 2 2. W 1 = R 1 X 1 3. W 2 = R 2 X 2 4. R 1 = S(L 1(W 1L kW 2H)) 5. R 2 = S(L 2(W 2L kW 1H)), where S = (S 0;S 1;S 0;S 1) is the 4 parallel S-boxes which are the same as those used in the previous ZUC ...
www.is.cas.cn
Could you please check if these vectors work in your platform.
Regards
Sagar
________________________________
From: Vidya Sagar Velumuri <vvelumuri@marvell.com>
Sent: 01 November 2021 15:53
To: De Lara Guarch, Pablo <pablo.de.lara.guarch@intel.com>; Ankur Dwivedi <adwivedi@marvell.com>; Anoob Joseph <anoobj@marvell.com>; Tejasree Kondoj <ktejasree@marvell.com>; Nithin Kumar Dabilpuram <ndabilpuram@marvell.com>; Akhil Goyal <gakhil@marvell.com>; Doherty, Declan <declan.doherty@intel.com>
Cc: dev@dpdk.org <dev@dpdk.org>
Subject: Re: [dpdk-dev] [PATCH v1] test/crypto: fix: test vectors for zuc 256 bit key
Hi Pablo,
Verified with updated test vector. the output did not change from previous output but also, it did not match the ouput present in the vector.
Regards
Sagar
________________________________
From: De Lara Guarch, Pablo <pablo.de.lara.guarch@intel.com>
Sent: 01 November 2021 03:36
To: Vidya Sagar Velumuri <vvelumuri@marvell.com>; Ankur Dwivedi <adwivedi@marvell.com>; Anoob Joseph <anoobj@marvell.com>; Tejasree Kondoj <ktejasree@marvell.com>; Nithin Kumar Dabilpuram <ndabilpuram@marvell.com>; Akhil Goyal <gakhil@marvell.com>; Doherty, Declan <declan.doherty@intel.com>
Cc: dev@dpdk.org <dev@dpdk.org>
Subject: [EXT] RE: [dpdk-dev] [PATCH v1] test/crypto: fix: test vectors for zuc 256 bit key
External Email
________________________________
Hi Sagar,
Thanks for flagging this. I submitted a patch fixing the IV of the test vectors I pushed (it didn’t change the output):
http://patches.dpdk.org/project/dpdk/patch/20211031220421.52181-1-pablo.de.lara.guarch@intel.com/<https://urldefense.proofpoint.com/v2/url?u=http-3A__patches.dpdk.org_project_dpdk_patch_20211031220421.52181-2D1-2Dpablo.de.lara.guarch-40intel.com_&d=DwMFAg&c=nKjWec2b6R0mOyPaz7xtfQ&r=9VCCg7VNdg-jfzaFw1fN59x7Py9yM-ofwvekNj6MPxM&m=2eElny5n4QewacnppQimeCdeyB6B6GXxfdF4oet4KAlTXpwgcfhUF0Z3q2Ph4evt&s=pputaMk4g9cVhsjiJ1euKMLuGx24bIVTDh0AA4WrKwI&e=>
Could you check if they work for you?
Thanks,
Pablo
From: Vidya Sagar Velumuri <vvelumuri@marvell.com>
Sent: Saturday, October 30, 2021 1:26 PM
To: De Lara Guarch, Pablo <pablo.de.lara.guarch@intel.com>; Ankur Dwivedi <adwivedi@marvell.com>; Anoob Joseph <anoobj@marvell.com>; Tejasree Kondoj <ktejasree@marvell.com>; Nithin Kumar Dabilpuram <ndabilpuram@marvell.com>; Akhil Goyal <gakhil@marvell.com>; Doherty, Declan <declan.doherty@intel.com>
Cc: dev@dpdk.org
Subject: Re: [dpdk-dev] [PATCH v1] test/crypto: fix: test vectors for zuc 256 bit key
Hi Pablo,
Tried the test vector zuc256_test_case_auth_1 and the digest did not match with the generated digest in our platform.
As per spec, IV[i] for i = 17 to\x14 24 are 6-bit string occupying the 6 least signi cant bits of a byte.
But in the vectors, The values in the IV(byte -17 to 24) are > 0x3f.
Could you please elaborate how these bytes are considered for generation of digest.
Regards
Sagar
________________________________
From: De Lara Guarch, Pablo <pablo.de.lara.guarch@intel.com<mailto:pablo.de.lara.guarch@intel.com>>
Sent: 29 October 2021 18:07
To: Vidya Sagar Velumuri <vvelumuri@marvell.com<mailto:vvelumuri@marvell.com>>; Ankur Dwivedi <adwivedi@marvell.com<mailto:adwivedi@marvell.com>>; Anoob Joseph <anoobj@marvell.com<mailto:anoobj@marvell.com>>; Tejasree Kondoj <ktejasree@marvell.com<mailto:ktejasree@marvell.com>>; Nithin Kumar Dabilpuram <ndabilpuram@marvell.com<mailto:ndabilpuram@marvell.com>>; Akhil Goyal <gakhil@marvell.com<mailto:gakhil@marvell.com>>; Doherty, Declan <declan.doherty@intel.com<mailto:declan.doherty@intel.com>>
Cc: dev@dpdk.org<mailto:dev@dpdk.org> <dev@dpdk.org<mailto:dev@dpdk.org>>
Subject: [EXT] RE: [dpdk-dev] [PATCH v1] test/crypto: fix: test vectors for zuc 256 bit key
External Email
----------------------------------------------------------------------
Hi Vidya,
> -----Original Message-----
> From: dev <dev-bounces@dpdk.org<mailto:dev-bounces@dpdk.org>> On Behalf Of Vidya Sagar Velumuri
> Sent: Wednesday, October 27, 2021 9:41 AM
> To: adwivedi@marvell.com<mailto:adwivedi@marvell.com>; anoobj@marvell.com<mailto:anoobj@marvell.com>; ktejasree@marvell.com<mailto:ktejasree@marvell.com>;
> ndabilpuram@marvell.com<mailto:ndabilpuram@marvell.com>; gakhil@marvell.com<mailto:gakhil@marvell.com>; Doherty, Declan
> <declan.doherty@intel.com<mailto:declan.doherty@intel.com>>
> Cc: dev@dpdk.org<mailto:dev@dpdk.org>
> Subject: [dpdk-dev] [PATCH v1] test/crypto: fix: test vectors for zuc 256 bit key
>
> Fix the IV and MAC in the test vectors added for zuc 256-bit key
>
> Fixes: fa5bf9345d4e (test/crypto: add ZUC cases with 256-bit keys)
>
> Signed-off-by: Vidya Sagar Velumuri <vvelumuri@marvell.com<mailto:vvelumuri@marvell.com>>
The new vectors are failing for us. Could you check if the ones we added work for you?
Thanks,
Pablo
next prev parent reply other threads:[~2021-11-02 4:40 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-10-27 8:40 Vidya Sagar Velumuri
2021-10-28 7:10 ` Akhil Goyal
2021-10-29 12:37 ` De Lara Guarch, Pablo
2021-10-30 12:25 ` Vidya Sagar Velumuri
2021-10-31 22:06 ` De Lara Guarch, Pablo
2021-11-01 10:23 ` Vidya Sagar Velumuri
2021-11-02 4:40 ` Vidya Sagar Velumuri [this message]
2021-11-02 11:17 ` De Lara Guarch, Pablo
2021-11-03 6:55 ` [dpdk-dev] [PATCH v2] " Vidya Sagar Velumuri
2021-11-03 9:28 ` De Lara Guarch, Pablo
2021-11-03 9:31 ` [dpdk-dev] [PATCH v3] " Vidya Sagar Velumuri
2021-11-04 10:52 ` Akhil Goyal
2021-11-04 12:18 ` De Lara Guarch, Pablo
2021-11-04 18:38 ` Akhil Goyal
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=BY3PR18MB462888035FC79E5F31ACEA45A78B9@BY3PR18MB4628.namprd18.prod.outlook.com \
--to=vvelumuri@marvell.com \
--cc=adwivedi@marvell.com \
--cc=anoobj@marvell.com \
--cc=declan.doherty@intel.com \
--cc=dev@dpdk.org \
--cc=gakhil@marvell.com \
--cc=ktejasree@marvell.com \
--cc=ndabilpuram@marvell.com \
--cc=pablo.de.lara.guarch@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).