From: Dariusz Sosnowski <dsosnowski@nvidia.com>
To: Ferruh Yigit <ferruh.yigit@intel.com>, Ori Kam <orika@nvidia.com>,
Xiaoyun Li <xiaoyun.li@intel.com>,
Aman Singh <aman.deep.singh@intel.com>,
Yuying Zhang <yuying.zhang@intel.com>
Cc: "dev@dpdk.org" <dev@dpdk.org>, Slava Ovsiienko <viacheslavo@nvidia.com>
Subject: RE: [PATCH] app/testpmd: register metadata dynfield on modify field
Date: Wed, 9 Mar 2022 11:50:35 +0000 [thread overview]
Message-ID: <BY5PR12MB422769CD49FDE5C1EEC11575A40A9@BY5PR12MB4227.namprd12.prod.outlook.com> (raw)
In-Reply-To: <254404e0-2882-3eff-2820-74063660a23b@intel.com>
Hi Ferruh,
> -----Original Message-----
> From: Ferruh Yigit <ferruh.yigit@intel.com>
> Sent: Thursday, March 3, 2022 13:21
> To: Dariusz Sosnowski <dsosnowski@nvidia.com>; Ori Kam
> <orika@nvidia.com>; Xiaoyun Li <xiaoyun.li@intel.com>; Aman Singh
> <aman.deep.singh@intel.com>; Yuying Zhang <yuying.zhang@intel.com>
> Cc: dev@dpdk.org; Slava Ovsiienko <viacheslavo@nvidia.com>
> Subject: Re: [PATCH] app/testpmd: register metadata dynfield on modify
> field
>
> External email: Use caution opening links or attachments
>
>
> On 3/1/2022 11:51 AM, Dariusz Sosnowski wrote:
> > This patch adds implicit registration of metadata dynamic field and
> > flag
>
> Hi Dariusz,
>
> metaday dynamic field is explicitly registered when testpmd command used
> to enable tx metadata, or rte flow rule created with "set_meta" action.
>
> Can you please document more when this implicit enablement is required?
> And why that case doesn't cover above explicit enable cases?
Before this patch, when a user inserted a flow rule with MODIFY_FIELD action,
which modified packet metadata, the metadata dynamic field was not registered, as opposed to
what happened with SET_META action. Goal of this patch is to make the behavior consistent
between these two actions.
Maybe using "implicit" in the commit message was misleading here.
What do you think about rewording the commit message to something like the one below?
"This patch adds registration of metadata dynamic field and flag
whenever a MODIFY_FIELD action with META as source and/or destination
field is used. It makes the behavior consistent with SET_META action, where
metadata dynamic field and flag is registered on flow rule creation."
> > whenever a modify_field action with META as source and/or destination
> > field is used.
> >
>
> According below code it is only registered in the DST_TYPE block, not is 'else'
> (which seems src) leg, is this OK?
>
> > Signed-off-by: Dariusz Sosnowski <dsosnowski@nvidia.com>
> > Reviewed-by: Viacheslav Ovsiienko <viacheslavo@nvidia.com>
> > ---
> > app/test-pmd/cmdline_flow.c | 11 +++++++++--
> > 1 file changed, 9 insertions(+), 2 deletions(-)
> >
> > diff --git a/app/test-pmd/cmdline_flow.c b/app/test-pmd/cmdline_flow.c
> > index 4f7a9f17f9..dd38a635b0 100644
> > --- a/app/test-pmd/cmdline_flow.c
> > +++ b/app/test-pmd/cmdline_flow.c
> > @@ -8347,6 +8347,7 @@ parse_vc_modify_field_id(struct context *ctx,
> const struct token *token,
> > {
> > struct rte_flow_action_modify_field *action_modify_field;
> > unsigned int i;
> > + int ret;
> >
> > (void)token;
> > (void)buf;
> > @@ -8362,9 +8363,15 @@ parse_vc_modify_field_id(struct context *ctx,
> const struct token *token,
> > if (!ctx->object)
> > return len;
> > action_modify_field = ctx->object;
> > - if (ctx->curr == ACTION_MODIFY_FIELD_DST_TYPE_VALUE)
> > + if (ctx->curr == ACTION_MODIFY_FIELD_DST_TYPE_VALUE) {
> > action_modify_field->dst.field = (enum rte_flow_field_id)i;
> > - else
> > + if (action_modify_field->dst.field == RTE_FLOW_FIELD_META) {
> > + ret = rte_flow_dynf_metadata_register();
> > + if (ret < 0)
> > + return -1;
> > + }
> > +
> > + } else
> > action_modify_field->src.field = (enum rte_flow_field_id)i;
> > return len;
> > }
No, I should add registering for source field as well.
Best regards,
Dariusz Sosnowski
next prev parent reply other threads:[~2022-03-09 11:50 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-03-01 11:51 Dariusz Sosnowski
2022-03-03 12:20 ` Ferruh Yigit
2022-03-09 11:50 ` Dariusz Sosnowski [this message]
2022-03-14 20:42 ` Thomas Monjalon
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=BY5PR12MB422769CD49FDE5C1EEC11575A40A9@BY5PR12MB4227.namprd12.prod.outlook.com \
--to=dsosnowski@nvidia.com \
--cc=aman.deep.singh@intel.com \
--cc=dev@dpdk.org \
--cc=ferruh.yigit@intel.com \
--cc=orika@nvidia.com \
--cc=viacheslavo@nvidia.com \
--cc=xiaoyun.li@intel.com \
--cc=yuying.zhang@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).