From: Jeremy Spewock <jspewock@iol.unh.edu>
To: "Juraj Linkeš" <juraj.linkes@pantheon.tech>
Cc: thomas@monjalon.net, Honnappa.Nagarahalli@arm.com,
lijuan.tu@intel.com, probb@iol.unh.edu, dev@dpdk.org
Subject: Re: [PATCH v2 0/6] dts: tg abstractions and scapy tg
Date: Tue, 18 Jul 2023 17:04:16 -0400 [thread overview]
Message-ID: <CAAA20UR8-kQ-Pves8upaM5FXFvSV5XE3Yo9-rwAmajHPzLnShw@mail.gmail.com> (raw)
In-Reply-To: <20230717110709.39220-1-juraj.linkes@pantheon.tech>
[-- Attachment #1: Type: text/plain, Size: 3254 bytes --]
This looked good to me, just a couple of minor comments (about docstrings
and their format) and one question that I left. Once this is rebased on the
newer version of my patch it should be good.
On Mon, Jul 17, 2023 at 7:07 AM Juraj Linkeš <juraj.linkes@pantheon.tech>
wrote:
> Add abstractions for traffic generator split into those that can and
> can't capture traffic.
>
> The Scapy implementation uses an XML-RPC server for remote control. This
> requires an interactive session to add Scapy funcions to the server. The
> interactive session code is based on another patch [0].
>
> The basic test case is there to showcase the Scapy implementation - it
> sends just one UDP packet and verifies it on the other end.
>
> [0]:
> http://patches.dpdk.org/project/dpdk/patch/20230713165347.21997-3-jspewock@iol.unh.edu/
>
> Juraj Linkeš (6):
> dts: add scapy dependency
> dts: add traffic generator config
> dts: traffic generator abstractions
> dts: add python remote interactive shell
> dts: scapy traffic generator implementation
> dts: add basic UDP test case
>
> doc/guides/tools/dts.rst | 31 ++
> dts/conf.yaml | 27 +-
> dts/framework/config/__init__.py | 115 ++++---
> dts/framework/config/conf_yaml_schema.json | 32 +-
> dts/framework/dts.py | 65 ++--
> dts/framework/remote_session/__init__.py | 3 +-
> dts/framework/remote_session/linux_session.py | 96 ++++++
> dts/framework/remote_session/os_session.py | 75 +++--
> .../remote_session/remote/__init__.py | 1 +
> .../remote/interactive_shell.py | 18 +-
> .../remote_session/remote/python_shell.py | 24 ++
> .../remote_session/remote/testpmd_shell.py | 33 +-
> dts/framework/test_suite.py | 221 ++++++++++++-
> dts/framework/testbed_model/__init__.py | 1 +
> .../capturing_traffic_generator.py | 135 ++++++++
> dts/framework/testbed_model/hw/port.py | 60 ++++
> dts/framework/testbed_model/node.py | 64 +++-
> dts/framework/testbed_model/scapy.py | 290 ++++++++++++++++++
> dts/framework/testbed_model/sut_node.py | 52 ++--
> dts/framework/testbed_model/tg_node.py | 99 ++++++
> .../testbed_model/traffic_generator.py | 72 +++++
> dts/framework/utils.py | 13 +
> dts/poetry.lock | 21 +-
> dts/pyproject.toml | 1 +
> dts/tests/TestSuite_os_udp.py | 45 +++
> dts/tests/TestSuite_smoke_tests.py | 6 +-
> 26 files changed, 1434 insertions(+), 166 deletions(-)
> create mode 100644 dts/framework/remote_session/remote/python_shell.py
> create mode 100644
> dts/framework/testbed_model/capturing_traffic_generator.py
> create mode 100644 dts/framework/testbed_model/hw/port.py
> create mode 100644 dts/framework/testbed_model/scapy.py
> create mode 100644 dts/framework/testbed_model/tg_node.py
> create mode 100644 dts/framework/testbed_model/traffic_generator.py
> create mode 100644 dts/tests/TestSuite_os_udp.py
>
> --
> 2.34.1
>
>
[-- Attachment #2: Type: text/html, Size: 4053 bytes --]
next prev parent reply other threads:[~2023-07-18 21:04 UTC|newest]
Thread overview: 29+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-04-20 9:31 [RFC PATCH v1 0/5] dts: add tg abstractions and scapy Juraj Linkeš
2023-04-20 9:31 ` [RFC PATCH v1 1/5] dts: add scapy dependency Juraj Linkeš
2023-04-20 9:31 ` [RFC PATCH v1 2/5] dts: add traffic generator config Juraj Linkeš
2023-04-20 9:31 ` [RFC PATCH v1 3/5] dts: traffic generator abstractions Juraj Linkeš
2023-04-20 9:31 ` [RFC PATCH v1 4/5] dts: scapy traffic generator implementation Juraj Linkeš
2023-04-20 9:31 ` [RFC PATCH v1 5/5] dts: add traffic generator node to dts runner Juraj Linkeš
2023-05-03 18:02 ` Jeremy Spewock
2023-07-17 11:07 ` [PATCH v2 0/6] dts: tg abstractions and scapy tg Juraj Linkeš
2023-07-17 11:07 ` [PATCH v2 1/6] dts: add scapy dependency Juraj Linkeš
2023-07-17 11:07 ` [PATCH v2 2/6] dts: add traffic generator config Juraj Linkeš
2023-07-18 15:55 ` Jeremy Spewock
2023-07-19 12:57 ` Juraj Linkeš
2023-07-19 13:18 ` Jeremy Spewock
2023-07-17 11:07 ` [PATCH v2 3/6] dts: traffic generator abstractions Juraj Linkeš
2023-07-18 19:56 ` Jeremy Spewock
2023-07-19 13:23 ` Juraj Linkeš
2023-07-17 11:07 ` [PATCH v2 4/6] dts: add python remote interactive shell Juraj Linkeš
2023-07-17 11:07 ` [PATCH v2 5/6] dts: scapy traffic generator implementation Juraj Linkeš
2023-07-17 11:07 ` [PATCH v2 6/6] dts: add basic UDP test case Juraj Linkeš
2023-07-18 21:04 ` Jeremy Spewock [this message]
2023-07-19 14:12 ` [PATCH v3 0/6] dts: tg abstractions and scapy tg Juraj Linkeš
2023-07-19 14:12 ` [PATCH v3 1/6] dts: add scapy dependency Juraj Linkeš
2023-07-19 14:12 ` [PATCH v3 2/6] dts: add traffic generator config Juraj Linkeš
2023-07-19 14:13 ` [PATCH v3 3/6] dts: traffic generator abstractions Juraj Linkeš
2023-07-19 14:13 ` [PATCH v3 4/6] dts: add python remote interactive shell Juraj Linkeš
2023-07-19 14:13 ` [PATCH v3 5/6] dts: scapy traffic generator implementation Juraj Linkeš
2023-07-19 14:13 ` [PATCH v3 6/6] dts: add basic UDP test case Juraj Linkeš
2023-07-20 15:21 ` Jeremy Spewock
2023-07-24 14:23 ` [PATCH v3 0/6] dts: tg abstractions and scapy tg Thomas Monjalon
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CAAA20UR8-kQ-Pves8upaM5FXFvSV5XE3Yo9-rwAmajHPzLnShw@mail.gmail.com \
--to=jspewock@iol.unh.edu \
--cc=Honnappa.Nagarahalli@arm.com \
--cc=dev@dpdk.org \
--cc=juraj.linkes@pantheon.tech \
--cc=lijuan.tu@intel.com \
--cc=probb@iol.unh.edu \
--cc=thomas@monjalon.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).