From: Alejandro Lucero <alejandro.lucero@netronome.com>
To: Olivier Matz <olivier.matz@6wind.com>
Cc: Ferruh Yigit <ferruh.yigit@intel.com>, dev <dev@dpdk.org>
Subject: Re: [dpdk-dev] [PATCH] net/nfp: fix Vlan offload flags check
Date: Fri, 13 Jan 2017 14:57:47 +0000 [thread overview]
Message-ID: <CAD+H993rSwxCyKQBF=PQdp_SCe-tyx72yprNXYJO=qtTNjk9JA@mail.gmail.com> (raw)
In-Reply-To: <20170113154802.6166e529@platinum>
I was assuming in my acked answer, that the patch had followed usual path
and automatic compilation did not fail.
But I forgot about the NFP PMD not being enabled by default :-)
Hopefully, this will change if this just sent patch is accepted:
http://www.dpdk.org/ml/archives/dev/2017-January/054890.html
By other hand, I have compiled the NFP PMD with this patch and it works.
So acked again.
Thanks
On Fri, Jan 13, 2017 at 2:48 PM, Olivier Matz <olivier.matz@6wind.com>
wrote:
> On Fri, 13 Jan 2017 13:17:17 +0000, Ferruh Yigit
> <ferruh.yigit@intel.com> wrote:
> > On 1/13/2017 12:48 PM, Olivier Matz wrote:
> > > On Fri, 13 Jan 2017 12:03:01 +0000, Ferruh Yigit
> > > <ferruh.yigit@intel.com> wrote:
> > >> On 1/12/2017 1:04 PM, Olivier Matz wrote:
> > >>> Fix typo when checking that no Vlan offload flags are passed at
> > >>> port initialization.
> > >>>
> > >>> By the way, also fix a typo in the log.
> > >>>
> > >>> Fixes: d4a27a3b092a ("nfp: add basic features")
> > >>>
> > >>> Signed-off-by: Olivier Matz <olivier.matz@6wind.com>
> > >>> ---
> >
> > <...>
> >
> > >
> > >
> > > I'll submit another patch with ETH_VLAN_EXTEND_OFFLOAD.
> >
> > If this will be the only change, I can update it if you want:
> >
> > - (mask & ETH_VLAN_FILTER_OFFLOAD))
> > - RTE_LOG(INFO, PMD, "Not support for ETH_VLAN_FILTER_OFFLOAD
> > or"
> > - " ETH_VLAN_FILTER_EXTEND");
> > + (mask & ETH_VLAN_EXTEND_OFFLOAD))
> > + RTE_LOG(INFO, PMD, "No support for ETH_VLAN_FILTER_OFFLOAD or"
> > + " ETH_VLAN_EXTEND_OFFLOAD");
> >
>
> Looks good to me, thank you.
>
> Olivier
>
next prev parent reply other threads:[~2017-01-13 14:57 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-01-12 13:04 Olivier Matz
2017-01-13 11:36 ` Alejandro Lucero
2017-01-13 12:03 ` Ferruh Yigit
2017-01-13 12:48 ` Olivier Matz
2017-01-13 13:17 ` Ferruh Yigit
2017-01-13 14:48 ` Olivier Matz
2017-01-13 14:57 ` Alejandro Lucero [this message]
2017-01-13 15:16 ` [dpdk-dev] [PATCH] net/nfp: fix VLAN " Ferruh Yigit
2017-01-13 15:18 ` Ferruh Yigit
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CAD+H993rSwxCyKQBF=PQdp_SCe-tyx72yprNXYJO=qtTNjk9JA@mail.gmail.com' \
--to=alejandro.lucero@netronome.com \
--cc=dev@dpdk.org \
--cc=ferruh.yigit@intel.com \
--cc=olivier.matz@6wind.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).