From: Igor Ryzhov <iryzhov@nfware.com>
To: Ferruh Yigit <ferruh.yigit@intel.com>
Cc: Stephen Hemminger <stephen@networkplumber.org>, dev@dpdk.org
Subject: Re: [dpdk-dev] [PATCH v2] kni: use kni_ethtool_ops only with unknown drivers
Date: Sat, 5 Jan 2019 19:53:34 +0300 [thread overview]
Message-ID: <CAF+s_Fw5rdZK8Ena27iLm3rt8s4_XoOGzM_J=WRqwKGKqZdPPg@mail.gmail.com> (raw)
In-Reply-To: <7eab0eec-335a-be47-2406-9c989d13e981@intel.com>
Hi Ferruh,
Thank you for all your comments.
The only real purpose of the patch is to support .get_link for all KNI
interfaces, not just for those using igb or ixgbe.
So I propose to remove ethtool support at all with your patch, and after
that, I will add .get_link support again.
Yes, I understand that it doesn't implement real link status support, it
just relies on the application, that should set link status using sysfs.
Regarding the ethtool support in a driver-independent way – the idea is to
use the same req/resp queues
which are used for some net_device_ops like .ndo_change_mtu or
.ndo_set_mac_address.
I want to add more types of requests to rte_kni_req_id enum and implement
them.
It's not an urgent task, so I don't know yet when I'll find time to do it.
Best regards,
Igor
On Tue, Dec 18, 2018 at 9:13 PM Ferruh Yigit <ferruh.yigit@intel.com> wrote:
> On 12/3/2018 2:06 PM, Igor Ryzhov wrote:
> > Hi Ferruh,
> >
> > What about the patch?
> >
> > I also support dropping ethtool for ixgbe and i40e, but to save generic
> ethtool_ops
> > with .get_link implementation, because it's an essential function that
> works
> > correctly
> > after proper implementation of carrier status that was merged into 18.11.
> >
> > Also, other ethtool operations may be implemented in a
> driver-independent way using
> > the same concept as for netdev_ops.
>
> "carrier status" relies on the sample app support also relies on kni
> net_device
> sysfs interface.
> It is good target to have ethtool support in a driver-independent way,
> please
> share more details and lets discuss them.
>
> >
> > On Mon, Dec 3, 2018 at 4:09 PM Ferruh Yigit <ferruh.yigit@intel.com
> > <mailto:ferruh.yigit@intel.com>> wrote:
> >
> > On 11/30/2018 11:38 PM, Stephen Hemminger wrote:
> > > On Fri, 30 Nov 2018 22:47:50 +0300
> > > Igor Ryzhov <iryzhov@nfware.com <mailto:iryzhov@nfware.com>>
> wrote:
> > >
> > >> Current implementation of kni_ethtool_ops just uses corresponding
> > >> ethtool_ops function of underlying driver for all functions
> except for
> > >> .get_link. This commit sets kni->net_dev->ethtool_ops directly to
> the
> > >> ethtool_ops of the corresponding driver.
> > >>
> > >> For unknown drivers (all but ixgbe and i40e) we still use
> > >> kni_ethtool_ops with implemented .get_link function.
> > >>
> > >> Signed-off-by: Igor Ryzhov <iryzhov@nfware.com <mailto:
> iryzhov@nfware.com>>
> > >
> > > Why does KNI still support ethtool which:
> > > 1. Only works on a subset of devices
> > > 2. Requires a 3rd implmentation of the HW device (Linux, DPDK,
> and KNI)
> >
> > +1 to drop ethtool support, last time we tried concern was anybody
> may be using
> > it, perhaps we can try again.
> >
> > >
> > > Then again why does KNI exist at all? What is missing from virtio
> user which
> > > is faster anyway.
> > >
> >
>
>
next prev parent reply other threads:[~2019-01-05 16:53 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-11-30 19:29 [dpdk-dev] [PATCH] " Igor Ryzhov
2018-11-30 19:47 ` [dpdk-dev] [PATCH v2] " Igor Ryzhov
2018-11-30 23:38 ` Stephen Hemminger
2018-12-01 11:12 ` Igor Ryzhov
2018-12-01 17:31 ` Stephen Hemminger
2018-12-02 10:54 ` Igor Ryzhov
2018-12-03 19:51 ` Stephen Hemminger
2018-12-18 18:10 ` Ferruh Yigit
2018-12-03 13:09 ` Ferruh Yigit
2018-12-03 14:06 ` Igor Ryzhov
2018-12-18 18:13 ` Ferruh Yigit
2019-01-05 16:53 ` Igor Ryzhov [this message]
2018-12-18 18:04 ` Ferruh Yigit
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CAF+s_Fw5rdZK8Ena27iLm3rt8s4_XoOGzM_J=WRqwKGKqZdPPg@mail.gmail.com' \
--to=iryzhov@nfware.com \
--cc=dev@dpdk.org \
--cc=ferruh.yigit@intel.com \
--cc=stephen@networkplumber.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).