From: Usman Tanveer <usman.tanveer@emumba.com>
To: Stephen Hemminger <stephen@networkplumber.org>
Cc: reshma.pattan@intel.com, dev@dpdk.org
Subject: Re: [PATCH] app/pdump: close program if --pdump argument is missing
Date: Thu, 31 Mar 2022 17:59:03 +0500 [thread overview]
Message-ID: <CAH_O0bzxbAe87Yxm592N13xfmjzrW-zYMsef_Vq7rD1+iR1HEw@mail.gmail.com> (raw)
In-Reply-To: <20220302085225.117b8570@hermes.local>
The 20.11 release is not coming out till August, in the meantime, this
patch can be applied to print help if mandatory argument is not
passed.
On Wed, Mar 2, 2022 at 9:52 PM Stephen Hemminger
<stephen@networkplumber.org> wrote:
>
> On Wed, 2 Mar 2022 14:26:14 +0500
> "usman.tanveer" <usman.tanveer@emumba.com> wrote:
>
> > --pdump is a mandatory argument in pdump application.
> > It should print usage and exit if --pdump argument
> > is missing. The application is not closing and getting
> > stuck. Made the change to print usage and exit when
> > this argument is missing.
> >
> > Signed-off-by: usman.tanveer <usman.tanveer@emumba.com>
>
> Maybe pdump could just do something sane with no arguments.
> That is one of the issues I tried to address by rewriting it.
>
> Ideally, existing pdump can be deprecated and removed in 22.11?
next prev parent reply other threads:[~2022-03-31 12:59 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-03-02 9:26 usman.tanveer
2022-03-02 16:52 ` Stephen Hemminger
2022-03-31 12:59 ` Usman Tanveer [this message]
2023-07-01 2:16 ` [PATCH v2] app/pdump: exit if no device specified Stephen Hemminger
2023-07-03 6:29 ` fengchengwen
2023-07-06 10:45 ` Thomas Monjalon
-- strict thread matches above, loose matches on Subject: below --
2022-03-02 9:20 [PATCH] app/pdump: close program if --pdump argument is missing usman.tanveer
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CAH_O0bzxbAe87Yxm592N13xfmjzrW-zYMsef_Vq7rD1+iR1HEw@mail.gmail.com \
--to=usman.tanveer@emumba.com \
--cc=dev@dpdk.org \
--cc=reshma.pattan@intel.com \
--cc=stephen@networkplumber.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).