From: David Marchand <david.marchand@redhat.com>
To: Aaron Conole <aconole@redhat.com>, Thomas Monjalon <thomas@monjalon.net>
Cc: dev <dev@dpdk.org>, Michael Santana <maicolgabriel@hotmail.com>
Subject: Re: [PATCH] ci: run more checks in private repositories
Date: Thu, 28 Apr 2022 14:12:50 +0200 [thread overview]
Message-ID: <CAJFAV8wU2jHNjjiG-_yzvk32nEYX5_nnxjM9uLN7_NzokJiGJw@mail.gmail.com> (raw)
In-Reply-To: <f7tsfr69k6x.fsf@redhat.com>
On Fri, Mar 25, 2022 at 3:32 PM Aaron Conole <aconole@redhat.com> wrote:
> David Marchand <david.marchand@redhat.com> writes:
>
> > Though devtools/checkpatches.sh is run as part of our CI, some other
> > (not well known) checks could help when run in private repositories
> > before submitting to the mailing list and even when run from the
> > ovsrobot.
> >
> > Most of them require a git history or checked sources to run.
> > And I can't guarantee there won't be false positives.
> >
> > Add a new job just for those checks so that it won't block compilation
> > tests in other jobs.
> >
> > Signed-off-by: David Marchand <david.marchand@redhat.com>
> > ---
>
> Looks good to me. The extra fetches shouldn't take too long (since we
> refresh main branch weekly to the robot repository). The checks look
> good - and since it's part of the same build workflow, it will be
> reported in the same place (and hopefully in a readable form).
Thanks for the review.
Thomas expressed a concern that the check-git-log.sh script has too
many false positives.
I will respin removing this check.
--
David Marchand
prev parent reply other threads:[~2022-04-28 12:13 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-03-24 14:53 David Marchand
2022-03-25 14:32 ` Aaron Conole
2022-04-28 12:12 ` David Marchand [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CAJFAV8wU2jHNjjiG-_yzvk32nEYX5_nnxjM9uLN7_NzokJiGJw@mail.gmail.com \
--to=david.marchand@redhat.com \
--cc=aconole@redhat.com \
--cc=dev@dpdk.org \
--cc=maicolgabriel@hotmail.com \
--cc=thomas@monjalon.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).