From: David Marchand <david.marchand@redhat.com>
To: Daniel Gregory <daniel.gregory@bytedance.com>
Cc: Ruifeng Wang <ruifeng.wang@arm.com>,
dev@dpdk.org, Punit Agrawal <punit.agrawal@bytedance.com>,
Liang Ma <liangma@bytedance.com>
Subject: Re: [PATCH] eal/arm: replace RTE_BUILD_BUG on non-constant
Date: Fri, 3 May 2024 15:32:20 +0200 [thread overview]
Message-ID: <CAJFAV8x=vHEn2ezKBSTrKJGxYwDe_DKv7s26_4FVBHxiqQmcvg@mail.gmail.com> (raw)
In-Reply-To: <20240502142116.63760-1-daniel.gregory@bytedance.com>
On Thu, May 2, 2024 at 4:22 PM Daniel Gregory
<daniel.gregory@bytedance.com> wrote:
>
> The ARM implementation of rte_pause uses RTE_BUILD_BUG_ON to check
> memorder, which is not constant. This causes compile errors when it is
> enabled with RTE_ARM_USE_WFE. eg.
>
> ../lib/eal/arm/include/rte_pause_64.h: In function ‘rte_wait_until_equal_16’:
> ../lib/eal/include/rte_common.h:530:56: error: expression in static assertion is not constant
> 530 | #define RTE_BUILD_BUG_ON(condition) do { static_assert(!(condition), #condition); } while (0)
> | ^~~~~~~~~~~~
> ../lib/eal/arm/include/rte_pause_64.h:156:9: note: in expansion of macro ‘RTE_BUILD_BUG_ON’
> 156 | RTE_BUILD_BUG_ON(memorder != rte_memory_order_acquire &&
> | ^~~~~~~~~~~~~~~~
>
> This has been the case since the switch to C11 assert (537caad2). Fix
> the compile errors by replacing the check with an RTE_ASSERT.
>
> Signed-off-by: Daniel Gregory <daniel.gregory@bytedance.com>
- RTE_BUILD_BUG_ON() should not be used indeed.
IIRC, this issue was introduced with 875f350924b8 ("eal: add a new
helper for wait until scheme").
Please add a corresponding Fixes: tag in next revision.
Rather than use RTE_ASSERT(), you can simply revert to a assert()
call, like what was done before this change (and this is what is done
for the non WFE/generic implementation too, see
lib/eal/include/generic/rte_pause.h).
- This ARM specific implementation should take a rte_memory_order type
instead of a int type for the memorder input variable.
This was missed in 1ec6a845b5cb ("eal: use stdatomic API in public headers").
Could you send a fix for this small issue too?
Thanks!
--
David Marchand
next prev parent reply other threads:[~2024-05-03 13:32 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-05-02 14:21 Daniel Gregory
2024-05-02 16:20 ` Stephen Hemminger
2024-05-02 17:44 ` Daniel Gregory
2024-05-02 18:27 ` Stephen Hemminger
2024-05-02 21:48 ` Stephen Hemminger
2024-05-03 9:46 ` Daniel Gregory
2024-05-04 0:56 ` Stephen Hemminger
2024-05-09 11:02 ` Daniel Gregory
2024-05-03 13:32 ` David Marchand [this message]
2024-05-03 14:21 ` Daniel Gregory
2024-05-03 18:27 ` [PATCH v2] " Daniel Gregory
2024-05-03 18:30 ` Daniel Gregory
2024-05-04 0:59 ` Stephen Hemminger
2024-05-06 9:30 ` Ruifeng Wang
2024-05-11 17:00 ` Wathsala Wathawana Vithanage
2024-05-04 1:02 ` [PATCH] " Stephen Hemminger
2024-05-09 11:11 ` Daniel Gregory
2024-05-09 16:47 ` Tyler Retzlaff
2024-05-11 16:48 ` Wathsala Wathawana Vithanage
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CAJFAV8x=vHEn2ezKBSTrKJGxYwDe_DKv7s26_4FVBHxiqQmcvg@mail.gmail.com' \
--to=david.marchand@redhat.com \
--cc=daniel.gregory@bytedance.com \
--cc=dev@dpdk.org \
--cc=liangma@bytedance.com \
--cc=punit.agrawal@bytedance.com \
--cc=ruifeng.wang@arm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).