DPDK patches and discussions
 help / color / mirror / Atom feed
From: David Marchand <david.marchand@redhat.com>
To: "Uttarwar, Sunil Prakashrao" <SunilPrakashrao.Uttarwar@amd.com>
Cc: "Yigit, Ferruh" <Ferruh.Yigit@amd.com>,
	Akhil Goyal <gakhil@marvell.com>,
	 "Namburu, Chandu-babu" <chandu@amd.com>,
	"Sebastian, Selwin" <Selwin.Sebastian@amd.com>,
	dev <dev@dpdk.org>,  Thomas Monjalon <thomas@monjalon.net>
Subject: Re: [PATCH v2 0/4] crypto/ccp cleanup
Date: Wed, 11 Jan 2023 16:14:15 +0100	[thread overview]
Message-ID: <CAJFAV8xVWEUN0iOGmevcodBNV-FB8wdxhG3YB3umrt-MaVyM6Q@mail.gmail.com> (raw)
In-Reply-To: <CY4PR1201MB01997229009A094EAFD7E80B92099@CY4PR1201MB0199.namprd12.prod.outlook.com>

On Fri, Nov 18, 2022 at 12:58 PM Uttarwar, Sunil Prakashrao
<SunilPrakashrao.Uttarwar@amd.com> wrote:
> Hi David,
>
> Please find the below update
>
> - only one DPDK application can use ccp crypto engines (PCI bus allow/blocklist is not respected, right?),
> Yes, only one crypto device can be used in a DPDK application for the crypto operations. This is introduced from the patch crypto/ccp: convert driver from vdev to PCI. This is implemented as per community suggestion.

Community suggested to have this driver a standard PCI driver, not a vdev one.
I don't remember anything about the limitation.
Can you point at the discussion that leaded to this?


>
> - since only one crypto device is exposed, there is no way for the application to dedicate/decide how to distribute crypto operations over the different ccp crypto engines available on the system.
>
> When there is no ccp device passed from the application dpdk-test-crypto-perf, it tries to probe all CCP devices present on a system and only one device can be used. It seems this is bug in the patch implemented for crypto/ccp: convert driver from vdev to PCI and we are looking into this.

Indeed.


So how should we proceed?
Patches 1 to 3 are ready and can be merged.

I don't mind dropping patch 4 if you have a better solution/alternative.


-- 
David Marchand


  reply	other threads:[~2023-01-11 15:14 UTC|newest]

Thread overview: 28+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-09-09 15:04 [PATCH " David Marchand
2022-09-09 15:04 ` [PATCH 1/4] crypto/ccp: remove some printf David Marchand
2022-09-09 15:04 ` [PATCH 2/4] crypto/ccp: remove some dead code for UIO David Marchand
2022-09-09 15:04 ` [PATCH 3/4] crypto/ccp: fix IOVA handling David Marchand
2022-09-09 15:04 ` [PATCH 4/4] crypto/ccp: fix PCI probing David Marchand
2022-10-04  9:51 ` [PATCH v2 0/4] crypto/ccp cleanup David Marchand
2022-10-04  9:51   ` [PATCH v2 1/4] crypto/ccp: remove some printf David Marchand
2023-01-13 11:58     ` Uttarwar, Sunil Prakashrao
2023-01-30 18:42     ` [EXT] " Akhil Goyal
2022-10-04  9:51   ` [PATCH v2 2/4] crypto/ccp: remove some dead code for UIO David Marchand
2023-01-13 12:00     ` Uttarwar, Sunil Prakashrao
2022-10-04  9:51   ` [PATCH v2 3/4] crypto/ccp: fix IOVA handling David Marchand
2023-01-13 12:00     ` Uttarwar, Sunil Prakashrao
2022-10-04  9:51   ` [PATCH v2 4/4] crypto/ccp: fix PCI probing David Marchand
2022-10-07  6:54   ` [EXT] [PATCH v2 0/4] crypto/ccp cleanup Akhil Goyal
2022-10-11 11:44   ` Uttarwar, Sunil Prakashrao
2022-10-13  9:40     ` Akhil Goyal
2022-10-17 13:42       ` Uttarwar, Sunil Prakashrao
2022-10-17 13:53         ` David Marchand
2022-10-26  6:21           ` David Marchand
     [not found]             ` <1ec3f0fc-631f-2aa6-70f7-7f9b96caa2a2@amd.com>
     [not found]               ` <CY4PR1201MB019989039CF117EE75F9025692399@CY4PR1201MB0199.namprd12.prod.outlook.com>
     [not found]                 ` <CAJFAV8xpZM96qDzaezO64LsRSdhWu8A2quCo8xGpufRrfjrMSw@mail.gmail.com>
     [not found]                   ` <CY4PR1201MB01992328892E48006952D3C892399@CY4PR1201MB0199.namprd12.prod.outlook.com>
2022-11-03 13:08                     ` David Marchand
2022-11-18 11:58                       ` Uttarwar, Sunil Prakashrao
2023-01-11 15:14                         ` David Marchand [this message]
2023-01-12 12:28                           ` Uttarwar, Sunil Prakashrao
2023-01-17 13:56                             ` Uttarwar, Sunil Prakashrao
2023-03-02 11:43 ` [PATCH v2] crypto/ccp: fix PCI probing David Marchand
2023-03-06 12:05   ` Uttarwar, Sunil Prakashrao
2023-03-11 18:49     ` Akhil Goyal

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=CAJFAV8xVWEUN0iOGmevcodBNV-FB8wdxhG3YB3umrt-MaVyM6Q@mail.gmail.com \
    --to=david.marchand@redhat.com \
    --cc=Ferruh.Yigit@amd.com \
    --cc=Selwin.Sebastian@amd.com \
    --cc=SunilPrakashrao.Uttarwar@amd.com \
    --cc=chandu@amd.com \
    --cc=dev@dpdk.org \
    --cc=gakhil@marvell.com \
    --cc=thomas@monjalon.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).