From: David Marchand <david.marchand@redhat.com>
To: Stephen Hemminger <stephen@networkplumber.org>
Cc: dev <dev@dpdk.org>, Aaron Conole <aconole@redhat.com>
Subject: Re: [dpdk-dev] [PATCH v2] eal: don't call RTE_LOG before init
Date: Wed, 16 Oct 2019 09:42:00 +0200 [thread overview]
Message-ID: <CAJFAV8yDFipA6kRHpPJYKGDGzddb=bhAE=bOEjarnv7o8Vktow@mail.gmail.com> (raw)
In-Reply-To: <20190919133107.14147-1-stephen@networkplumber.org>
On Thu, Sep 19, 2019 at 3:31 PM Stephen Hemminger
<stephen@networkplumber.org> wrote:
>
> rte_init_alert is called before rte_log is initialized.
rte_eal_init_alert*
> Therefore RTE_LOG() should not be used (only stderr).
There should be nothing disastrous when calling RTE_LOG() before
rte_eal_log_init has been called.
RTE_LOG -> rte_vlog with rte_logs.file == default_log_stream == NULL
=> it should end up writing to stderr in such a case.
And I understand this is the issue you wanted to fix because we write
the same messages twice on stderr.
>
> For VFIO, it is initialized after rte_log_init therefore,
> use RTE_LOG.
What about all the other calls after the vfio setup step?
Now with this change, they would only be passed to stderr even if the
log subsystem is initialised.
Can we have a "log initialised" boolean here and use it in rte_eal_init_alert?
>
> Signed-off-by: Stephen Hemminger <stephen@networkplumber.org>
> ---
> lib/librte_eal/linux/eal/eal.c | 3 +--
> 1 file changed, 1 insertion(+), 2 deletions(-)
>
> diff --git a/lib/librte_eal/linux/eal/eal.c b/lib/librte_eal/linux/eal/eal.c
> index 946222ccdb7a..6f54a8b2133f 100644
> --- a/lib/librte_eal/linux/eal/eal.c
> +++ b/lib/librte_eal/linux/eal/eal.c
> @@ -950,7 +950,6 @@ static int rte_eal_vfio_setup(void)
> static void rte_eal_init_alert(const char *msg)
> {
> fprintf(stderr, "EAL: FATAL: %s\n", msg);
> - RTE_LOG(ERR, EAL, "%s\n", msg);
> }
>
> /*
> @@ -1175,7 +1174,7 @@ rte_eal_init(int argc, char **argv)
>
> #ifdef VFIO_PRESENT
> if (rte_eal_vfio_setup() < 0) {
> - rte_eal_init_alert("Cannot init VFIO");
> + RTE_LOG(ERR, EAL, "Cannot init VFIO\n");
> rte_errno = EAGAIN;
> rte_atomic32_clear(&run_once);
> return -1;
> --
> 2.17.1
>
--
David Marchand
prev parent reply other threads:[~2019-10-16 7:42 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-08-20 23:33 [dpdk-dev] [PATCH] eal: remove redundant error output Stephen Hemminger
2019-08-21 13:04 ` Aaron Conole
2019-09-19 13:31 ` [dpdk-dev] [PATCH v2] eal: don't call RTE_LOG before init Stephen Hemminger
2019-10-16 7:42 ` David Marchand [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CAJFAV8yDFipA6kRHpPJYKGDGzddb=bhAE=bOEjarnv7o8Vktow@mail.gmail.com' \
--to=david.marchand@redhat.com \
--cc=aconole@redhat.com \
--cc=dev@dpdk.org \
--cc=stephen@networkplumber.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).