From: David Marchand <david.marchand@redhat.com>
To: Igor Russkikh <Igor.Russkikh@aquantia.com>
Cc: "dev@dpdk.org" <dev@dpdk.org>, Pavel Belous <Pavel.Belous@aquantia.com>
Subject: Re: [dpdk-dev] [PATCH 00/10] net/atlantic: bugfixes and code cleanup
Date: Mon, 4 Mar 2019 10:40:33 +0100 [thread overview]
Message-ID: <CAJFAV8yo9jr8-P4B48=KMr9tm2M4ZBJ_Hw2iN_=PS-5_Kb0xNQ@mail.gmail.com> (raw)
In-Reply-To: <cover.1551528549.git.igor.russkikh@aquantia.com>
On Sat, Mar 2, 2019 at 1:10 PM Igor Russkikh <Igor.Russkikh@aquantia.com>
wrote:
> The patchset mainly fixes some Coverity issues,
> couple of minor bugs and overflows.
>
> It also improves eeprom get/set logic with ability of custom
> device address and dump length.
>
> Igor Russkikh (7):
> net/atlantic: Fix negative error codes
> net/atlantic: remove unused variable
> net/atlantic: check for error codes
> net/atlantic: fix link configuration
> net/atlantic: eliminate excessive log levels on rx/tx
> net/atlantic: fix missing vlan filter offload
> net/atlantic: fix xstats to return correct number of requested items
>
> Pavel Belous (3):
> net/atlantic: fix buffer overflow
> net/atlantic: use eeprom magic as a device address
> net/atlantic: fix eeprom fetching for small and uneven lengths
>
> drivers/net/atlantic/atl_ethdev.c | 71 ++++++++++---------
> drivers/net/atlantic/atl_rxtx.c | 20 ++----
> drivers/net/atlantic/atl_types.h | 5 +-
> drivers/net/atlantic/hw_atl/hw_atl_b0.c | 6 +-
> drivers/net/atlantic/hw_atl/hw_atl_utils.c | 9 +--
> drivers/net/atlantic/hw_atl/hw_atl_utils.h | 23 +++---
> .../net/atlantic/hw_atl/hw_atl_utils_fw2x.c | 59 ++++++++++-----
> 7 files changed, 105 insertions(+), 88 deletions(-)
>
Those patches are missing Fixes: tags and copying stable where appropriate.
The commitlogs also need some work.
It looks like those patches were neither checked against checkpatch nor
check-git-log.sh.
Here is what I see (extended the max line length to 100 to avoid all those
80 columns warnings, but this is worth fixing as well).
[dmarchan@dmarchan dpdk]$ DPDK_CHECKPATCH_LINE_LENGTH=100
./devtools/checkpatches.sh
### net/atlantic: Fix negative error codes
WARNING:COMMIT_MESSAGE: Missing commit description - Add an appropriate one
total: 0 errors, 1 warnings, 0 checks, 14 lines checked
### net/atlantic: use eeprom magic as a device address
WARNING:LONG_LINE: line over 100 characters
#163: FILE: drivers/net/atlantic/hw_atl/hw_atl_utils_fw2x.c:134:
+ u32 val = rate_mask | ((BIT(CAPS_LO_SMBUS_READ) |
BIT(CAPS_LO_SMBUS_WRITE) | BIT(CAPS_LO_MACSEC)) & reg_val);
total: 0 errors, 1 warnings, 0 checks, 194 lines checked
### net/atlantic: fix eeprom fetching for small and uneven lengths
WARNING:COMMIT_MESSAGE: Missing commit description - Add an appropriate one
ERROR:POINTER_LOCATION: "(foo*)" should be "(foo *)"
#46: FILE: drivers/net/atlantic/hw_atl/hw_atl_utils_fw2x.c:558:
+ rte_memcpy((u8*)data + len - bytes_remains, &val,
bytes_remains);
total: 1 errors, 1 warnings, 0 checks, 36 lines checked
### net/atlantic: fix missing vlan filter offload
WARNING:COMMIT_MESSAGE: Missing commit description - Add an appropriate one
total: 0 errors, 1 warnings, 0 checks, 9 lines checked
### net/atlantic: fix xstats to return correct number of requested items
WARNING:COMMIT_MESSAGE: Missing commit description - Add an appropriate one
total: 0 errors, 1 warnings, 0 checks, 16 lines checked
5/10 valid patches
[dmarchan@dmarchan dpdk]$ ./devtools/check-git-log.sh
Wrong headline uppercase:
net/atlantic: Fix negative error codes
Wrong headline lowercase:
net/atlantic: use eeprom magic as a device address
net/atlantic: fix eeprom fetching for small and uneven lengths
net/atlantic: eliminate excessive log levels on rx/tx
net/atlantic: fix missing vlan filter offload
Headline too long:
net/atlantic: fix eeprom fetching for small and uneven lengths
net/atlantic: fix xstats to return correct number of requested items
Missing 'Fixes' tag:
net/atlantic: Fix negative error codes
net/atlantic: fix buffer overflow
net/atlantic: fix eeprom fetching for small and uneven lengths
net/atlantic: fix link configuration
net/atlantic: fix missing vlan filter offload
net/atlantic: fix xstats to return correct number of requested items
--
David Marchand
next prev parent reply other threads:[~2019-03-04 9:40 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-03-02 12:10 Igor Russkikh
2019-03-02 12:10 ` [dpdk-dev] [PATCH 01/10] net/atlantic: Fix negative error codes Igor Russkikh
2019-03-02 12:10 ` [dpdk-dev] [PATCH 02/10] net/atlantic: remove unused variable Igor Russkikh
2019-03-04 21:22 ` Rami Rosen
2019-03-02 12:10 ` [dpdk-dev] [PATCH 03/10] net/atlantic: check for error codes Igor Russkikh
2019-03-02 12:10 ` [dpdk-dev] [PATCH 04/10] net/atlantic: fix buffer overflow Igor Russkikh
2019-03-02 12:10 ` [dpdk-dev] [PATCH 05/10] net/atlantic: use eeprom magic as a device address Igor Russkikh
2019-03-02 12:10 ` [dpdk-dev] [PATCH 06/10] net/atlantic: fix eeprom fetching for small and uneven lengths Igor Russkikh
2019-03-02 12:10 ` [dpdk-dev] [PATCH 07/10] net/atlantic: fix link configuration Igor Russkikh
2019-03-02 12:10 ` [dpdk-dev] [PATCH 08/10] net/atlantic: eliminate excessive log levels on rx/tx Igor Russkikh
2019-03-02 12:10 ` [dpdk-dev] [PATCH 09/10] net/atlantic: fix missing vlan filter offload Igor Russkikh
2019-03-02 12:11 ` [dpdk-dev] [PATCH 10/10] net/atlantic: fix xstats to return correct number of requested items Igor Russkikh
2019-03-04 21:12 ` Rami Rosen
2019-03-04 9:40 ` David Marchand [this message]
2019-03-06 12:08 ` [dpdk-dev] [PATCH 00/10] net/atlantic: bugfixes and code cleanup Igor Russkikh
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CAJFAV8yo9jr8-P4B48=KMr9tm2M4ZBJ_Hw2iN_=PS-5_Kb0xNQ@mail.gmail.com' \
--to=david.marchand@redhat.com \
--cc=Igor.Russkikh@aquantia.com \
--cc=Pavel.Belous@aquantia.com \
--cc=dev@dpdk.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).