From: David Marchand <david.marchand@redhat.com>
To: Ciara Power <ciara.power@intel.com>
Cc: dev@dpdk.org, arkadiuszx.kusztal@intel.com, Kai Ji <kai.ji@intel.com>
Subject: Re: [PATCH] common/qat: enable gen4 c devices
Date: Fri, 11 Aug 2023 15:40:26 +0200 [thread overview]
Message-ID: <CAJFAV8z2NVqgnELy3HVhD4GXYgC6_AY_7gC3aXuYab70Vr3u1w@mail.gmail.com> (raw)
In-Reply-To: <20230811123833.3114791-1-ciara.power@intel.com>
Hello Ciara,
On Fri, Aug 11, 2023 at 2:38 PM Ciara Power <ciara.power@intel.com> wrote:
>
> This commit enables QAT 2.0c devices in the
> Intel QuickAssist Technology PMD.
It is hard to make a link between the commit title "gen 4 c devices",
the table below "402xxx" and the release notes "QAT 2.0c".
Can you use a single designation of this new device?
>
> Signed-off-by: Ciara Power <ciara.power@intel.com>
> ---
> doc/guides/cryptodevs/qat.rst | 4 ++++
> doc/guides/rel_notes/release_23_11.rst | 3 +++
> drivers/common/qat/qat_device.c | 4 ++++
> 3 files changed, 11 insertions(+)
>
> diff --git a/doc/guides/cryptodevs/qat.rst b/doc/guides/cryptodevs/qat.rst
> index afdfb0bd22..fc5a212d00 100644
> --- a/doc/guides/cryptodevs/qat.rst
> +++ b/doc/guides/cryptodevs/qat.rst
> @@ -457,6 +457,10 @@ to see the full table)
> +-----+-----+-----+-----+----------+---------------+---------------+------------+--------+------+--------+--------+
> | Yes | No | No | 4 | 401xxx | IDZ/ N/A | qat_401xxx | 4xxx | 4942 | 2 | 4943 | 16 |
> +-----+-----+-----+-----+----------+---------------+---------------+------------+--------+------+--------+--------+
> + | Yes | Yes | Yes | 4 | 402xxx | linux/6.4+ | qat_402xxx | 4xxx | 4944 | 2 | 4945 | 16 |
> + +-----+-----+-----+-----+----------+---------------+---------------+------------+--------+------+--------+--------+
> + | Yes | No | No | 4 | 402xxx | IDZ/ N/A | qat_402xxx | 4xxx | 4944 | 2 | 4945 | 16 |
> + +-----+-----+-----+-----+----------+---------------+---------------+------------+--------+------+--------+--------+
Is there such a kernel module named qat_402xxx upstream?
I can only find qat_4xxx.
>
> * Note: Symmetric mixed crypto algorithms feature on Gen 2 works only with IDZ driver version 4.9.0+
>
> diff --git a/doc/guides/rel_notes/release_23_11.rst b/doc/guides/rel_notes/release_23_11.rst
> index 4411bb32c1..3bdd51a4a5 100644
> --- a/doc/guides/rel_notes/release_23_11.rst
> +++ b/doc/guides/rel_notes/release_23_11.rst
> @@ -72,6 +72,9 @@ New Features
> Also, make sure to start the actual text at the margin.
> =======================================================
>
> +* **Added support for QAT 2.0c devices to Intel QuickAssist Technology PMD.**
> +
> + * QAT 2.0c (4944) devices are now enabled for QAT.
Missing an empty line.
>
> Removed Items
> -------------
> diff --git a/drivers/common/qat/qat_device.c b/drivers/common/qat/qat_device.c
> index 2675f0d9d1..cbf1e6a988 100644
> --- a/drivers/common/qat/qat_device.c
> +++ b/drivers/common/qat/qat_device.c
> @@ -50,6 +50,9 @@ static const struct rte_pci_id pci_id_qat_map[] = {
> {
> RTE_PCI_DEVICE(0x8086, 0x4943),
> },
> + {
> + RTE_PCI_DEVICE(0x8086, 0x4945),
> + },
> {.device_id = 0},
> };
>
> @@ -202,6 +205,7 @@ qat_pci_device_allocate(struct rte_pci_device *pci_dev,
> break;
> case 0x4941:
> case 0x4943:
> + case 0x4945:
> qat_dev_gen = QAT_GEN4;
> break;
> default:
> --
> 2.25.1
>
--
David Marchand
next prev parent reply other threads:[~2023-08-11 13:40 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-08-11 12:38 Ciara Power
2023-08-11 13:40 ` David Marchand [this message]
2023-08-21 9:37 ` Power, Ciara
2023-10-11 7:50 ` David Marchand
2023-08-21 9:33 ` [PATCH v2] common/qat: enable QAT 2.0c devices Ciara Power
2023-09-18 14:31 ` Dooley, Brian
2023-09-19 5:49 ` [EXT] " Akhil Goyal
2023-09-19 11:04 ` Power, Ciara
2023-09-19 12:38 ` Akhil Goyal
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CAJFAV8z2NVqgnELy3HVhD4GXYgC6_AY_7gC3aXuYab70Vr3u1w@mail.gmail.com \
--to=david.marchand@redhat.com \
--cc=arkadiuszx.kusztal@intel.com \
--cc=ciara.power@intel.com \
--cc=dev@dpdk.org \
--cc=kai.ji@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).