DPDK patches and discussions
 help / color / mirror / Atom feed
From: Akhil Goyal <gakhil@marvell.com>
To: Ciara Power <ciara.power@intel.com>, "dev@dpdk.org" <dev@dpdk.org>
Cc: "arkadiuszx.kusztal@intel.com" <arkadiuszx.kusztal@intel.com>,
	"david.marchand@redhat.com" <david.marchand@redhat.com>,
	Kai Ji <kai.ji@intel.com>
Subject: RE: [EXT] [PATCH v2] common/qat: enable QAT 2.0c devices
Date: Tue, 19 Sep 2023 05:49:46 +0000	[thread overview]
Message-ID: <CO6PR18MB448445AC50C77C92605A71CDD8FAA@CO6PR18MB4484.namprd18.prod.outlook.com> (raw)
In-Reply-To: <20230821093349.3519591-1-ciara.power@intel.com>


> This commit enables QAT 2.0c devices in the
> Intel QuickAssist Technology PMD.
> These are 4th Generation QAT, 402xx devices.
> 
> Signed-off-by: Ciara Power <ciara.power@intel.com>
> 
> ---
> v2:
>   - Fixed kernel module.
>   - Modified commit to align naming of new QAT device.
> ---
>  doc/guides/cryptodevs/qat.rst          | 4 ++++
>  doc/guides/rel_notes/release_23_11.rst | 4 ++++
>  drivers/common/qat/qat_device.c        | 4 ++++
>  3 files changed, 12 insertions(+)
> 
> diff --git a/doc/guides/cryptodevs/qat.rst b/doc/guides/cryptodevs/qat.rst
> index afdfb0bd22..730113da33 100644
> --- a/doc/guides/cryptodevs/qat.rst
> +++ b/doc/guides/cryptodevs/qat.rst
> @@ -457,6 +457,10 @@ to see the full table)
>     +-----+-----+-----+-----+----------+---------------+---------------+------------+--------
> +------+--------+--------+
>     | Yes | No  | No  | 4   | 401xxx   | IDZ/ N/A      | qat_401xxx    | 4xxx       | 4942
> | 2    | 4943   | 16     |
>     +-----+-----+-----+-----+----------+---------------+---------------+------------+--------
> +------+--------+--------+
> +   | Yes | Yes | Yes | 4   | 402xx    | linux/6.4+    | qat_4xxx      | 4xxx       | 4944
> | 2    | 4945   | 16     |
> +   +-----+-----+-----+-----+----------+---------------+---------------+------------+--------
> +------+--------+--------+
> +   | Yes | No  | No  | 4   | 402xx    | IDZ/ N/A      | qat_4xxx      | 4xxx       | 4944
> | 2    | 4945   | 16     |
> +   +-----+-----+-----+-----+----------+---------------+---------------+------------+--------
> +------+--------+--------+
> 
>  * Note: Symmetric mixed crypto algorithms feature on Gen 2 works only with
> IDZ driver version 4.9.0+
> 
> diff --git a/doc/guides/rel_notes/release_23_11.rst
> b/doc/guides/rel_notes/release_23_11.rst
> index 4411bb32c1..72dfb3fbf0 100644
> --- a/doc/guides/rel_notes/release_23_11.rst
> +++ b/doc/guides/rel_notes/release_23_11.rst
> @@ -72,6 +72,10 @@ New Features
>       Also, make sure to start the actual text at the margin.
>       =======================================================
> 
> +* **Added support for QAT 2.0c devices to Intel QuickAssist Technology
> PMD.**
> +
> +  * QAT 2.0c (4944) devices are now enabled for QAT.

Is it 4944 or 4945? In the code below, the PCI device added is 4945


> +
> 
>  Removed Items
>  -------------
> diff --git a/drivers/common/qat/qat_device.c
> b/drivers/common/qat/qat_device.c
> index 2675f0d9d1..cbf1e6a988 100644
> --- a/drivers/common/qat/qat_device.c
> +++ b/drivers/common/qat/qat_device.c
> @@ -50,6 +50,9 @@ static const struct rte_pci_id pci_id_qat_map[] = {
>  		{
>  			RTE_PCI_DEVICE(0x8086, 0x4943),
>  		},
> +		{
> +			RTE_PCI_DEVICE(0x8086, 0x4945),
> +		},
>  		{.device_id = 0},
>  };
> 
> @@ -202,6 +205,7 @@ qat_pci_device_allocate(struct rte_pci_device *pci_dev,
>  		break;
>  	case 0x4941:
>  	case 0x4943:
> +	case 0x4945:
>  		qat_dev_gen = QAT_GEN4;
>  		break;
>  	default:
> --
> 2.25.1


  parent reply	other threads:[~2023-09-19  5:49 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-08-11 12:38 [PATCH] common/qat: enable gen4 c devices Ciara Power
2023-08-11 13:40 ` David Marchand
2023-08-21  9:37   ` Power, Ciara
2023-10-11  7:50     ` David Marchand
2023-08-21  9:33 ` [PATCH v2] common/qat: enable QAT 2.0c devices Ciara Power
2023-09-18 14:31   ` Dooley, Brian
2023-09-19  5:49   ` Akhil Goyal [this message]
2023-09-19 11:04     ` [EXT] " Power, Ciara
2023-09-19 12:38       ` Akhil Goyal

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=CO6PR18MB448445AC50C77C92605A71CDD8FAA@CO6PR18MB4484.namprd18.prod.outlook.com \
    --to=gakhil@marvell.com \
    --cc=arkadiuszx.kusztal@intel.com \
    --cc=ciara.power@intel.com \
    --cc=david.marchand@redhat.com \
    --cc=dev@dpdk.org \
    --cc=kai.ji@intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).