From: David Marchand <david.marchand@redhat.com>
To: Maxime Coquelin <maxime.coquelin@redhat.com>
Cc: dev <dev@dpdk.org>, Chenbo Xia <chenbo.xia@intel.com>
Subject: Re: [PATCH v3 3/4] vhost: keep a reference to virtqueue index
Date: Tue, 26 Jul 2022 12:00:55 +0200 [thread overview]
Message-ID: <CAJFAV8zPDyy3dvYz9GZJ0w4js0wObgANmT6hmkq9Zj+KC-q=8w@mail.gmail.com> (raw)
In-Reply-To: <4cd4f7bf-da0d-5ddd-9783-afd7c1b1a3fc@redhat.com>
On Tue, Jul 26, 2022 at 10:52 AM Maxime Coquelin
<maxime.coquelin@redhat.com> wrote:
> > @@ -2275,12 +2267,11 @@ rte_vhost_clear_queue(int vid, uint16_t queue_id, struct rte_mbuf **pkts,
> > }
> >
> > if ((queue_id & 1) == 0)
> > - n_pkts_cpl = vhost_poll_enqueue_completed(dev, queue_id,
> > - pkts, count, dma_id, vchan_id);
> > - else {
> > + n_pkts_cpl = vhost_poll_enqueue_completed(dev, vq, pkts, count,
> > + dma_id, vchan_id);
> > + else
> > n_pkts_cpl = async_poll_dequeue_completed(dev, vq, pkts, count,
> > - dma_id, vchan_id, dev->flags & VIRTIO_DEV_LEGACY_OL_FLAGS);
> > - }
> > + dma_id, vchan_id, dev->flags & VIRTIO_DEV_LEGACY_OL_FLAGS);
>
> One of the two functions should be renamed for consistency, but that's
> not the point of this series.
The async prefix makes sense, so renaming vhost_poll_enqueue_completed
as async_poll_enqueue_completed seems the way to go.
I don't mind sending a separate patch for this.
--
David Marchand
next prev parent reply other threads:[~2022-07-26 10:01 UTC|newest]
Thread overview: 25+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-07-22 13:53 [PATCH 1/2] " David Marchand
2022-07-22 13:53 ` [PATCH 2/2] vhost: stop using mempool for IOTLB David Marchand
2022-07-22 14:00 ` [PATCH 1/2] vhost: keep a reference to virtqueue index David Marchand
2022-07-22 15:13 ` David Marchand
2022-07-25 7:11 ` [PATCH v2 " David Marchand
2022-07-25 7:11 ` [PATCH v2 2/2] vhost: stop using mempool for IOTLB cache David Marchand
2022-07-25 20:32 ` [PATCH v3 0/4] vHost IOTLB cache rework David Marchand
2022-07-25 20:32 ` [PATCH v3 1/4] vhost: fix vq use after free on NUMA reallocation David Marchand
2022-07-26 7:55 ` Maxime Coquelin
2022-09-13 15:02 ` Maxime Coquelin
2022-09-14 1:05 ` Xia, Chenbo
2022-09-14 7:14 ` Maxime Coquelin
2022-09-14 9:15 ` Thomas Monjalon
2022-09-14 9:34 ` Maxime Coquelin
2022-09-14 9:45 ` Thomas Monjalon
2022-09-14 11:48 ` Maxime Coquelin
2022-07-25 20:32 ` [PATCH v3 2/4] vhost: make NUMA reallocation code more robust David Marchand
2022-07-26 8:39 ` Maxime Coquelin
2022-07-25 20:32 ` [PATCH v3 3/4] vhost: keep a reference to virtqueue index David Marchand
2022-07-26 8:52 ` Maxime Coquelin
2022-07-26 10:00 ` David Marchand [this message]
2022-07-25 20:32 ` [PATCH v3 4/4] vhost: stop using mempool for IOTLB cache David Marchand
2022-07-26 9:26 ` Maxime Coquelin
2023-02-17 7:42 ` Yuan, DukaiX
2022-09-15 16:02 ` [PATCH v3 0/4] vHost IOTLB cache rework Thomas Monjalon
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CAJFAV8zPDyy3dvYz9GZJ0w4js0wObgANmT6hmkq9Zj+KC-q=8w@mail.gmail.com' \
--to=david.marchand@redhat.com \
--cc=chenbo.xia@intel.com \
--cc=dev@dpdk.org \
--cc=maxime.coquelin@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).