DPDK patches and discussions
 help / color / mirror / Atom feed
From: Jerin Jacob <jerinjacobk@gmail.com>
To: Naga Harish K S V <s.v.naga.harish.k@intel.com>
Cc: dev@dpdk.org, jay.jayatheerthan@intel.com,
	"Erik Gabriel Carrillo" <erik.g.carrillo@intel.com>,
	"Gujjar, Abhinandan S" <abhinandan.gujjar@intel.com>,
	"McDaniel, Timothy" <timothy.mcdaniel@intel.com>,
	"Pavan Nikhilesh" <pbhagavatula@marvell.com>,
	"Shijith Thotton" <sthotton@marvell.com>,
	"Hemant Agrawal" <hemant.agrawal@nxp.com>,
	"Sachin Saxena" <sachin.saxena@oss.nxp.com>,
	"Van Haaren, Harry" <harry.van.haaren@intel.com>,
	"Mattias Rönnblom" <mattias.ronnblom@ericsson.com>,
	"Liang Ma" <liangma@liangbit.com>,
	"Peter Mccarthy" <peter.mccarthy@intel.com>
Subject: Re: [PATCH v2] eventdev/eth_rx: add new adapter create API
Date: Thu, 17 Aug 2023 14:27:20 +0530	[thread overview]
Message-ID: <CALBAE1PjHjvfLM-xoV3w2cp_d=k6XqRpDZupY2Vds9cWLxTuqg@mail.gmail.com> (raw)
In-Reply-To: <20230817060318.4101024-1-s.v.naga.harish.k@intel.com>

On Thu, Aug 17, 2023 at 11:33 AM Naga Harish K S V
<s.v.naga.harish.k@intel.com> wrote:
>
> Add new API "rte_event_eth_rx_adapter_create_ext_with_params()" for
> creating Rx adapter instance. This API is similar to
> rte_event_eth_rx_adapter_create_ext() with an additional input
> argument for adapter configuration parameters of type
> "struct rte_event_eth_rx_adapter_params".
>
> Signed-off-by: Naga Harish K S V <s.v.naga.harish.k@intel.com>

> + */
> +__rte_experimental
> +int __rte_cold

Is there any specific reason to keep __rte_cold here? None of the
other libraries has this.
Rest looks good to me.

For library changes, please keep all evendev maintainers in Cc. I have
added those now for this email.


> +rte_event_eth_rx_adapter_create_ext_with_params(uint8_t id, uint8_t dev_id,
> +                       rte_event_eth_rx_adapter_conf_cb conf_cb,
> +                       void *conf_arg,
> +                       struct rte_event_eth_rx_adapter_params *rxa_params);

  reply	other threads:[~2023-08-17  8:57 UTC|newest]

Thread overview: 19+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-08-17  5:37 [PATCH] " Naga Harish K S V
2023-08-17  6:03 ` [PATCH v2] " Naga Harish K S V
2023-08-17  8:57   ` Jerin Jacob [this message]
2023-08-17  9:36     ` Naga Harish K, S V
2023-08-17  9:48       ` Jerin Jacob
2023-08-17 10:36         ` Naga Harish K, S V
2023-08-17 10:33   ` [PATCH v3] " Naga Harish K S V
2023-08-17 10:42     ` Jerin Jacob
2023-08-17 14:52       ` Naga Harish K, S V
2023-08-17 14:50     ` [PATCH v4] " Naga Harish K S V
2023-08-17 15:19       ` Jerin Jacob
2023-08-18  9:39         ` Naga Harish K, S V
2023-08-18  9:37       ` [PATCH v5] " Naga Harish K S V
2023-08-21  9:52         ` Jerin Jacob
2023-08-21 15:28         ` [PATCH v6] " Naga Harish K S V
2023-08-21 15:36           ` Jerin Jacob
2023-08-22  1:05             ` Naga Harish K, S V
2023-08-21 15:44           ` [PATCH v7] " Naga Harish K S V
2023-08-22  4:55             ` Jerin Jacob

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to='CALBAE1PjHjvfLM-xoV3w2cp_d=k6XqRpDZupY2Vds9cWLxTuqg@mail.gmail.com' \
    --to=jerinjacobk@gmail.com \
    --cc=abhinandan.gujjar@intel.com \
    --cc=dev@dpdk.org \
    --cc=erik.g.carrillo@intel.com \
    --cc=harry.van.haaren@intel.com \
    --cc=hemant.agrawal@nxp.com \
    --cc=jay.jayatheerthan@intel.com \
    --cc=liangma@liangbit.com \
    --cc=mattias.ronnblom@ericsson.com \
    --cc=pbhagavatula@marvell.com \
    --cc=peter.mccarthy@intel.com \
    --cc=s.v.naga.harish.k@intel.com \
    --cc=sachin.saxena@oss.nxp.com \
    --cc=sthotton@marvell.com \
    --cc=timothy.mcdaniel@intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).