From: "Naga Harish K, S V" <s.v.naga.harish.k@intel.com>
To: Jerin Jacob <jerinjacobk@gmail.com>
Cc: "dev@dpdk.org" <dev@dpdk.org>,
"Jayatheerthan, Jay" <jay.jayatheerthan@intel.com>,
"Carrillo, Erik G" <erik.g.carrillo@intel.com>,
"Gujjar, Abhinandan S" <abhinandan.gujjar@intel.com>,
"McDaniel, Timothy" <timothy.mcdaniel@intel.com>,
Pavan Nikhilesh <pbhagavatula@marvell.com>,
Shijith Thotton <sthotton@marvell.com>,
Hemant Agrawal <hemant.agrawal@nxp.com>,
Sachin Saxena <sachin.saxena@oss.nxp.com>,
"Van Haaren, Harry" <harry.van.haaren@intel.com>,
mattias.ronnblom <mattias.ronnblom@ericsson.com>,
Liang Ma <liangma@liangbit.com>,
"Mccarthy, Peter" <peter.mccarthy@intel.com>
Subject: RE: [PATCH v2] eventdev/eth_rx: add new adapter create API
Date: Thu, 17 Aug 2023 10:36:33 +0000 [thread overview]
Message-ID: <DM6PR11MB3868D4239C076BA1A0E6D819A11AA@DM6PR11MB3868.namprd11.prod.outlook.com> (raw)
In-Reply-To: <CALBAE1O6jpt3jWfBW=ZpQFnTedQjQbEQygwA=RAjxr+cKr6G8A@mail.gmail.com>
> -----Original Message-----
> From: Jerin Jacob <jerinjacobk@gmail.com>
> Sent: Thursday, August 17, 2023 3:18 PM
> To: Naga Harish K, S V <s.v.naga.harish.k@intel.com>
> Cc: dev@dpdk.org; Jayatheerthan, Jay <jay.jayatheerthan@intel.com>;
> Carrillo, Erik G <erik.g.carrillo@intel.com>; Gujjar, Abhinandan S
> <abhinandan.gujjar@intel.com>; McDaniel, Timothy
> <timothy.mcdaniel@intel.com>; Pavan Nikhilesh
> <pbhagavatula@marvell.com>; Shijith Thotton <sthotton@marvell.com>;
> Hemant Agrawal <hemant.agrawal@nxp.com>; Sachin Saxena
> <sachin.saxena@oss.nxp.com>; Van Haaren, Harry
> <harry.van.haaren@intel.com>; mattias.ronnblom
> <mattias.ronnblom@ericsson.com>; Liang Ma <liangma@liangbit.com>;
> Mccarthy, Peter <peter.mccarthy@intel.com>
> Subject: Re: [PATCH v2] eventdev/eth_rx: add new adapter create API
>
> On Thu, Aug 17, 2023 at 3:06 PM Naga Harish K, S V
> <s.v.naga.harish.k@intel.com> wrote:
> >
> >
> >
> > > -----Original Message-----
> > > From: Jerin Jacob <jerinjacobk@gmail.com>
> > > Sent: Thursday, August 17, 2023 2:27 PM
> > > To: Naga Harish K, S V <s.v.naga.harish.k@intel.com>
> > > Cc: dev@dpdk.org; Jayatheerthan, Jay <jay.jayatheerthan@intel.com>;
> > > Carrillo, Erik G <erik.g.carrillo@intel.com>; Gujjar, Abhinandan S
> > > <abhinandan.gujjar@intel.com>; McDaniel, Timothy
> > > <timothy.mcdaniel@intel.com>; Pavan Nikhilesh
> > > <pbhagavatula@marvell.com>; Shijith Thotton <sthotton@marvell.com>;
> > > Hemant Agrawal <hemant.agrawal@nxp.com>; Sachin Saxena
> > > <sachin.saxena@oss.nxp.com>; Van Haaren, Harry
> > > <harry.van.haaren@intel.com>; mattias.ronnblom
> > > <mattias.ronnblom@ericsson.com>; Liang Ma <liangma@liangbit.com>;
> > > Mccarthy, Peter <peter.mccarthy@intel.com>
> > > Subject: Re: [PATCH v2] eventdev/eth_rx: add new adapter create API
> > >
> > > On Thu, Aug 17, 2023 at 11:33 AM Naga Harish K S V
> > > <s.v.naga.harish.k@intel.com> wrote:
> > > >
> > > > Add new API "rte_event_eth_rx_adapter_create_ext_with_params()"
> > > > for creating Rx adapter instance. This API is similar to
> > > > rte_event_eth_rx_adapter_create_ext() with an additional input
> > > > argument for adapter configuration parameters of type "struct
> > > > rte_event_eth_rx_adapter_params".
> > > >
> > > > Signed-off-by: Naga Harish K S V <s.v.naga.harish.k@intel.com>
> > >
> > > > + */
> > > > +__rte_experimental
> > > > +int __rte_cold
> > >
> > > Is there any specific reason to keep __rte_cold here? None of the
> > > other libraries has this.
> >
> > __rte_cold is a hint function in the cold path. It is used for code
> > optimization purposes and many net PMDs are using this.
>
> I understand that, the question was more on what is the significance of that
> for this specific API ?
> There are a lot of slow path APIs in evendev and all other library none of
> them use it.
> It just put into different section of binary and optimize more for size. I think,
> there is no specific reason to add this ONLY for this API to make it standout.
>
Removed __rte_cold attribute for this API to be in sync with other eventdev library APIs.
The updated patch is posted in V3.
> Also, The cold attribute is not implemented in GCC versions earlier than 4.3.
>
>
>
>
> >
> > > Rest looks good to me.
> > >
> > > For library changes, please keep all evendev maintainers in Cc. I
> > > have added those now for this email.
> > >
> > >
> > > > +rte_event_eth_rx_adapter_create_ext_with_params(uint8_t id,
> > > > +uint8_t
> > > dev_id,
> > > > + rte_event_eth_rx_adapter_conf_cb conf_cb,
> > > > + void *conf_arg,
> > > > + struct rte_event_eth_rx_adapter_params
> > > > +*rxa_params);
next prev parent reply other threads:[~2023-08-17 10:36 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-08-17 5:37 [PATCH] " Naga Harish K S V
2023-08-17 6:03 ` [PATCH v2] " Naga Harish K S V
2023-08-17 8:57 ` Jerin Jacob
2023-08-17 9:36 ` Naga Harish K, S V
2023-08-17 9:48 ` Jerin Jacob
2023-08-17 10:36 ` Naga Harish K, S V [this message]
2023-08-17 10:33 ` [PATCH v3] " Naga Harish K S V
2023-08-17 10:42 ` Jerin Jacob
2023-08-17 14:52 ` Naga Harish K, S V
2023-08-17 14:50 ` [PATCH v4] " Naga Harish K S V
2023-08-17 15:19 ` Jerin Jacob
2023-08-18 9:39 ` Naga Harish K, S V
2023-08-18 9:37 ` [PATCH v5] " Naga Harish K S V
2023-08-21 9:52 ` Jerin Jacob
2023-08-21 15:28 ` [PATCH v6] " Naga Harish K S V
2023-08-21 15:36 ` Jerin Jacob
2023-08-22 1:05 ` Naga Harish K, S V
2023-08-21 15:44 ` [PATCH v7] " Naga Harish K S V
2023-08-22 4:55 ` Jerin Jacob
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=DM6PR11MB3868D4239C076BA1A0E6D819A11AA@DM6PR11MB3868.namprd11.prod.outlook.com \
--to=s.v.naga.harish.k@intel.com \
--cc=abhinandan.gujjar@intel.com \
--cc=dev@dpdk.org \
--cc=erik.g.carrillo@intel.com \
--cc=harry.van.haaren@intel.com \
--cc=hemant.agrawal@nxp.com \
--cc=jay.jayatheerthan@intel.com \
--cc=jerinjacobk@gmail.com \
--cc=liangma@liangbit.com \
--cc=mattias.ronnblom@ericsson.com \
--cc=pbhagavatula@marvell.com \
--cc=peter.mccarthy@intel.com \
--cc=sachin.saxena@oss.nxp.com \
--cc=sthotton@marvell.com \
--cc=timothy.mcdaniel@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).