From: David Marchand <david.marchand@6wind.com>
To: Chao Zhu <chaozhu@linux.vnet.ibm.com>
Cc: "dev@dpdk.org" <dev@dpdk.org>,
"Richardson, Bruce" <bruce.richardson@intel.com>,
Panu Matilainen <pmatilai@redhat.com>
Subject: Re: [dpdk-dev] [PATCH 1/2] Fix CPU and memory parameters on IBM POWER8
Date: Fri, 25 Mar 2016 09:48:24 +0100 [thread overview]
Message-ID: <CALwxeUtSYMaP1+ovur6=svZf=n0NwopQM9iDRo-B4Ys5NBOS8A@mail.gmail.com> (raw)
In-Reply-To: <1458893513-22406-2-git-send-email-chaozhu@linux.vnet.ibm.com>
On Fri, Mar 25, 2016 at 9:11 AM, Chao Zhu <chaozhu@linux.vnet.ibm.com> wrote:
> This patch fixes the max logic number and memory channel number settings
> on IBM POWER8 platform.
> 1. The max number of logic cores of a POWER8 processor is 96. Normally,
> there are two sockets on a server. So the max number of logic cores
> are 192. So this parch set CONFIG_RTE_MAX_LCORE to 256.
This is a power8 configuration item, this should go to power8 config
file, not common_base.
> 2. Currently, the max number of memory channels are hardcoded to 4. However,
> on a POWER8 machine, the max number of memory channels are 8. To fix this,
> CONFIG_RTE_MAX_NCHANNELS is added to do the configuration.
I don't see any reason why we would need a max value for force_nchannel.
We should just get rid of this check, this is an obscure parameter for
most people, so people playing with it know what they are doing
(hopefully ?).
On the other hand, if power8 has some specifics about it, maybe we
should introduce some default value in a arch eal header for other
dpdk components to use (like in mempool).
Thoughts ?
--
David Marchand
next prev parent reply other threads:[~2016-03-25 8:48 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-03-25 8:11 [dpdk-dev] [PATCH 0/2] Fix parameters and prefetch function " Chao Zhu
2016-03-25 8:11 ` [dpdk-dev] [PATCH 1/2] Fix CPU and memory parameters " Chao Zhu
2016-03-25 8:48 ` David Marchand [this message]
2016-03-30 10:52 ` Thomas Monjalon
2016-03-31 1:44 ` Chao Zhu
2016-03-25 8:11 ` [dpdk-dev] [PATCH 2/2] Fix prefetch instruction " Chao Zhu
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CALwxeUtSYMaP1+ovur6=svZf=n0NwopQM9iDRo-B4Ys5NBOS8A@mail.gmail.com' \
--to=david.marchand@6wind.com \
--cc=bruce.richardson@intel.com \
--cc=chaozhu@linux.vnet.ibm.com \
--cc=dev@dpdk.org \
--cc=pmatilai@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).