From: Hiroyuki MIKITA <h.mikita89@gmail.com>
To: Thomas Monjalon <thomas.monjalon@6wind.com>,
"Ananyev, Konstantin" <konstantin.ananyev@intel.com>,
Olivier Matz <olivier.matz@6wind.com>
Cc: dev@dpdk.org
Subject: Re: [dpdk-dev] [PATCH] mbuf: decrease refcnt when detaching
Date: Tue, 17 May 2016 01:24:34 +0900 [thread overview]
Message-ID: <CAO_n4D1oMjxMFAfDJrOWi1i=yPqbVUXjoDQjicbQLU6CqvoazQ@mail.gmail.com> (raw)
In-Reply-To: <2574937.kpQRctJEWQ@xps13>
Hi all,
Thanks for suggestions.
I think the Oliver's first option is good.
I introduce the new function and will replace rte_pktmbuf_detach()
with it in a future release.
2016-05-16 18:13 GMT+09:00 Thomas Monjalon <thomas.monjalon@6wind.com>:
> 2016-05-16 11:46, Hiroyuki MIKITA:
>> Now, the attach operation increases refcnt, but the detach does not decrease it.
>> I think both operations should affect refcnt or not.
>> Which design is intended?
>>
>> In "6.7. Direct and Indirect Buffers" of Programmer's Guide,
>> it is mentioned that "...whenever an indirect buffer is attached to
>> the direct buffer,
>> the reference counter on the direct buffer is incremented.
>> Similarly, whenever the indirect buffer is detached,
>> the reference counter on the direct buffer is decremented."
>
> The doc is the reference. The doxygen comment should explicit every
> details of the behaviour.
> And the unit tests must validate every parts of the behaviour.
> Probably there is a bug which is not (yet) tested.
> Please see the function testclone_testupdate_testdetach. Thanks
>
next prev parent reply other threads:[~2016-05-16 16:24 UTC|newest]
Thread overview: 23+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-05-15 15:50 Hiroyuki Mikita
2016-05-16 0:05 ` Ananyev, Konstantin
2016-05-16 2:46 ` Hiroyuki MIKITA
2016-05-16 8:49 ` Ananyev, Konstantin
2016-05-16 9:13 ` Thomas Monjalon
2016-05-16 16:24 ` Hiroyuki MIKITA [this message]
2016-05-16 8:52 ` Olivier Matz
2016-05-16 16:53 ` [dpdk-dev] [PATCH v2] " Hiroyuki Mikita
2016-05-17 10:58 ` Bruce Richardson
2016-05-17 11:06 ` Ananyev, Konstantin
2016-05-17 12:43 ` Thomas Monjalon
2016-05-17 12:59 ` Ananyev, Konstantin
2016-05-17 13:39 ` Thomas Monjalon
2016-05-17 13:44 ` Ananyev, Konstantin
2016-05-17 14:19 ` Thomas Monjalon
2016-05-17 15:45 ` Ananyev, Konstantin
2016-05-17 16:12 ` Hiroyuki MIKITA
2016-05-17 16:35 ` [dpdk-dev] [PATCH v3] " Hiroyuki Mikita
2016-05-18 11:58 ` Olivier Matz
2016-05-18 14:29 ` Hiroyuki Mikita
2016-05-18 14:41 ` [dpdk-dev] [PATCH v4] " Hiroyuki Mikita
2016-05-18 15:51 ` Olivier Matz
2016-05-19 12:38 ` Thomas Monjalon
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CAO_n4D1oMjxMFAfDJrOWi1i=yPqbVUXjoDQjicbQLU6CqvoazQ@mail.gmail.com' \
--to=h.mikita89@gmail.com \
--cc=dev@dpdk.org \
--cc=konstantin.ananyev@intel.com \
--cc=olivier.matz@6wind.com \
--cc=thomas.monjalon@6wind.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).