From: "Juraj Linkeš" <juraj.linkes@pantheon.tech>
To: Bruce Richardson <bruce.richardson@intel.com>
Cc: Luca Vizzarro <Luca.Vizzarro@arm.com>,
Nicholas Pratte <npratte@iol.unh.edu>,
yoan.picchi@foss.arm.com, paul.szczepanek@arm.com,
wathsala.vithanage@arm.com, thomas@monjalon.net,
Honnappa.Nagarahalli@arm.com, probb@iol.unh.edu, dev@dpdk.org
Subject: Re: [PATCH v5 2/2] dts: Change hugepage 'amount' to a different term
Date: Mon, 13 May 2024 12:06:21 +0200 [thread overview]
Message-ID: <CAOb5WZaY+3BJW0fOowBuEE+7wiqEEwzT_sZOiOUtTQjjthLhSw@mail.gmail.com> (raw)
In-Reply-To: <Zjol1w3ClLi1MLYP@bricha3-mobl1.ger.corp.intel.com>
On Tue, May 7, 2024 at 3:00 PM Bruce Richardson
<bruce.richardson@intel.com> wrote:
>
> On Tue, May 07, 2024 at 01:43:30PM +0100, Luca Vizzarro wrote:
> > On 07/05/2024 13:05, Bruce Richardson wrote:
> > > Sorry to be late to the reviews here, but since this is a countable value -
> > > as you state in the cover letter- would "number" or "count" not be better
> > > terms. To me, "quantity" is just a synonym of "amount", and can be used for
> > > uncountable values too, e.g. "a quantity of water".
> >
> >
> > Hi Bruce,
> >
> > The change is based on the readability and intuitiveness of the
> > configuration file. In which case "number" could be ambiguous:
> >
> > hugepages_2mb:
> > number: 100
> >
> > And here I could see "count" working:
> >
> > hugepages_2mb:
> > count: 100
> >
We could use number_of: but that doesn't look great. Count looks fine.
> > But since the change is propagated for consistency. "count" would no longer
> > be well fitting in the rest:
> >
> > "description": "The count of hugepages to configure. Hugepage
> > size will be the system default."
> >
> Whatever term is actually used, the description should definitely refer to
> "The number of hugepages to configure".
This makes sense, let's use "number of" in descriptions.
Ideally we'd also use number in code, but it's a bit ambiguous, such as here:
def _configure_huge_pages(self, number: int, size: int,
force_first_numa: bool) -> None:
At a first glance it's not quite clear what "number" is here.
"number_of" would be pretty clear, but so would be "count". But using
count would mean we're using different words with the same meaning in
the same context, which I'd also like to avoid - this is the reason
why I was originally ok with quantity. Now I'm not sure what the best
option is :-)
next prev parent reply other threads:[~2024-05-13 10:06 UTC|newest]
Thread overview: 33+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-04-30 18:45 [PATCH v5 1/2] dts: Change hugepage runtime config to 2MB Exclusively Nicholas Pratte
2024-04-30 18:45 ` [PATCH v5 2/2] dts: Change hugepage 'amount' to a different term Nicholas Pratte
2024-05-02 11:55 ` Juraj Linkeš
2024-05-07 11:15 ` Luca Vizzarro
2024-05-07 12:05 ` Bruce Richardson
2024-05-07 12:43 ` Luca Vizzarro
2024-05-07 13:00 ` Bruce Richardson
2024-05-13 10:06 ` Juraj Linkeš [this message]
2024-05-15 15:12 ` Nicholas Pratte
2024-04-30 18:45 ` [PATCH v5 0/2] Methodology change for hugepage configuration Nicholas Pratte
2024-05-07 11:16 ` Luca Vizzarro
2024-05-07 16:37 ` [PATCH v6 " Nicholas Pratte
2024-05-07 16:37 ` [PATCH v6 1/2] dts: Change hugepage runtime config to 2MB Exclusively Nicholas Pratte
2024-05-07 16:37 ` [PATCH v6 2/2] dts: Change hugepage 'amount' to a different term Nicholas Pratte
2024-05-07 17:44 ` [PATCH v6 0/2] Methodology change for hugepage configuration Nicholas Pratte
2024-05-07 17:44 ` [PATCH v6 1/2] dts: Change hugepage runtime config to 2MB Exclusively Nicholas Pratte
2024-05-07 17:44 ` [PATCH v6 2/2] dts: Change hugepage 'amount' to a different term Nicholas Pratte
2024-05-07 17:46 ` [PATCH v6 0/2] Methodology change for hugepage configuration Nicholas Pratte
2024-05-13 9:53 ` Juraj Linkeš
2024-05-15 14:50 ` Nicholas Pratte
2024-05-29 10:30 ` Juraj Linkeš
2024-05-30 17:58 ` [PATCH v7 " Nicholas Pratte
2024-05-30 17:58 ` [PATCH v7 1/2] dts: Change hugepage runtime config to 2MB Exclusively Nicholas Pratte
2024-05-30 17:58 ` [PATCH v7 2/2] dts: Change hugepage 'amount' to a different term Nicholas Pratte
2024-05-30 18:37 ` [PATCH v8 0/2] Methodology change for hugepage configuration Nicholas Pratte
2024-05-30 19:37 ` Nicholas Pratte
2024-05-30 19:37 ` [PATCH v8 1/2] dts: Change hugepage runtime config to 2MB Exclusively Nicholas Pratte
2024-05-31 6:52 ` Juraj Linkeš
2024-05-31 11:37 ` Luca Vizzarro
2024-05-30 19:38 ` [PATCH v8 2/2] dts: Change hugepage 'amount' to a different term Nicholas Pratte
2024-05-31 6:53 ` Juraj Linkeš
2024-05-31 11:37 ` Luca Vizzarro
2024-05-02 11:55 ` [PATCH v5 1/2] dts: Change hugepage runtime config to 2MB Exclusively Juraj Linkeš
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CAOb5WZaY+3BJW0fOowBuEE+7wiqEEwzT_sZOiOUtTQjjthLhSw@mail.gmail.com \
--to=juraj.linkes@pantheon.tech \
--cc=Honnappa.Nagarahalli@arm.com \
--cc=Luca.Vizzarro@arm.com \
--cc=bruce.richardson@intel.com \
--cc=dev@dpdk.org \
--cc=npratte@iol.unh.edu \
--cc=paul.szczepanek@arm.com \
--cc=probb@iol.unh.edu \
--cc=thomas@monjalon.net \
--cc=wathsala.vithanage@arm.com \
--cc=yoan.picchi@foss.arm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).